fix: T MAP 경로 검색 결과가 존재 하지 않는 경우 에러 처리

DoTheBestMayB · DoTheBestMayB · commit ebb040e2b740 · 2022-12-04T02:45:45.000+09:00
diff --git a/data/src/main/java/com/stop/data/remote/ResultCall.kt b/data/src/main/java/com/stop/data/remote/ResultCall.kt
@@ -47,17 +47,17 @@ internal class ResultCall<T : Any>(private val call: Call<T>) : Call<NetworkResu
                         this@ResultCall,
                         Response.success(NetworkResult.Success(responseBody))
                     )
-                } else {
-                    callback.onResponse(
-                        this@ResultCall,
-                        Response.success(
-                            NetworkResult.Failure(
-                                response.code(),
-                                response.errorBody()?.string()
-                            )
+                    return
+                }
+                callback.onResponse(
+                    this@ResultCall,
+                    Response.success(
+                        NetworkResult.Failure(
+                            response.code(),
+                            response.errorBody()?.string()
                         )
                     )
-                }
+                )
             }
 
             override fun onFailure(call: Call<T>, t: Throwable) {
diff --git a/data/src/main/java/com/stop/data/remote/source/route/RouteRemoteDataSourceImpl.kt b/data/src/main/java/com/stop/data/remote/source/route/RouteRemoteDataSourceImpl.kt
@@ -1,5 +1,6 @@
 package com.stop.data.remote.source.route
 
+import com.squareup.moshi.JsonDataException
 import com.stop.data.remote.model.NetworkResult
 import com.stop.data.remote.network.ApisDataService
 import com.stop.data.remote.network.OpenApiSeoulService
@@ -30,7 +31,11 @@ internal class RouteRemoteDataSourceImpl @Inject constructor(
             tMapApiService.getRoutes(routeRequest.toMap())
         ) {
             return when (this) {
-                is NetworkResult.Success -> eraseDuplicateLeg(this.data.metaData.plan.itineraries)
+                is NetworkResult.Success -> {
+                    val itineraries = this.data.metaData?.plan?.itineraries
+                        ?: throw JsonDataException(NO_ROUTE_RESULT)
+                    eraseDuplicateLeg(itineraries)
+                }
                 is NetworkResult.Failure -> throw IllegalArgumentException(this.message)
                 is NetworkResult.NetworkError -> throw this.exception
                 is NetworkResult.Unexpected -> throw this.exception
@@ -242,5 +247,6 @@ internal class RouteRemoteDataSourceImpl @Inject constructor(
 
     companion object {
         private const val NO_SUBWAY_STATION = "해당하는 지하철역이 없습니다."
+        private const val NO_ROUTE_RESULT = "경로 검색 결과가 없습니다."
     }
 }
diff --git a/data/src/main/java/com/stop/data/repository/RouteRepositoryImpl.kt b/data/src/main/java/com/stop/data/repository/RouteRepositoryImpl.kt
@@ -1,5 +1,6 @@
 package com.stop.data.repository
 
+import com.squareup.moshi.JsonDataException
 import com.stop.data.remote.source.route.RouteRemoteDataSource
 import com.stop.domain.model.geoLocation.AddressType
 import com.stop.domain.model.nowlocation.SubwayRouteLocationUseCaseItem
@@ -21,7 +22,11 @@ internal class RouteRepositoryImpl @Inject constructor(
 ) : RouteRepository {
 
     override suspend fun getRoute(routeRequest: RouteRequest): List<Itinerary> {
-        return remoteDataSource.getRoute(routeRequest)
+        return try {
+            remoteDataSource.getRoute(routeRequest)
+        } catch (exception: JsonDataException) {
+            listOf()
+        }
     }
 
     override suspend fun reverseGeocoding(
@@ -53,19 +58,23 @@ internal class RouteRepositoryImpl @Inject constructor(
         startSubwayStation: String,
         endSubwayStation: String
     ): SubwayRouteLocationUseCaseItem {
-        return remoteDataSource.getRoute(routeRequest).first {
-            it.legs.any { leg ->
+        return try {
+            remoteDataSource.getRoute(routeRequest).first {
+                it.legs.any { leg ->
+                    leg.mode == "SUBWAY"
+                            && leg.route?.contains(subwayLine) ?: false
+                            && leg.start.name.contains(startSubwayStation)
+                            && leg.end.name.contains(endSubwayStation)
+                }
+            }.legs.first { leg ->
                 leg.mode == "SUBWAY"
                         && leg.route?.contains(subwayLine) ?: false
                         && leg.start.name.contains(startSubwayStation)
                         && leg.end.name.contains(endSubwayStation)
-            }
-        }.legs.first { leg ->
-            leg.mode == "SUBWAY"
-                    && leg.route?.contains(subwayLine) ?: false
-                    && leg.start.name.contains(startSubwayStation)
-                    && leg.end.name.contains(endSubwayStation)
-        }.toUseCaseModel()
+            }.toUseCaseModel()
+        } catch (exception: JsonDataException) {
+            throw IllegalArgumentException("경로 검색 결과가 없습니다.")
+        }
     }
 
     override suspend fun getSeoulBusStationArsId(stationName: String): List<BusStationInfo> {
diff --git a/domain/src/main/java/com/stop/domain/model/route/tmap/origin/RouteResponse.kt b/domain/src/main/java/com/stop/domain/model/route/tmap/origin/RouteResponse.kt
@@ -4,5 +4,5 @@ import com.squareup.moshi.JsonClass
 
 @JsonClass(generateAdapter = true)
 data class RouteResponse(
-    val metaData: MetaData
+    val metaData: MetaData?
 )
diff --git a/domain/src/main/java/com/stop/domain/usecase/route/GetRouteUseCaseImpl.kt b/domain/src/main/java/com/stop/domain/usecase/route/GetRouteUseCaseImpl.kt
@@ -13,6 +13,10 @@ internal class GetRouteUseCaseImpl @Inject constructor(
     override suspend operator fun invoke(routeRequest: RouteRequest): List<Itinerary> {
         val originItineraries = routeRepository.getRoute(routeRequest)
 
+        if (originItineraries.isEmpty()) {
+            return listOf()
+        }
+
         return originItineraries.fold(listOf()) itinerary@{ itineraries, itinerary ->
             val result = itinerary.legs.fold(listOf<Route>()) { routes, leg ->
                 try {
diff --git a/presentation/src/main/java/com/stop/model/ErrorType.kt b/presentation/src/main/java/com/stop/model/ErrorType.kt
@@ -1,5 +1,9 @@
 package com.stop.model
 
-enum class ErrorType {
-    NO_START, NO_END,
+import com.stop.R
+
+enum class ErrorType(val stringResourcesId: Int) {
+    NO_START(R.string.no_start_input),
+    NO_END(R.string.no_end_input),
+    NO_ROUTE_RESULT(R.string.route_result_not_exist)
 }
diff --git a/presentation/src/main/java/com/stop/ui/mission/MissionFragment.kt b/presentation/src/main/java/com/stop/ui/mission/MissionFragment.kt
@@ -7,6 +7,7 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
+import android.widget.Toast
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.lifecycleScope
@@ -131,6 +132,14 @@ class MissionFragment : Fragment(), MissionHandler {
                     })
             }
         }
+
+        viewModel.errorMessage.observe(viewLifecycleOwner) {
+            it.getContentIfNotHandled()?.let { errorType ->
+                val message = getString(errorType.stringResourcesId)
+
+                Toast.makeText(requireContext(), message, Toast.LENGTH_SHORT).show()
+            }
+        }
     }
 
     private fun drawBusLocationLine() {
diff --git a/presentation/src/main/java/com/stop/ui/mission/MissionViewModel.kt b/presentation/src/main/java/com/stop/ui/mission/MissionViewModel.kt
@@ -8,6 +8,8 @@ import com.stop.domain.usecase.nowlocation.GetBusNowLocationUseCase
 import com.stop.domain.usecase.nowlocation.GetNowStationLocationUseCase
 import com.stop.domain.usecase.nowlocation.GetSubwayRouteUseCase
 import com.stop.domain.usecase.nowlocation.GetSubwayTrainNowStationUseCase
+import com.stop.model.ErrorType
+import com.stop.model.Event
 import com.stop.model.Location
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.Dispatchers
@@ -39,6 +41,10 @@ class MissionViewModel @Inject constructor(
     val estimatedTimeRemaining: LiveData<Int>
         get() = _estimatedTimeRemaining
 
+    private val _errorMessage = MutableLiveData<Event<ErrorType>>()
+    val errorMessage: LiveData<Event<ErrorType>>
+        get() = _errorMessage
+
     val leftMinute: LiveData<String> = Transformations.switchMap(estimatedTimeRemaining) {
         MutableLiveData<String>().apply {
             value = (it / TIME_UNIT).toString().padStart(TIME_DIGIT, '0')
@@ -132,17 +138,22 @@ class MissionViewModel @Inject constructor(
     private fun getSubwayRoute() {
         viewModelScope.launch {
             val startLocation = getNowStationLocation()
-            this@MissionViewModel._subwayRoute.value = getSubwayRouteUseCase(
-                RouteRequest(
-                    startLocation.longitude,
-                    startLocation.latitude,
-                    TEST_SUBWAY_LONG,
-                    TEST_SUBWAY_LAT
-                ),
-                TEST_SUBWAY_NUMER.toString() + LINE,
-                startSubwayStation.dropLast(1), //"역" 버리기
-                TEST_END_SUBWAY_STATION
-            )
+            try {
+                this@MissionViewModel._subwayRoute.value = getSubwayRouteUseCase(
+                    RouteRequest(
+                        startLocation.longitude,
+                        startLocation.latitude,
+                        TEST_SUBWAY_LONG,
+                        TEST_SUBWAY_LAT
+                    ),
+                    TEST_SUBWAY_NUMER.toString() + LINE,
+                    startSubwayStation.dropLast(1), //"역" 버리기
+                    TEST_END_SUBWAY_STATION
+                )
+            } catch (exception: IllegalArgumentException) {
+                _errorMessage.value = Event(ErrorType.NO_ROUTE_RESULT)
+                return@launch
+            }
         }
     }
 
diff --git a/presentation/src/main/java/com/stop/ui/route/RouteFragment.kt b/presentation/src/main/java/com/stop/ui/route/RouteFragment.kt
@@ -12,7 +12,6 @@ import androidx.navigation.fragment.navArgs
 import com.stop.R
 import com.stop.databinding.FragmentRouteBinding
 import com.stop.domain.model.route.tmap.custom.Itinerary
-import com.stop.model.ErrorType
 import dagger.hilt.android.AndroidEntryPoint
 
 @AndroidEntryPoint
@@ -85,10 +84,7 @@ class RouteFragment : Fragment() {
 
         viewModel.errorMessage.observe(viewLifecycleOwner) {
             it.getContentIfNotHandled()?.let { errorType ->
-                val message = when (errorType) {
-                    ErrorType.NO_START -> getString(R.string.no_start_input)
-                    ErrorType.NO_END -> getString(R.string.no_end_input)
-                }
+                val message = getString(errorType.stringResourcesId)
 
                 Toast.makeText(requireContext(), message, Toast.LENGTH_SHORT).show()
             }
diff --git a/presentation/src/main/java/com/stop/ui/route/RouteViewModel.kt b/presentation/src/main/java/com/stop/ui/route/RouteViewModel.kt
@@ -62,7 +62,12 @@ class RouteViewModel @Inject constructor(
         )
 
         viewModelScope.launch {
-            this@RouteViewModel._routeResponse.value = getRouteUseCase(routeRequest)
+            val itineraries = getRouteUseCase(routeRequest)
+            if (itineraries.isEmpty()) {
+                _errorMessage.value = Event(ErrorType.NO_ROUTE_RESULT)
+                return@launch
+            }
+            this@RouteViewModel._routeResponse.value = itineraries
         }
     }
 
diff --git a/presentation/src/main/res/values/strings.xml b/presentation/src/main/res/values/strings.xml
@@ -39,4 +39,5 @@
     <string name="km">km</string>
     <string name="no_alarm">현재 등록된 막차 알림이 없습니다.</string>
     <string name="section_time">%1$s분</string>
+    <string name="route_result_not_exist">경로 검색 결과가 존재하지 않습니다.</string>
 </resources>

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ import com.squareup.moshi.JsonClass`
`4`	`4`
`5`	`5`	`@JsonClass(generateAdapter = true)`
`6`	`6`	`data class RouteResponse(`
`7`		`- val metaData: MetaData`
	`7`	`+ val metaData: MetaData?`
`8`	`8`	`)`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,12 @@ class RouteViewModel @Inject constructor(`
`62`	`62`	`)`
`63`	`63`
`64`	`64`	`viewModelScope.launch {`
`65`		`- this@RouteViewModel._routeResponse.value = getRouteUseCase(routeRequest)`
	`65`	`+ val itineraries = getRouteUseCase(routeRequest)`
	`66`	`+ if (itineraries.isEmpty()) {`
	`67`	`+ _errorMessage.value = Event(ErrorType.NO_ROUTE_RESULT)`
	`68`	`+ return@launch`
	`69`	`+ }`
	`70`	`+ this@RouteViewModel._routeResponse.value = itineraries`
`66`	`71`	`}`
`67`	`72`	`}`
`68`	`73`