Skip to content

Commit 1534f52

Browse files
committed
fix: 웹소켓에 path 추가
배포 서버에서 ws 경로로 웹소켓 request 하도록 바꿈
1 parent 0807700 commit 1534f52

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

client/src/config/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ export default {
22
GITHUB_CLIENT_ID: import.meta.env.VITE_GITHUB_CLIENT_ID,
33
GITHUB_CLIENT_SECRET: import.meta.env.VITE_GITHUB_CLIENT_SECRET,
44
SERVER_PATH: import.meta.env.VITE_SERVER_PATH,
5+
SERVER_URL: import.meta.env.VITE_SERVER_URL,
56
};

client/src/hooks/useSocket.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,8 @@ import { io } from 'socket.io-client';
22
import env from 'src/config';
33

44
export default function useSocket(namespace: string) {
5-
return io(`${env.SERVER_PATH}${namespace}`);
5+
// TODO: http://example.com/ 까지만 나타내는 환경변수로 SERVER_URL 사용.
6+
// SERVER_PATH 환경변수(http://example.com/api)와 겹치는 부분이 있으므로 리팩토링 필요
7+
// TODO: '/ws' 부분을 환경변수로 관리하기. 위 리팩토링 진행시 같이 진행 필요
8+
return io(`${env.SERVER_URL}${namespace}`, { path: '/ws' });
69
}

server/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,12 @@ const io = new Server({
2929
cors: {
3030
origin: env.CLIENT_PATH,
3131
},
32+
path: '/ws', // TODO: '/ws' 환경 변수로 분리 필요
3233
});
3334

3435
momSocketServer(io);
3536
signalingSocketServer(io);
3637

3738
io.attach(server);
3839

39-
server.listen(8080);
40+
server.listen(8080); // TODO: 서버 포트 환경 변수로 분리 필요

server/socket/mom.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ async function momSocketServer(io: Server) {
99

1010
const crdt = new CRDT(1, -1, structure);
1111

12-
const workspace = io.of(/^\/api\/sc-workspace\/\d+$/);
12+
const workspace = io.of(/^\/sc-workspace\/\d+$/);
1313

1414
workspace.on('connection', async (socket) => {
1515
const name = socket.nsp.name;

server/socket/signaling.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Server } from 'socket.io';
22

33
function signalingSocketServer(io: Server) {
4-
const signaling = io.of(/^\/api\/signaling\/\d+$/);
4+
const signaling = io.of(/^\/signaling\/\d+$/);
55

66
signaling.on('connection', (socket) => {
77
socket.on('send_hello', () => {

0 commit comments

Comments
 (0)