refactor: endVote와 getVoteResult 불필요한 DB 접근 제거

Author: se030

server/apis/mom/block/model.ts

@@ -5,7 +5,7 @@ import { BlockType } from '@wabinar/api-types/block';
 import { Vote } from './vote/service';
 import { Question } from './question/service';
 
-interface Block {
+export interface Block {
   id: string;
   type: BlockType;
   head: Object;

server/apis/mom/block/service.ts

@@ -59,6 +59,16 @@ const putVoteBlock = async (id: string, vote: Vote) => {
   await blockModel.updateOne({ id }, { voteProperties: vote });
 };
 
+export const putVoteBlockStatus = async (id: string, isDoing: boolean) => {
+  const block = await blockModel.findOneAndUpdate(
+    { id },
+    { $set: { 'voteProperties.isDoing': isDoing } },
+    { new: true },
+  );
+
+  return block;
+};
+
 const putQuestionBlock = async (id: string, questions: Question[]) => {
   await blockModel.updateOne({ id }, { questionProperties: questions });
 };

server/apis/mom/block/vote/service.ts

@@ -1,6 +1,6 @@
 import { BlockType } from '@wabinar/api-types/block';
-import { getBlock, putBlock } from '../service';
-
+import { Block } from '../model';
+import { getBlock, putBlock, putVoteBlockStatus } from '../service';
 export interface Option {
   id: number;
   text: string;
@@ -70,18 +70,12 @@ export const updateVote = async (
 };
 
 export const endVote = async (blockId: string) => {
-  const voteBlock = await getBlock(blockId);
-
-  const { voteProperties: vote } = voteBlock;
-
-  vote.isDoing = false;
-
-  await putBlock(blockId, BlockType.VOTE, vote);
-
-  return vote;
+  return await putVoteBlockStatus(blockId, false);
 };
 
-export const getVoteResult = (vote: Vote) => {
+export const getVoteResult = async (block: Block) => {
+  const { voteProperties: vote } = block;
+
   const participantCount = Object.keys(vote.participants).length;
 
   const options = Object.entries(vote.options).map(([id, rest]) => ({

server/socket/Mom/handleVoteBlock.ts

@@ -34,12 +34,10 @@ export default function handleVoteBlock(
   socket.on(BLOCK_EVENT.END_VOTE, async (blockId) => {
     const momId = socket.data.momId;
 
-    const vote = await endVote(blockId);
+    const block = await endVote(blockId);
 
-    const voteResult = getVoteResult(vote);
+    const res = await getVoteResult(block);
 
-    io.of(namespace)
-      .to(momId)
-      .emit(`${BLOCK_EVENT.END_VOTE}-${blockId}`, voteResult);
+    io.of(namespace).to(momId).emit(`${BLOCK_EVENT.END_VOTE}-${blockId}`, res);
   });
 }