Merge pull request #33 from boostcampwm-2022/test/#33-C

test: 로그인 서비스 로직

Author: wcho21

server/.eslintrc

@@ -17,6 +17,7 @@
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/ban-types": "off",
+    "@typescript-eslint/no-var-requires": "off",
     "no-nested-ternary": "error",
     "eqeqeq": "error",
     "no-console": "warn"

server/apis/auth/service.github.ts

@@ -0,0 +1,46 @@
+import axios from 'axios';
+import env from '@config';
+import AuthorizationError from '@errors/authorization-error';
+
+const ACCESS_TOKEN_REQUEST_URL = 'https://github.com/login/oauth/access_token';
+const USER_REQUEST_URL = 'https://api.github.com/user';
+
+export const getAccessToken = async (code: string) => {
+  const body = {
+    client_id: env.GITHUB_CLIENT_ID,
+    client_secret: env.GITHUB_CLIENT_SECRET,
+    code,
+  };
+  const headers = {
+    'Content-Type': 'application/json',
+    Accept: 'application/json',
+  };
+
+  const { data: accessTokenResponse } = await axios.post(
+    ACCESS_TOKEN_REQUEST_URL,
+    body,
+    {
+      headers,
+    },
+  );
+
+  if (accessTokenResponse.error) {
+    throw new Error('access token 생성 요청 실패');
+  }
+
+  return accessTokenResponse;
+};
+
+export const getGithubUser = async (accessToken: string, tokenType: string) => {
+  const { data: user } = await axios.get(USER_REQUEST_URL, {
+    headers: {
+      Authorization: `${tokenType} ${accessToken}`,
+    },
+  });
+
+  if (user.error) {
+    throw new AuthorizationError('OAuth 유저 정보 요청 실패');
+  }
+
+  return user;
+};

server/apis/auth/service.test.ts

@@ -0,0 +1,67 @@
+const { login } = require('./service');
+const { getAccessToken, getGithubUser } = require('./service.github');
+const userModel = require('@apis/user/model');
+const jwt = require('@utils/jwt');
+
+jest.mock('./service.github', () => {
+  return {
+    getAccessToken: jest.fn(),
+    getGithubUser: jest.fn(),
+  };
+});
+
+jest.mock('@apis/user/model', () => {
+  return {
+    exists: jest.fn(),
+    create: jest.fn().mockImplementation(() => undefined),
+  };
+});
+
+jest.mock('@utils/jwt', () => {
+  return {
+    generateAccessToken: jest.fn(),
+    generateRefreshToken: jest.fn(),
+  };
+});
+
+describe('login', () => {
+  const successfulTokenResponse = {
+    access_token: '',
+    token_type: '',
+  };
+  const successfulUserResponse = {
+    id: '',
+    login: '',
+    avatar_url: '',
+  };
+
+  const ACCESS_TOKEN = 'ACCESS_TOKEN';
+  const REFRESH_TOKEN = 'REFRESH_TOKEN';
+
+  jwt.generateAccessToken.mockReturnValue(ACCESS_TOKEN);
+  jwt.generateRefreshToken.mockReturnValue(REFRESH_TOKEN);
+
+  it('유효한 코드를 받으면 토큰이 성공적으로 생성된다.', async () => {
+    getAccessToken.mockResolvedValueOnce(successfulTokenResponse);
+    getGithubUser.mockResolvedValueOnce(successfulUserResponse);
+    userModel.exists.mockReturnValue(false);
+
+    const { loginToken, refreshToken } = await login('');
+
+    expect(loginToken).toBe(ACCESS_TOKEN);
+    expect(refreshToken).toBe(REFRESH_TOKEN);
+  });
+
+  it('엑세스 토큰 획득 실패 시 에러를 던진다.', async () => {
+    getAccessToken.mockRejectedValueOnce(new Error('fail'));
+
+    expect(() => login()).rejects.toThrow('fail');
+  });
+
+  it('유저 정보 획득 실패 시 에러를 던진다.', async () => {
+    getAccessToken.mockResolvedValueOnce(successfulTokenResponse);
+    getGithubUser.mockRejectedValueOnce(new Error('fail'));
+
+    expect(() => login()).rejects.toThrow('fail');
+  });
+});

server/apis/auth/service.ts

@@ -1,57 +1,12 @@
-import axios from 'axios';
-import env from '@config';
 import userModel from '@apis/user/model';
 import * as jwt from '@utils/jwt';
-import AuthorizationError from '@errors/authorization-error';
+import { getAccessToken, getGithubUser } from './service.github';
 
 interface TokenResponse {
   access_token: string;
   token_type: string;
 }
 
-const ACCESS_TOKEN_REQUEST_URL = 'https://github.com/login/oauth/access_token';
-const USER_REQUEST_URL = 'https://api.github.com/user';
-
-const getAccessToken = async (code: string) => {
-  const body = {
-    client_id: env.GITHUB_CLIENT_ID,
-    client_secret: env.GITHUB_CLIENT_SECRET,
-    code,
-  };
-  const headers = {
-    'Content-Type': 'application/json',
-    Accept: 'application/json',
-  };
-
-  const { data: accessTokenResponse } = await axios.post(
-    ACCESS_TOKEN_REQUEST_URL,
-    body,
-    {
-      headers,
-    },
-  );
-
-  if (accessTokenResponse.error) {
-    throw new AuthorizationError('access token 생성 요청 실패');
-  }
-
-  return accessTokenResponse;
-};
-
-const getGithubUser = async (accessToken: string, tokenType: string) => {
-  const { data: user } = await axios.get(USER_REQUEST_URL, {
-    headers: {
-      Authorization: `${tokenType} ${accessToken}`,
-    },
-  });
-
-  if (user.error) {
-    throw new AuthorizationError('OAuth 유저 정보 요청 실패');
-  }
-
-  return user;
-};
-
 export const login = async (code: string) => {
   const { access_token: accessToken, token_type: tokenType }: TokenResponse =
     await getAccessToken(code);