refactor: 중복 참여 확인 로직 개선

중복 참여 여부를 db 접근을 통해 확인하던 방식에서 addToSet 연산 결과로 확인하도록 변경

Author: se030

server/apis/workspace/service.test.ts

@@ -1,4 +1,3 @@
-const userModel = require('@apis/user/model');
 const workspaceModel = require('./model');
 const workspaceService = require('./service');
 const { default: InvalidJoinError } = require('@errors/invalid-join-error');
@@ -69,7 +68,8 @@ describe('join', () => {
       users: [],
       moms: [],
     });
-    userModel.find.mockResolvedValueOnce([{ workspaces: [] }]);
+
+    workspaceModel.updateOne.mockResolvedValueOnce({ modifiedCount: 1 });
 
     expect(workspaceService.join(USER_ID, VALID_CODE)).resolves.toEqual({
       id: WORKSPACE_ID,
@@ -100,7 +100,8 @@ describe('join', () => {
       users: [],
       moms: [],
     });
-    userModel.find.mockResolvedValueOnce([{ workspaces: [WORKSPACE_ID] }]);
+
+    workspaceModel.updateOne.mockResolvedValueOnce({ modifiedCount: 0 });
 
     expect(() => workspaceService.join(USER_ID, VALID_CODE)).rejects.toThrow(
       InvalidJoinError,

server/apis/workspace/service.ts

@@ -27,15 +27,15 @@ export const join = async (userId: number, code: string) => {
 
   const { id, name } = workspace;
 
-  const userWorkspaces = (
-    await userModel.find({ id: userId }, { workspaces: 1, _id: 0 })
-  )[0].workspaces;
+  const res = await workspaceModel.updateOne(
+    { id },
+    { $addToSet: { users: userId } },
+  );
 
-  if (userWorkspaces.includes(id)) {
+  if (!res.modifiedCount) {
     throw new InvalidJoinError('이미 참여한 워크스페이스에요 ^^');
   }
 
-  await workspaceModel.updateOne({ id }, { $addToSet: { users: userId } });
   await userModel.updateOne({ id: userId }, { $addToSet: { workspaces: id } });
 
   return { id, name, code };