refactor: api 서비스 테스트 코드 리팩토링

Co-authored-by: Won-hee Cho <[email protected]>
Co-authored-by: 백도훈 <[email protected]>
Co-authored-by: Ruby <[email protected]>

Author: 4 people

server/apis/auth/service.test.ts

@@ -65,3 +65,5 @@ describe('login', () => {
     expect(() => login()).rejects.toThrow('fail');
   });
 });
+
+export {};

server/apis/user/service.test.ts

@@ -11,28 +11,23 @@ jest.mock('@apis/workspace/model', () => {
   return { find: jest.fn() };
 });
 
-describe('getWorkspaces()', () => {
+describe('getWorkspaces', () => {
   const successfulUser = '';
   const successfulWorkspaces: Object[] = [];
 
   it('정상적인 유저 아이디를 받아서 성공적으로 워크스페이스를 가져온다.', async () => {
-    // arrange
     userModel.findOne.mockResolvedValueOnce(successfulUser);
     workspaceModel.find.mockResolvedValueOnce(successfulWorkspaces);
 
-    // act
     const workspaces = await getWorkspaces('id', 'id');
 
-    // assert
     expect(workspaces).toEqual(successfulWorkspaces);
   });
 
   it('비정상적인 유저 아이디를 받으면 에러를 던진다.', async () => {
-    // arrange
     const user1 = 1;
     const user2 = 2;
 
-    // act & assert
     expect(() => getWorkspaces(user1, user2)).rejects.toThrow(
       AuthorizationError,
     );

server/apis/workspace/service.test.js renamed to server/apis/workspace/service.test.ts

@@ -1,19 +1,20 @@
+const workspaceModel = require('./model');
+const workspaceService = require('./service');
+const { default: InvalidJoinError } = require('@errors/invalid-join-error');
+
 jest.mock('./model', () => {
   return {
-    repository: {},
     create: jest.fn(),
     findOne: jest.fn(),
     updateOne: jest.fn(),
   };
 });
-const workspaceModel = require('./model');
 
 jest.mock('@apis/user/model', () => {
   return {
     updateOne: jest.fn(),
   };
 });
-const userModel = require('@apis/user/model');
 
 const VALID_CODE = 'wab-0000-0000-0000';
 
@@ -23,8 +24,6 @@ jest.mock('uuid', () => {
   };
 });
 
-const workspaceService = require('./service');
-
 describe('create', () => {
   it('워크스페이스 이름이 주어진 경우 생성에 성공한다.', async () => {
     const WORKSPACE_NAME = 'Wab';
@@ -71,7 +70,7 @@ describe('join', () => {
 
   it('참여코드가 없는 경우 실패한다.', async () => {
     expect(() => workspaceService.join(USER_ID)).rejects.toThrow(
-      '참여코드를 입력하세요 ^^',
+      InvalidJoinError,
     );
   });
 
@@ -80,7 +79,7 @@ describe('join', () => {
 
     expect(() =>
       workspaceService.join(USER_ID, 'invalid-code'),
-    ).rejects.toThrow('잘못된 참여코드에요 ^^');
+    ).rejects.toThrow(InvalidJoinError);
   });
 
   it('db 업데이트 중 에러가 발생하면 실패한다.', async () => {
@@ -91,3 +90,5 @@ describe('join', () => {
     expect(() => workspaceService.join(USER_ID, VALID_CODE)).rejects.toThrow();
   });
 });
+
+export {};

server/errors/invalid-join-error.ts

@@ -1,8 +1,10 @@
 import CustomError from '.';
 import { BAD_REQUEST } from '@constants/http-status';
 
-export default class InvalidJoinError extends CustomError {
+class InvalidJoinError extends CustomError {
   constructor(message = 'Unauthorized') {
     super(message, BAD_REQUEST);
   }
 }
+
+export default InvalidJoinError;