Skip to content

Commit b1cc49f

Browse files
authored
Refactor/#393-C: 소켓 이벤트 문자열 contants로 관리 (#394)
* refactor: 사용하지 않는 코드 삭제 (#390) * refactor: 소켓 메시지 문자열 constants로 관리
1 parent 754d4ca commit b1cc49f

File tree

4 files changed

+13
-10
lines changed

4 files changed

+13
-10
lines changed

@wabinar/constants/socket-message.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ export const WORKSPACE_EVENT = {
99
RECEIVE_ANSWER: 'receive-answer',
1010
SEND_ICE: 'send-ice',
1111
RECEIVE_ICE: 'receive-ice',
12-
RECEIVE_BYE: 'receive_bye',
12+
AUDIO_STATE_CHANGED: 'audio-state-changed',
13+
VIDEO_STATE_CHANGED: 'video-state-changed',
14+
SEND_BYE: 'send-bye',
15+
RECEIVE_BYE: 'receive-bye',
1316
};
1417

1518
export const MOM_EVENT = {

client/src/components/Sidebar/MeetingButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function MeetingButton() {
1414

1515
const onClick = () => {
1616
if (isOnGoing) {
17-
socket.emit('bye');
17+
socket.emit(WORKSPACE_EVENT.SEND_BYE);
1818
}
1919
setIsOnGoing(!isOnGoing);
2020
};

client/src/hooks/useMeetingMediaStreams.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { WORKSPACE_EVENT } from '@wabinar/constants/socket-message';
12
import { useEffect, useState } from 'react';
23
import { Socket, io } from 'socket.io-client';
34
import { STUN_SERVER } from 'src/constants/rtc';
@@ -68,15 +69,15 @@ export function useMeetingMediaStreams(
6869
return;
6970
}
7071
setTrack(localStream, 'audio', audioOn);
71-
socket.emit('audio_state_changed', audioOn);
72+
socket.emit(WORKSPACE_EVENT.AUDIO_STATE_CHANGED, audioOn);
7273
};
7374

7475
const setLocalVideo: SetLocalVideo = async (videoOn) => {
7576
if (!localStream) {
7677
return;
7778
}
7879
setTrack(localStream, 'video', videoOn);
79-
socket.emit('video_state_changed', videoOn);
80+
socket.emit(WORKSPACE_EVENT.VIDEO_STATE_CHANGED, videoOn);
8081
};
8182

8283
socket.on('audio_state_changed', (socketId, audioOn) => {

server/socket/workspace.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,15 @@ function workspaceSocketServer(io: Server) {
3535
socket.to(receiverId).emit(WORKSPACE_EVENT.RECEIVE_ICE, ice, senderId);
3636
});
3737

38-
// TODO: 소켓 이벤트 메시지 상수화
39-
socket.on('audio_state_changed', (audioOn) => {
40-
namespace.emit('audio_state_changed', socket.id, audioOn);
38+
socket.on(WORKSPACE_EVENT.AUDIO_STATE_CHANGED, (audioOn) => {
39+
namespace.emit(WORKSPACE_EVENT.AUDIO_STATE_CHANGED, socket.id, audioOn);
4140
});
4241

43-
socket.on('video_state_changed', (videoOn) => {
44-
namespace.emit('video_state_changed', socket.id, videoOn);
42+
socket.on(WORKSPACE_EVENT.VIDEO_STATE_CHANGED, (videoOn) => {
43+
namespace.emit(WORKSPACE_EVENT.VIDEO_STATE_CHANGED, socket.id, videoOn);
4544
});
4645

47-
socket.on('bye', () => {
46+
socket.on(WORKSPACE_EVENT.SEND_BYE, () => {
4847
const senderId = socket.id;
4948
socket.broadcast.emit(WORKSPACE_EVENT.RECEIVE_BYE, senderId);
5049
});

0 commit comments

Comments
 (0)