Skip to content

Commit d4e9372

Browse files
committed
refactor: 투표 생성 이벤트명 REGISTER_VOTE로 수정
- 기획 상으로는 투표가 등록되었을 때 투표 블럭이 생성 - 해당 방식으로는 다른 클라이언트가 또 다시 타입을 수정할 여지가 있어 블럭 타입 관리에 어려움이 생김 - 블럭 타입은 선택 시점에 변경되도록 하되, 등록 전에는 투표가 시작되지 않았음을 UI로 보여지도록 수정
1 parent 8b944a0 commit d4e9372

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

@wabinar/constants/socket-message.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const BLOCK_EVENT = {
2929
INSERT_TEXT: 'insert-text',
3030
DELETE_TEXT: 'delete-text',
3131
UPDATE_TEXT: 'update-text',
32-
CREATE_VOTE: 'create-vote',
32+
REGISTER_VOTE: 'register-vote',
3333
UPDATE_VOTE: 'update-vote',
3434
END_VOTE: 'end-vote',
3535
FETCH_QUESTIONS: 'fetch-questions',

client/src/components/Block/VoteBlock/VoteBlockTemplate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ function VoteBlockTemplate({
6767
setOptions(validOptions);
6868
setVoteMode(VoteMode.REGISTERED);
6969

70-
socket.emit(BLOCK_EVENT.CREATE_VOTE, id, validOptions);
70+
socket.emit(BLOCK_EVENT.REGISTER_VOTE, id, validOptions);
7171

7272
toast('투표 등록 완료 ^^', { type: 'info' });
7373
};

client/src/components/Block/VoteBlock/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function VoteBlock({ id }: VoteBlockProps) {
1818
const [options, setOptions] = useState<Option[]>(initialOption);
1919

2020
useEffect(() => {
21-
socket.on(`${BLOCK_EVENT.CREATE_VOTE}-${id}`, (options) => {
21+
socket.on(`${BLOCK_EVENT.REGISTER_VOTE}-${id}`, (options) => {
2222
setVoteMode(VoteMode.REGISTERED as VoteMode);
2323
setOptions(options);
2424
});

server/socket/Mom/handleVoteBlock.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ export default function handleVoteBlock(
1212
namespace: string,
1313
socket: Socket,
1414
) {
15-
socket.on(BLOCK_EVENT.CREATE_VOTE, async (blockId, options: Option[]) => {
15+
socket.on(BLOCK_EVENT.REGISTER_VOTE, async (blockId, options: Option[]) => {
1616
const momId = socket.data.momId;
1717

1818
await createVote(blockId, options);
1919

20-
socket.to(momId).emit(`${BLOCK_EVENT.CREATE_VOTE}-${blockId}`, options);
20+
socket.to(momId).emit(`${BLOCK_EVENT.REGISTER_VOTE}-${blockId}`, options);
2121
});
2222

2323
socket.on(BLOCK_EVENT.UPDATE_VOTE, async (blockId, optionId, userId) => {

0 commit comments

Comments
 (0)