♻️ refactor: 파일 추가 API Response DTO 사용, ApiResponse 사용하도록 변경

Author: Jo-Minseok

server/src/file/controller/file.controller.ts

@@ -11,50 +11,41 @@ import {
 } from '@nestjs/common';
 import { FileInterceptor } from '@nestjs/platform-express';
 import { FileService } from '../service/file.service';
-
 import { ApiTags } from '@nestjs/swagger';
 import { JwtGuard } from '../../common/guard/jwt.guard';
 import { createDynamicStorage } from '../../common/disk/diskStorage';
 import { ApiResponse } from '../../common/response/common.response';
 import { ApiUploadProfileFile } from '../api-docs/uploadProfileFile.api-docs';
 import { ApiDeleteFile } from '../api-docs/deleteFile.api-docs';
-import { FileUploadResponseDto } from '../dto/createFile.dto';
+import { FileDeleteRequestDto } from '../dto/request/deleteFile.dto';
 
 @ApiTags('File')
 @Controller('file')
 @UseGuards(JwtGuard)
 export class FileController {
   constructor(private readonly fileService: FileService) {}
 
-  @Post('upload/profile')
+  @Post('profile')
   @ApiUploadProfileFile()
   @UseInterceptors(FileInterceptor('file', createDynamicStorage()))
   async upload(@UploadedFile() file: any, @Req() req) {
     if (!file) {
       throw new BadRequestException('파일이 선택되지 않았습니다.');
     }
 
-    const responseDto = await this.fileService.create(
-      file,
-      Number.parseInt(req.user.id),
-    );
-
     return ApiResponse.responseWithData(
       '파일 업로드에 성공했습니다.',
-      responseDto,
+      await this.fileService.create(file, Number.parseInt(req.user.id)),
     );
   }
 
   // TODO: 권한검사 추가
   @Delete(':id')
   @ApiDeleteFile()
-  async deleteFile(@Param('id') id: string, @Req() req) {
-    const fileId = parseInt(id, 10);
-    if (isNaN(fileId)) {
-      throw new BadRequestException('유효하지 않은 파일 ID입니다.');
-    }
-
-    await this.fileService.deleteFile(fileId);
-    return { message: '파일이 성공적으로 삭제되었습니다.' };
+  async deleteFile(@Param() fileDeleteRequestDto: FileDeleteRequestDto) {
+    await this.fileService.deleteFile(fileDeleteRequestDto.id);
+    return ApiResponse.responseWithNoContent(
+      '파일이 성공적으로 삭제되었습니다.',
+    );
   }
 }

server/src/file/service/file.service.ts

@@ -3,7 +3,7 @@ import { File } from '../entity/file.entity';
 import { unlinkSync, existsSync } from 'fs';
 import { FileRepository } from '../repository/file.repository';
 import { User } from '../../user/entity/user.entity';
-import { FileUploadResponseDto } from '../dto/createFile.dto';
+import { FileUploadResponseDto } from '../dto/response/createFile.dto';
 
 @Injectable()
 export class FileService {
@@ -21,15 +21,7 @@ export class FileService {
     } as File);
     const accessUrl = this.generateAccessUrl(path);
 
-    return {
-      id: savedFile.id,
-      originalName: savedFile.originalName,
-      mimetype: savedFile.mimetype,
-      size: savedFile.size,
-      url: accessUrl,
-      userId: userId,
-      createdAt: savedFile.createdAt,
-    };
+    return FileUploadResponseDto.toResponseDto(savedFile, accessUrl);
   }
 
   private generateAccessUrl(filePath: string): string {