Skip to content

Commit a2625ba

Browse files
authored
Merge pull request #486 from boostcampwm-2024/refactor/fix-rabbitmq-env
♻️ refactor: rabbitmq env 관련 변수명 수정
2 parents a048b7b + 03ca28e commit a2625ba

File tree

8 files changed

+19
-22
lines changed

8 files changed

+19
-22
lines changed

.github/workflows/deploy_feed-crawler.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ jobs:
8181
echo "REDIS_PASSWORD=${{ secrets.REDIS_PASSWORD }}"
8282
echo "AI_API_KEY=${{ secrets.AI_API_KEY }}"
8383
echo "AI_RATE_LIMIT_COUNT=${{ vars.AI_RATE_LIMIT_COUNT }}"
84-
echo "RABBITMQ_USERNAME=${{ secrets.PRODUCT_RABBITMQ_USERNAME }}"
85-
echo "RABBITMQ_PASSWORD=${{ secrets.PRODUCT_RABBITMQ_PASSWORD }}"
84+
echo "RABBITMQ_DEFAULT_USER=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_USER }}"
85+
echo "RABBITMQ_DEFAULT_PASS=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_PASS }}"
8686
echo "RABBITMQ_HOST=${{ secrets.PRODUCT_RABBITMQ_HOST }}"
8787
echo "RABBITMQ_PORT=${{ secrets.PRODUCT_RABBITMQ_PORT }}"
8888
} | sudo tee "$ENV_FILE" >/dev/null
@@ -97,8 +97,8 @@ jobs:
9797
echo "MYSQL_DATABASE=${{ secrets.PRODUCT_DB_DATABASE }}"
9898
echo "MYSQL_USER=${{ secrets.PRODUCT_DB_USERNAME }}"
9999
echo "MYSQL_PASSWORD=${{ secrets.PRODUCT_DB_PASSWORD }}"
100-
echo "RABBITMQ_USERNAME=${{ secrets.PRODUCT_RABBITMQ_USERNAME }}"
101-
echo "RABBITMQ_PASSWORD=${{ secrets.PRODUCT_RABBITMQ_PASSWORD }}"
100+
echo "RABBITMQ_DEFAULT_USER=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_USER }}"
101+
echo "RABBITMQ_DEFAULT_PASS=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_PASS }}"
102102
echo "RABBITMQ_HOST=${{ secrets.PRODUCT_RABBITMQ_HOST }}"
103103
echo "RABBITMQ_PORT=${{ secrets.PRODUCT_RABBITMQ_PORT }}"
104104
echo "RABBITMQ_MANAGEMENT_PORT=${{ secrets.PRODUCT_RABBITMQ_MANAGEMENT_PORT }}"

.github/workflows/deploy_infra.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ jobs:
2929
echo "MYSQL_DATABASE=${{ secrets.PRODUCT_DB_DATABASE }}"
3030
echo "MYSQL_USER=${{ secrets.PRODUCT_DB_USERNAME }}"
3131
echo "MYSQL_PASSWORD=${{ secrets.PRODUCT_DB_PASSWORD }}"
32-
echo "RABBITMQ_USERNAME=${{ secrets.PRODUCT_RABBITMQ_USERNAME }}"
33-
echo "RABBITMQ_PASSWORD=${{ secrets.PRODUCT_RABBITMQ_PASSWORD }}"
32+
echo "RABBITMQ_DEFAULT_USER=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_USER }}"
33+
echo "RABBITMQ_DEFAULT_PASS=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_PASS }}"
3434
echo "RABBITMQ_HOST=${{ secrets.PRODUCT_RABBITMQ_HOST }}"
3535
echo "RABBITMQ_PORT=${{ secrets.PRODUCT_RABBITMQ_PORT }}"
36-
echo "RABBITMQ_MANAGEMENT_PORT=${{ secrets.PRODUCT_RABBITMQ_MANAGEMENT_PORT }}"
36+
echo "RABBITMQ_MANAGEMENT_PORT=${{ secrets.PRODUCT_RABBITMQ_MANAGEMENT_PORT }}"
3737
} | sudo tee /var/prod_config/infra/.env.prod >/dev/null
3838
3939
sudo chmod +x docker-compose/redis-init.sh

.github/workflows/deploy_server.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ jobs:
9090
echo "GOOGLE_CLIENT_SECRET=${{ secrets.GOOGLE_CLIENT_SECRET }}"
9191
echo "GITHUB_CLIENT_ID=${{ secrets.GIT_CLIENT_ID }}"
9292
echo "GITHUB_CLIENT_SECRET=${{ secrets.GIT_CLIENT_SECRET }}"
93-
echo "RABBITMQ_USERNAME=${{ secrets.PRODUCT_RABBITMQ_USERNAME }}"
94-
echo "RABBITMQ_PASSWORD=${{ secrets.PRODUCT_RABBITMQ_PASSWORD }}"
93+
echo "RABBITMQ_DEFAULT_USER=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_USER }}"
94+
echo "RABBITMQ_DEFAULT_PASS=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_PASS }}"
9595
echo "RABBITMQ_HOST=${{ secrets.PRODUCT_RABBITMQ_HOST }}"
9696
echo "RABBITMQ_PORT=${{ secrets.PRODUCT_RABBITMQ_PORT }}"
9797
} | sudo tee "$ENV_FILE" >/dev/null
@@ -106,8 +106,8 @@ jobs:
106106
echo "MYSQL_DATABASE=${{ secrets.PRODUCT_DB_DATABASE }}"
107107
echo "MYSQL_USER=${{ secrets.PRODUCT_DB_USERNAME }}"
108108
echo "MYSQL_PASSWORD=${{ secrets.PRODUCT_DB_PASSWORD }}"
109-
echo "RABBITMQ_USERNAME=${{ secrets.PRODUCT_RABBITMQ_USERNAME }}"
110-
echo "RABBITMQ_PASSWORD=${{ secrets.PRODUCT_RABBITMQ_PASSWORD }}"
109+
echo "RABBITMQ_DEFAULT_USER=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_USER }}"
110+
echo "RABBITMQ_DEFAULT_PASS=${{ secrets.PRODUCT_RABBITMQ_DEFAULT_PASS }}"
111111
echo "RABBITMQ_HOST=${{ secrets.PRODUCT_RABBITMQ_HOST }}"
112112
echo "RABBITMQ_PORT=${{ secrets.PRODUCT_RABBITMQ_PORT }}"
113113
echo "RABBITMQ_MANAGEMENT_PORT=${{ secrets.PRODUCT_RABBITMQ_MANAGEMENT_PORT }}"

docker-compose/docker-compose.prod.infra.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ services:
8585
- "15672:15672"
8686
env_file:
8787
- /var/prod_config/infra/.env.prod
88-
environment:
89-
RABBITMQ_DEFAULT_USER: ${RABBITMQ_USERNAME}
90-
RABBITMQ_DEFAULT_PASS: ${RABBITMQ_PASSWORD}
9188
volumes:
9289
- denamu-rabbitmq:/var/lib/rabbitmq
9390
healthcheck:

feed-crawler/env/.env.local

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ REDIS_USERNAME=denamu-redis-user
1010
REDIS_PASSWORD=denamu-redis-pw
1111
AI_API_KEY=?
1212
AI_RATE_LIMIT_COUNT=5
13-
RABBITMQ_USERNAME=denamu-rabbitmq-user
14-
RABBITMQ_PASSWORD=denamu-rabbitmq-password
13+
RABBITMQ_DEFAULT_USER=denamu-rabbitmq-user
14+
RABBITMQ_DEFAULT_PASS=denamu-rabbitmq-password
1515
RABBITMQ_HOST=rabbitmq
1616
RABBITMQ_PORT=5672

feed-crawler/src/common/rmq-access.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ export class RabbitMQConnection {
1818
protocol: 'amqp',
1919
hostname: process.env.RABBITMQ_HOST,
2020
port: Number.parseInt(process.env.RABBITMQ_PORT),
21-
username: process.env.RABBITMQ_USERNAME,
22-
password: process.env.RABBITMQ_PASSWORD,
21+
username: process.env.RABBITMQ_DEFAULT_USER,
22+
password: process.env.RABBITMQ_DEFAULT_PASS,
2323
});
2424
}
2525
}

server/env/.env.local

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ REFRESH_TOKEN_EXPIRE=7d
1717
ACCESS_TOKEN_EXPIRE=1h
1818
GOOGLE_CLIENT_ID=?
1919
GOOGLE_CLIENT_SECRET=?
20-
RABBITMQ_USERNAME=denamu-rabbitmq-user
21-
RABBITMQ_PASSWORD=denamu-rabbitmq-password
20+
RABBITMQ_DEFAULT_USER=denamu-rabbitmq-user
21+
RABBITMQ_DEFAULT_PASS=denamu-rabbitmq-password
2222
RABBITMQ_HOST=rabbitmq
2323
RABBITMQ_PORT=5672

server/src/common/rabbitmq/rabbitmq.module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import { RabbitMQService } from './rabbitmq.service';
1515
protocol: 'amqp',
1616
hostname: configService.get<string>('RABBITMQ_HOST'),
1717
port: configService.get<number>('RABBITMQ_PORT'),
18-
username: configService.get<string>('RABBITMQ_USERNAME'),
19-
password: configService.get<string>('RABBITMQ_PASSWORD'),
18+
username: configService.get<string>('RABBITMQ_DEFAULT_USER'),
19+
password: configService.get<string>('RABBITMQ_DEFAULT_PASS'),
2020
});
2121
},
2222
},

0 commit comments

Comments
 (0)