♻️ refactor: file 업로드 테스트 하기 편한 구조로 변경 및 버그 수정

Author: Jo-Minseok

server/src/common/disk/diskStorage.ts

@@ -0,0 +1,10 @@
+export enum FileUploadType {
+  PROFILE_IMAGE = 'PROFILE_IMAGE',
+  // 추후 추가될 타입들 명시
+}
+
+export const FILE_SIZE_LIMITS = {
+  // MB 단위
+  IMAGE: 5 * 1024 * 1024,
+  DEFAULT: 10 * 1024 * 1024,
+};

server/src/common/disk/file-type.ts

@@ -8,7 +8,7 @@ import {
   ApiQuery,
   ApiUnauthorizedResponse,
 } from '@nestjs/swagger';
-import { FileUploadType } from '../../common/disk/fileValidator';
+import { FileUploadType } from '../../common/disk/file-type';
 
 export function ApiUploadProfileFile() {
   return applyDecorators(

server/src/common/disk/fileUtils.ts

@@ -6,22 +6,24 @@ import {
   UploadedFile,
   Param,
   UseGuards,
-  BadRequestException,
   Query,
   HttpStatus,
   HttpCode,
+  FileTypeValidator,
+  MaxFileSizeValidator,
+  ParseFilePipe,
 } from '@nestjs/common';
 import { FileInterceptor } from '@nestjs/platform-express';
 import { FileService } from '../service/file.service';
 import { ApiTags } from '@nestjs/swagger';
 import { JwtGuard, Payload } from '../../common/guard/jwt.guard';
-import { createDynamicStorage } from '../../common/disk/diskStorage';
 import { ApiResponse } from '../../common/response/common.response';
 import { ApiUploadProfileFile } from '../api-docs/uploadProfileFile.api-docs';
 import { ApiDeleteFile } from '../api-docs/deleteFile.api-docs';
 import { DeleteFileParamRequestDto } from '../dto/request/deleteFile.dto';
 import { UploadFileQueryRequestDto } from '../dto/request/uploadFile.dto';
 import { CurrentUser } from '../../common/decorator';
+import { FILE_SIZE_LIMITS } from '../../common/disk/file-type';
 
 @ApiTags('File')
 @Controller('file')
@@ -32,15 +34,29 @@ export class FileController {
   @Post('')
   @ApiUploadProfileFile()
   @HttpCode(HttpStatus.CREATED)
-  @UseInterceptors(FileInterceptor('file', createDynamicStorage()))
+  @UseInterceptors(FileInterceptor('file'))
   async upload(
-    @UploadedFile() file: any,
+    @UploadedFile(
+      new ParseFilePipe({
+        validators: [
+          new MaxFileSizeValidator({
+            maxSize: FILE_SIZE_LIMITS.IMAGE,
+            message: 'file size limit',
+          }),
+          new FileTypeValidator({
+            fileType: /image\/(png|jpg|jpeg|webp)/,
+            skipMagicNumbersValidation: true,
+          }),
+        ],
+      }),
+    )
+    file: Express.Multer.File,
     @Query() query: UploadFileQueryRequestDto,
     @CurrentUser() user: Payload,
   ) {
-    if (!file) {
-      throw new BadRequestException('파일이 선택되지 않았습니다.');
-    }
+    file.path = (
+      await this.fileService.handleUpload(file, query.uploadType)
+    ).savedPath;
 
     return ApiResponse.responseWithData(
       '파일 업로드에 성공했습니다.',

server/src/common/disk/fileValidator.ts

@@ -1,5 +1,5 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { FileUploadType } from '../../../common/disk/fileValidator';
+import { FileUploadType } from '../../../common/disk/file-type';
 import { IsEnum } from 'class-validator';
 
 export class UploadFileQueryRequestDto {

server/src/file/api-docs/uploadProfileFile.api-docs.ts

@@ -2,35 +2,65 @@ import { Injectable, NotFoundException } from '@nestjs/common';
 import { File } from '../entity/file.entity';
 import { unlink, access } from 'fs/promises';
 import { FileRepository } from '../repository/file.repository';
-import { User } from '../../user/entity/user.entity';
 import { UploadFileResponseDto } from '../dto/response/uploadFile.dto';
 import { WinstonLoggerService } from '../../common/logger/logger.service';
+import * as fs from 'fs/promises';
+import * as path from 'path';
+import { FileUploadType } from '../../common/disk/file-type';
 
 @Injectable()
 export class FileService {
+  private readonly basePath = '/app/objects';
+
   constructor(
     private readonly fileRepository: FileRepository,
     private readonly logger: WinstonLoggerService,
   ) {}
 
-  async create(file: any, userId: number): Promise<UploadFileResponseDto> {
+  async handleUpload(file: Express.Multer.File, uploadType: FileUploadType) {
+    const today = this.getDateString();
+    const targetDir = path.join(this.basePath, uploadType, today);
+
+    await this.ensureDirectory(targetDir);
+
+    const filePath = path.join(targetDir, file.originalname);
+    await fs.writeFile(filePath, file.buffer);
+
+    return {
+      success: true,
+      uploadType,
+      savedPath: filePath,
+    };
+  }
+
+  private async ensureDirectory(dir: string) {
+    await fs.mkdir(dir, { recursive: true });
+  }
+
+  private getDateString(): string {
+    const now = new Date();
+    return now.toISOString().split('T')[0];
+  }
+
+  async create(
+    file: Express.Multer.File,
+    userId: number,
+  ): Promise<UploadFileResponseDto> {
     const { originalname, mimetype, size, path } = file;
     const savedFile = await this.fileRepository.save({
       originalName: originalname,
       mimetype,
       size,
       path,
-      user: { id: userId } as User,
-    } as File);
+      user: { id: userId },
+    });
     const accessUrl = this.generateAccessUrl(path);
 
     return UploadFileResponseDto.toResponseDto(savedFile, accessUrl);
   }
 
   private generateAccessUrl(filePath: string): string {
-    const baseUploadPath = '/app/objects';
-    const relativePath = filePath.replace(baseUploadPath, '');
-    return `/objects${relativePath}`;
+    return filePath.replace(this.basePath, '/objects');
   }
 
   async findById(id: number): Promise<File> {

server/src/file/controller/file.controller.ts

@@ -1,6 +1,6 @@
 import { validate } from 'class-validator';
 import { UploadFileQueryRequestDto } from '../../../src/file/dto/request/uploadFile.dto';
-import { FileUploadType } from '../../../src/common/disk/fileValidator';
+import { FileUploadType } from '../../../src/common/disk/file-type';
 
 describe('UploadFileQueryRequestDto Test', () => {
   let dto: UploadFileQueryRequestDto;