Skip to content

Commit ccb5483

Browse files
committed
🧼 clean: 피드 공통 DTO 명칭 변경
1 parent 585f444 commit ccb5483

File tree

8 files changed

+22
-68
lines changed

8 files changed

+22
-68
lines changed

server/src/feed/controller/feed.controller.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@ import { ApiSearchFeedList } from '../api-docs/searchFeedList.api-docs';
2626
import { ApiUpdateFeedViewCount } from '../api-docs/updateFeedViewCount.api-docs';
2727
import { ApiReadRecentFeedList } from '../api-docs/readRecentFeedList.api-docs';
2828
import { FeedTrendResponseDto } from '../dto/response/readFeedPagination.dto';
29-
import { UpdateFeedViewCountRequestDto } from '../dto/request/updateFeedViewCount.dto';
30-
import { GetFeedDetailRequestDto } from '../dto/request/getFeedDetail.dto';
3129
import { ApiGetFeedDetail } from '../api-docs/getFeedDetail.api-docs';
3230
import { ReadFeedInterceptor } from '../interceptor/read-feed.interceptor';
33-
import { DeleteCheckFeedRequestDto } from '../dto/request/deleteCheckFeed.dto';
31+
import { ManageFeedRequestDto } from '../dto/request/manageFeed.dto';
3432
import { ApiDeleteCheckFeed } from '../api-docs/deleteCheckFeed.api-docs';
3533

3634
@ApiTags('Feed')
@@ -95,7 +93,7 @@ export class FeedController {
9593
@Post('/:feedId')
9694
@HttpCode(HttpStatus.OK)
9795
async updateFeedViewCount(
98-
@Param() viewUpdateParamDto: UpdateFeedViewCountRequestDto,
96+
@Param() viewUpdateParamDto: ManageFeedRequestDto,
9997
@Req() request: Request,
10098
@Res({ passthrough: true }) response: Response,
10199
) {
@@ -123,7 +121,7 @@ export class FeedController {
123121
@Get('/detail/:feedId')
124122
@HttpCode(HttpStatus.OK)
125123
@UseInterceptors(ReadFeedInterceptor)
126-
async getFeedDetail(@Param() feedDetailRequestDto: GetFeedDetailRequestDto) {
124+
async getFeedDetail(@Param() feedDetailRequestDto: ManageFeedRequestDto) {
127125
return ApiResponse.responseWithData(
128126
'요청이 성공적으로 처리되었습니다.',
129127
await this.feedService.getFeedDetail(feedDetailRequestDto),
@@ -133,9 +131,7 @@ export class FeedController {
133131
@ApiDeleteCheckFeed()
134132
@Delete('/:feedId')
135133
@HttpCode(HttpStatus.OK)
136-
async deleteCheckFeed(
137-
@Param() feedDeleteCheckDto: DeleteCheckFeedRequestDto,
138-
) {
134+
async deleteCheckFeed(@Param() feedDeleteCheckDto: ManageFeedRequestDto) {
139135
await this.feedService.deleteCheckFeed(feedDeleteCheckDto);
140136
return ApiResponse.responseWithNoContent(
141137
'게시글 삭제 확인 요청을 성공했습니다.',

server/src/feed/dto/request/deleteCheckFeed.dto.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

server/src/feed/dto/request/getFeedDetail.dto.ts renamed to server/src/feed/dto/request/manageFeed.dto.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ApiProperty } from '@nestjs/swagger';
22
import { Type } from 'class-transformer';
33
import { IsInt, Min } from 'class-validator';
44

5-
export class GetFeedDetailRequestDto {
5+
export class ManageFeedRequestDto {
66
@ApiProperty({
77
example: 1,
88
description: '조회할 게시글 ID 입력',
@@ -14,7 +14,7 @@ export class GetFeedDetailRequestDto {
1414
@Type(() => Number)
1515
feedId: number;
1616

17-
constructor(partial: Partial<GetFeedDetailRequestDto>) {
17+
constructor(partial: Partial<ManageFeedRequestDto>) {
1818
Object.assign(this, partial);
1919
}
2020
}

server/src/feed/dto/request/updateFeedViewCount.dto.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

server/src/feed/service/feed.service.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,8 @@ import {
2424
FeedRecentRedis,
2525
ReadFeedRecentResponseDto,
2626
} from '../dto/response/readFeedRecent.dto';
27-
import { UpdateFeedViewCountRequestDto } from '../dto/request/updateFeedViewCount.dto';
28-
import { GetFeedDetailRequestDto } from '../dto/request/getFeedDetail.dto';
2927
import { GetFeedDetailResponseDto } from '../dto/response/getFeedDetail';
30-
import { DeleteCheckFeedRequestDto } from '../dto/request/deleteCheckFeed.dto';
28+
import { ManageFeedRequestDto } from '../dto/request/manageFeed.dto';
3129

3230
@Injectable()
3331
export class FeedService {
@@ -137,7 +135,7 @@ export class FeedService {
137135
}
138136

139137
async updateFeedViewCount(
140-
viewUpdateParamDto: UpdateFeedViewCountRequestDto,
138+
viewUpdateParamDto: ManageFeedRequestDto,
141139
request: Request,
142140
response: Response,
143141
) {
@@ -235,12 +233,12 @@ export class FeedService {
235233
return request.socket.remoteAddress;
236234
}
237235

238-
async getFeedDetail(feedDetailRequestDto: GetFeedDetailRequestDto) {
236+
async getFeedDetail(feedDetailRequestDto: ManageFeedRequestDto) {
239237
const feed = await this.getFeedByView(feedDetailRequestDto.feedId);
240238
return GetFeedDetailResponseDto.toResponseDto(feed);
241239
}
242240

243-
async deleteCheckFeed(feedDeleteCheckDto: DeleteCheckFeedRequestDto) {
241+
async deleteCheckFeed(feedDeleteCheckDto: ManageFeedRequestDto) {
244242
const feed = await this.getFeed(feedDeleteCheckDto.feedId);
245243
const response = await fetch(feed.path);
246244

server/test/feed/dto/feed-delete.dto.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { validate } from 'class-validator';
2-
import { DeleteCheckFeedRequestDto } from '../../../src/feed/dto/request/deleteCheckFeed.dto';
2+
import { ManageFeedRequestDto } from '../../../src/feed/dto/request/manageFeed.dto';
33

44
describe('FeedDeleteCheckDto Test', () => {
55
it('feedId에 1보다 작은 값을 입력하면 유효성 검사에 실패한다.', async () => {
66
//given
7-
const feedPaginationQueryDto = new DeleteCheckFeedRequestDto({
7+
const feedPaginationQueryDto = new ManageFeedRequestDto({
88
feedId: -1,
99
});
1010

@@ -18,7 +18,7 @@ describe('FeedDeleteCheckDto Test', () => {
1818

1919
it('feedId에 자연수가 아닌 실수를 입력하면 유효성 검사에 실패한다.', async () => {
2020
//given
21-
const feedPaginationQueryDto = new DeleteCheckFeedRequestDto({
21+
const feedPaginationQueryDto = new ManageFeedRequestDto({
2222
feedId: 1.254,
2323
});
2424

@@ -32,7 +32,7 @@ describe('FeedDeleteCheckDto Test', () => {
3232

3333
it('feedId에 문자열을 입력하면 유효성 검사에 실패한다.', async () => {
3434
//given
35-
const feedPaginationQueryDto = new DeleteCheckFeedRequestDto({
35+
const feedPaginationQueryDto = new ManageFeedRequestDto({
3636
feedId: 'abcdefg' as any,
3737
});
3838

server/test/feed/dto/feed-update.dto.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1+
import { ManageFeedRequestDto } from './../../../src/feed/dto/request/manageFeed.dto';
12
import { validate } from 'class-validator';
2-
import { UpdateFeedViewCountRequestDto } from '../../../src/feed/dto/request/updateFeedViewCount.dto';
33

44
describe('FeedViewUpdateRequestDto Test', () => {
55
it('feedId에 1보다 작은 값을 입력하면 유효성 검사에 실패한다.', async () => {
66
//given
7-
const feedPaginationQueryDto = new UpdateFeedViewCountRequestDto({
7+
const feedPaginationQueryDto = new ManageFeedRequestDto({
88
feedId: -1,
99
});
1010

@@ -18,7 +18,7 @@ describe('FeedViewUpdateRequestDto Test', () => {
1818

1919
it('feedId에 자연수가 아닌 실수를 입력하면 유효성 검사에 실패한다.', async () => {
2020
//given
21-
const feedPaginationQueryDto = new UpdateFeedViewCountRequestDto({
21+
const feedPaginationQueryDto = new ManageFeedRequestDto({
2222
feedId: 1.254,
2323
});
2424

@@ -32,7 +32,7 @@ describe('FeedViewUpdateRequestDto Test', () => {
3232

3333
it('feedId에 문자열을 입력하면 유효성 검사에 실패한다.', async () => {
3434
//given
35-
const feedPaginationQueryDto = new UpdateFeedViewCountRequestDto({
35+
const feedPaginationQueryDto = new ManageFeedRequestDto({
3636
feedId: 'abcdefg' as any,
3737
});
3838

server/test/feed/e2e/feed-detail.e2e-spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { FeedFixture } from '../../fixture/feed.fixture';
44
import { FeedRepository } from '../../../src/feed/repository/feed.repository';
55
import { RssAcceptRepository } from '../../../src/rss/repository/rss.repository';
66
import { RssAcceptFixture } from '../../fixture/rssAccept.fixture';
7-
import { GetFeedDetailRequestDto } from '../../../src/feed/dto/request/getFeedDetail.dto';
7+
import { ManageFeedRequestDto } from '../../../src/feed/dto/request/manageFeed.dto';
88

99
describe('GET api/feed/detail E2E Test', () => {
1010
let app: INestApplication;
@@ -28,7 +28,7 @@ describe('GET api/feed/detail E2E Test', () => {
2828

2929
it('feedId를 요청 받으면 해당 Feed의 정보로 응답한다.', async () => {
3030
//given
31-
const feedDetailRequestDto = new GetFeedDetailRequestDto({
31+
const feedDetailRequestDto = new ManageFeedRequestDto({
3232
feedId: 1,
3333
});
3434

@@ -44,7 +44,7 @@ describe('GET api/feed/detail E2E Test', () => {
4444

4545
it('태그가 없다면 빈 배열로 응답한다.', async () => {
4646
//given
47-
const feedDetailRequestDto = new GetFeedDetailRequestDto({
47+
const feedDetailRequestDto = new ManageFeedRequestDto({
4848
feedId: 11,
4949
});
5050

@@ -61,7 +61,7 @@ describe('GET api/feed/detail E2E Test', () => {
6161

6262
it('없는 피드를 조회한다면 404번 에러를 반환한다.', async () => {
6363
//given
64-
const feedDetailRequestDto = new GetFeedDetailRequestDto({
64+
const feedDetailRequestDto = new ManageFeedRequestDto({
6565
feedId: 100,
6666
});
6767

0 commit comments

Comments
 (0)