✅ test: feed 도메인 테스트 코드 최종 리팩토링

Author: Jo-Minseok

server/test/feed/e2e/delete.e2e-spec.ts

@@ -26,6 +26,7 @@ describe(`DELETE ${URL}/{feedId} E2E Test`, () => {
     rssAccept = await rssAcceptRepository.save(
       RssAcceptFixture.createRssAcceptFixture(),
     );
+    feed = await feedRepository.save(FeedFixture.createFeedFixture(rssAccept));
   });
 
   it('[404] 존재하지 않는 게시글 ID에 요청을 보낼 경우 404를 응답한다.', async () => {
@@ -36,11 +37,18 @@ describe(`DELETE ${URL}/{feedId} E2E Test`, () => {
     const { data } = response.body;
     expect(response.status).toBe(HttpStatus.NOT_FOUND);
     expect(data).toBeUndefined();
+
+    // DB, Redis when
+    const savedFeed = await feedRepository.findOneBy({
+      id: feed.id,
+    });
+
+    // DB, Redis then
+    expect(savedFeed).not.toBeNull();
   });
 
   it('[404] 원본 게시글이 존재하지 않을 경우 서비스에서 게시글 정보를 삭제하여 조회를 실패한다.', async () => {
     // given
-    feed = await feedRepository.save(FeedFixture.createFeedFixture(rssAccept));
     global.fetch = jest
       .fn()
       .mockResolvedValue({ ok: false, status: HttpStatus.NOT_FOUND });
@@ -52,6 +60,14 @@ describe(`DELETE ${URL}/{feedId} E2E Test`, () => {
     const { data } = response.body;
     expect(response.status).toBe(HttpStatus.NOT_FOUND);
     expect(data).toBeUndefined();
+
+    // DB, Redis when
+    const savedFeed = await feedRepository.findOneBy({
+      id: feed.id,
+    });
+
+    // DB, Redis then
+    expect(savedFeed).toBeNull();
   });
 
   it('[200] 원본 게시글이 존재할 경우 조회를 성공한다.', async () => {

server/test/feed/e2e/recent.e2e-spec.ts

@@ -16,6 +16,8 @@ describe(`GET ${URL} E2E Test`, () => {
   let agent: TestAgent;
   let redisService: RedisService;
   let feedList: Feed[];
+  const redisKeyMake = (data: string) =>
+    `${REDIS_KEYS.FEED_RECENT_KEY}:${data}`;
 
   beforeAll(async () => {
     app = global.testApp;
@@ -37,7 +39,7 @@ describe(`GET ${URL} E2E Test`, () => {
     // given
     await redisService.executePipeline((pipeline) => {
       feedList.forEach((feed) => {
-        pipeline.hset(`${REDIS_KEYS.FEED_RECENT_KEY}:${feed.id}`, {
+        pipeline.hset(redisKeyMake(feed.id.toString()), {
           id: feed.id,
           blogPlatform: feed.blog.blogPlatform,
           createdAt: feed.createdAt.toISOString(),
@@ -84,7 +86,7 @@ describe(`GET ${URL} E2E Test`, () => {
     // cleanup
     await redisService.executePipeline((pipeline) => {
       feedList.forEach((feed) => {
-        pipeline.del(`${REDIS_KEYS.FEED_RECENT_KEY}:${feed.id}`);
+        pipeline.del(redisKeyMake(feed.id.toString()));
       });
     });
   });

server/test/feed/e2e/up-view-count.e2e-spec.ts

@@ -18,6 +18,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
   let feed: Feed;
   let feedRepository: FeedRepository;
   const testIp = '1.1.1.1';
+  const redisKeyMake = (data: string) => `feed:${data}:ip`;
 
   beforeAll(async () => {
     app = global.testApp;
@@ -31,7 +32,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
     feed = await feedRepository.save(
       FeedFixture.createFeedFixture(rssAccept, {}, 1),
     );
-    await redisService.sadd(`feed:${feed.id}:ip`, testIp);
+    await redisService.sadd(redisKeyMake(feed.id.toString()), testIp);
   });
 
   it('[404] 피드가 서비스에 존재하지 않을 경우 조회수 상승을 실패한다.', async () => {
@@ -61,7 +62,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
       id: feed.id,
     });
     const savedFeedReadRedis = await redisService.sismember(
-      `feed:${feed.id}:ip`,
+      redisKeyMake(feed.id.toString()),
       testIp,
     );
 
@@ -72,7 +73,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
 
   it('[200] 읽은 기록 쿠키가 없지만 읽은 기록 IP가 있을 경우 조회수 상승을 하지 않는 행위를 성공한다.', async () => {
     // given
-    await redisService.sadd(`feed:${feed.id}:ip`, testIp);
+    await redisService.sadd(redisKeyMake(feed.id.toString()), testIp);
 
     // Http when
     const response = await agent
@@ -92,7 +93,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
       id: feed.id,
     });
     const savedFeedReadRedis = await redisService.sismember(
-      `feed:${feed.id}:ip`,
+      redisKeyMake(feed.id.toString()),
       testIp,
     );
 
@@ -103,7 +104,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
     // cleanup
     await Promise.all([
       redisService.zrem(REDIS_KEYS.FEED_TREND_KEY, feed.id.toString()),
-      redisService.srem(`feed:${feed.id}:ip`, testIp),
+      redisService.srem(redisKeyMake(feed.id.toString()), testIp),
     ]);
   });
 
@@ -129,7 +130,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
       id: feed.id,
     });
     const savedFeedReadRedis = await redisService.sismember(
-      `feed:${feed.id}:ip`,
+      redisKeyMake(feed.id.toString()),
       testIp,
     );
 
@@ -140,7 +141,7 @@ describe(`POST ${URL}/{feedId} E2E Test`, () => {
     // cleanup
     await Promise.all([
       redisService.zrem(REDIS_KEYS.FEED_TREND_KEY, feed.id.toString()),
-      redisService.srem(`feed:${feed.id}:ip`, testNewIp),
+      redisService.srem(redisKeyMake(feed.id.toString()), testNewIp),
     ]);
     await feedRepository.update(feed.id, { viewCount: feed.viewCount });
   });