Suppress false positives from coverity

Author: Flamefire

src/cstdio.cpp

@@ -43,7 +43,7 @@ namespace nowide {
     {
         const wstackstring wname(file_name);
         const wshort_stackstring wmode(mode);
-        return _wfreopen(wname.get(), wmode.get(), stream);
+        return _wfreopen(wname.get(), wmode.get(), stream); // coverity[var_deref_model]
     }
     ///
     /// \brief Same as fopen but file_name and mode are UTF-8 strings
@@ -52,7 +52,7 @@ namespace nowide {
     {
         const wstackstring wname(file_name);
         const wshort_stackstring wmode(mode);
-        return detail::wfopen(wname.get(), wmode.get());
+        return detail::wfopen(wname.get(), wmode.get()); // coverity[var_deref_model]
     }
     ///
     /// \brief Same as rename but old_name and new_name are UTF-8 strings

test/test.hpp

@@ -111,13 +111,13 @@ int main(int argc, char** argv, char** env)
 {
     try
     {
+#ifdef _MSC_VER
+        std::cout << "MSVC version " << _MSC_VER << std::endl;
+#endif
         test_main(argc, argv, env);
     } catch(const std::exception& e)
     {
         std::cerr << "Failed " << e.what() << std::endl;
-#ifdef _MSC_VER
-        std::cerr << "MSVC version " << _MSC_VER << std::endl;
-#endif
         return 1;
     }
     return 0;

test/test_codecvt.cpp

@@ -412,8 +412,7 @@ void test_codecvt_subst()
     run_all(codecvt_to_wide, codecvt_to_narrow);
 }
 
-// coverity [root_function]
-void test_main(int, char**, char**)
+void test_main(int, char**, char**) // coverity [root_function]
 {
     test_codecvt_basic();
     test_codecvt_unshift();

test/test_convert.cpp

@@ -127,8 +127,7 @@ std::string narrow_string_view(const std::wstring& s)
 }
 #endif
 
-// coverity [root_function]
-void test_main(int, char**, char**)
+void test_main(int, char**, char**) // coverity [root_function]
 {
     std::string hello = "\xd7\xa9\xd7\x9c\xd7\x95\xd7\x9d";
     std::wstring whello = L"\u05e9\u05dc\u05d5\u05dd";

test/test_env.cpp

@@ -14,8 +14,7 @@
 #include <windows.h>
 #endif
 
-// coverity [root_function]
-void test_main(int, char**, char**)
+void test_main(int, char**, char**) // coverity [root_function]
 {
     std::string example = "\xd7\xa9-\xd0\xbc-\xce\xbd";
     std::string envVar = "BOOST_TEST2=" + example + "x";

test/test_filebuf.cpp

@@ -138,9 +138,13 @@ void test_64_bit_seek(const std::string& filepath)
 #pragma warning(disable : 4127)
 #endif
     // if we can't use 64 bit offsets through the API, don't test anything
+    // LCOV_EXCL_START
     // coverity[result_independent_of_operands]
     if(offset == nw::filebuf::off_type(0))
-        return; // LCOV_EXCL_LINE coverity[dead_error_line]
+    {
+        return; // coverity[dead_error_line]
+    }
+    // LCOV_EXCL_STOP
 #ifdef BOOST_MSVC
 #pragma warning(pop)
 #endif
@@ -298,8 +302,7 @@ void test_swap(const std::string& filepath)
     }
 }
 
-// coverity [root_function]
-void test_main(int, char** argv, char**)
+void test_main(int, char** argv, char**) // coverity [root_function]
 {
     const std::string exampleFilename = std::string(argv[0]) + "-\xd7\xa9-\xd0\xbc-\xce\xbd.txt";
 

test/test_fs.cpp

@@ -21,8 +21,7 @@
 #endif
 #include <boost/filesystem/operations.hpp>
 
-// coverity [root_function]
-void test_main(int, char** argv, char**)
+void test_main(int, char** argv, char**) // coverity [root_function]
 {
     boost::nowide::nowide_filesystem();
     const std::string prefix = argv[0];

test/test_fstream.cpp

@@ -533,8 +533,7 @@ void test_flush(const std::string& filepath)
     TEST(!fo.seekg(0)); // Does not work on closed stream
 }
 
-// coverity [root_function]
-void test_main(int, char** argv, char**)
+void test_main(int, char** argv, char**) // coverity [root_function]
 {
     const std::string exampleFilename = std::string(argv[0]) + "-\xd7\xa9-\xd0\xbc-\xce\xbd.txt";
 

test/test_fstream_special.cpp

@@ -257,8 +257,7 @@ void testPutback(const char* filename)
     }
 }
 
-// coverity [root_function]
-void test_main(int, char** argv, char**)
+void test_main(int, char** argv, char**) // coverity [root_function]
 {
     const std::string exampleFilename = std::string(argv[0]) + "-\xd7\xa9-\xd0\xbc-\xce\xbd.txt";
     const std::string exampleFilename2 = std::string(argv[0]) + "-\xd7\xa9-\xd0\xbc-\xce\xbd 2.txt";

test/test_ifstream.cpp

@@ -199,8 +199,7 @@ void test_move_and_swap(const std::string& filename)
     }
 }
 
-// coverity [root_function]
-void test_main(int, char** argv, char**)
+void test_main(int, char** argv, char**) // coverity [root_function]
 {
     const std::string exampleFilename = std::string(argv[0]) + "-\xd7\xa9-\xd0\xbc-\xce\xbd.txt";