Don't require non-const reference to call notify() #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #79 +/- ##
===========================================
+ Coverage 49.89% 50.03% +0.14%
===========================================
Files 23 23
Lines 1385 1387 +2
Branches 707 707
===========================================
+ Hits 691 694 +3
Misses 110 110
+ Partials 584 583 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes notify() and variables_map::notify() to not require a non-const reference to the variables_map. This is useful if you are passing this object from one module to another and want to trigger handling of those variables in the new module's context without enabling that new module to mutate the shared map's state.