get_impl is now private

Author: anarthal

include/boost/redis/adapter/any_adapter.hpp

@@ -10,14 +10,22 @@
 
 #include <boost/redis/resp3/node.hpp>
 #include <boost/redis/adapter/adapt.hpp>
-#include <boost/system/detail/error_code.hpp>
+#include <boost/system/error_code.hpp>
 #include <cstddef>
 #include <functional>
 #include <string_view>
 #include <type_traits>
 
 namespace boost::redis {
 
+namespace detail { 
+
+// Forward decl
+template <class Executor>
+class connection_base;
+
+}
+
 class any_adapter
 {
     using fn_type = std::function<void(std::size_t, resp3::basic_node<std::string_view> const&, system::error_code&)>;
@@ -36,12 +44,12 @@ class any_adapter
         return { std::move(adapter), size };
     }
 
+    template <class Executor>
+    friend class detail::connection_base;
+
 public:
     template <class T, class = std::enable_if_t<!std::is_same_v<T, any_adapter>>>
     explicit any_adapter(T& response) : impl_(create_impl(response)) {}
-
-    // TODO: make this private
-    auto get_impl() && { return std::move(impl_); }
 };
 
 }

include/boost/redis/detail/connection_base.hpp

@@ -445,9 +445,9 @@ class connection_base {
    }
 
    template <class CompletionToken>
-   auto async_exec(request const& req, any_adapter adapter, CompletionToken&& token)
+   auto async_exec(request const& req, any_adapter&& adapter, CompletionToken&& token)
    {
-      auto adapter_impl = std::move(adapter).get_impl();
+      auto& adapter_impl = adapter.impl_;
       BOOST_ASSERT_MSG(req.get_expected_responses() <= adapter_impl.supported_response_size, "Request and response have incompatible sizes.");
 
       auto info = std::make_shared<req_info>(req, std::move(adapter_impl.adapt_fn), get_executor());