Merge pull request #221 from boostorg/develop

Fixes for Boost 1.87

Author: mzimbres

.github/workflows/coverage.yml

@@ -38,7 +38,6 @@ if (BOOST_REDIS_MAIN_PROJECT)
     align
     context
     core
-    coroutine
     static_assert
     pool
     date_time

CMakeLists.txt

@@ -678,42 +678,49 @@ https://lists.boost.org/Archives/boost/2023/01/253944.php.
 
 ### Boost 1.87
 
-* ([Issue 205](https://github.com/boostorg/redis/issues/205))
+* (Issue [205](https://github.com/boostorg/redis/issues/205))
   Improves reaction time to disconnection by using `wait_for_one_error`
   instead of `wait_for_all`. The function `connection::async_run` was
   also changed to return EOF to the user when that error is received
   from the server. That is a breaking change.
 
-* ([Issue 210](https://github.com/boostorg/redis/issues/210))
+* (Issue [210](https://github.com/boostorg/redis/issues/210))
   Fixes the adapter of empty nested reposponses.
 
+* (Issues [211](https://github.com/boostorg/redis/issues/211) and [212](https://github.com/boostorg/redis/issues/212))
+  Fixes the reconnect loop that would hang under certain conditions,
+  see the linked issues for more details.
+
+* (Issue [219](https://github.com/boostorg/redis/issues/219))
+  Changes the default log level from `disabled` to `debug`.
+
 ### Boost 1.85
 
-* ([Issue 170](https://github.com/boostorg/redis/issues/170))
+* (Issue [170](https://github.com/boostorg/redis/issues/170))
   Under load and on low-latency networks it is possible to start
   receiving responses before the write operation completed and while
   the request is still marked as staged and not written. This messes
   up with the heuristics that classifies responses as unsolicied or
   not.
 
-* ([Issue 168](https://github.com/boostorg/redis/issues/168)).
+* (Issue [168](https://github.com/boostorg/redis/issues/168)).
   Provides a way of passing a custom SSL context to the connection.
   The design here differs from that of Boost.Beast and Boost.MySql
   since in Boost.Redis the connection owns the context instead of only
   storing a reference to a user provided one. This is ok so because
   apps need only one connection for their entire application, which
   makes the overhead of one ssl-context per connection negligible.
 
-* ([Issue 181](https://github.com/boostorg/redis/issues/181)).
+* (Issue [181](https://github.com/boostorg/redis/issues/181)).
   See a detailed description of this bug in
   [this](https://github.com/boostorg/redis/issues/181#issuecomment-1913346983)
   comment.
 
-* ([Issue 182](https://github.com/boostorg/redis/issues/182)).
+* (Issue [182](https://github.com/boostorg/redis/issues/182)).
   Sets `"default"` as the default value of `config::username`. This
   makes it simpler to use the `requirepass` configuration in Redis.
 
-* ([Issue 189](https://github.com/boostorg/redis/issues/189)).
+* (Issue [189](https://github.com/boostorg/redis/issues/189)).
   Fixes narrowing convertion by using `std::size_t` instead of
   `std::uint64_t` for the sizes of bulks and aggregates. The code
   relies now on `std::from_chars` returning an error if a value

README.md

@@ -42,10 +42,10 @@ struct connect_op {
          ctor_->endpoint_ = ep;
 
          if (ec == asio::error::operation_aborted) {
-            ec == error::connect_timeout;
+            self.complete(redis::error::connect_timeout);
+         } else {
+            self.complete(ec);
          }
-
-         self.complete(ec);
       }
    }
 };

include/boost/redis/detail/connector.hpp

@@ -41,9 +41,10 @@ struct resolve_op {
          resv_->results_ = res;
 
          if (ec == asio::error::operation_aborted) {
-            ec == error::resolve_timeout;
+            self.complete(error::resolve_timeout);
+         } else {
+            self.complete(ec);
          }
-         self.complete(ec);
       }
    }
 };

include/boost/redis/detail/resolver.hpp

@@ -64,7 +64,7 @@ class logger {
     *
     *  @param l Log level.
     */
-   logger(level l = level::disabled)
+   logger(level l = level::debug)
    : level_{l}
    {}
 

include/boost/redis/logger.hpp

@@ -9,7 +9,7 @@
 #include <boost/system/errc.hpp>
 #include <boost/asio/detached.hpp>
 #include <boost/asio/co_spawn.hpp>
-#include <boost/asio/experimental/as_tuple.hpp>
+#include <boost/asio/as_tuple.hpp>
 #define BOOST_TEST_MODULE conn-push
 #include <boost/test/included/unit_test.hpp>
 #include <iostream>
@@ -21,7 +21,7 @@ namespace redis = boost::redis;
 using boost::redis::operation;
 using connection = boost::redis::connection;
 using error_code = boost::system::error_code;
-using net::experimental::as_tuple;
+using net::as_tuple;
 using boost::redis::request;
 using boost::redis::response;
 using boost::redis::ignore;

test/test_conn_push.cpp

@@ -15,14 +15,14 @@
 
 #ifdef BOOST_ASIO_HAS_CO_AWAIT
 #include <boost/asio/experimental/awaitable_operators.hpp>
-#include <boost/asio/experimental/as_tuple.hpp>
+#include <boost/asio/as_tuple.hpp>
 
 namespace net = boost::asio;
 
 using boost::redis::operation;
 using boost::redis::connection;
 using boost::system::error_code;
-using net::experimental::as_tuple;
+using net::as_tuple;
 using boost::redis::request;
 using boost::redis::response;
 using boost::redis::ignore;