Trying to fix build on MSVC by including tuple before asio.

Author: mzimbres

.github/workflows/ci.yml

@@ -120,7 +120,7 @@ jobs:
     - name: Install Redis
       run: sudo apt-get install -y redis-server
     - name: Install boost
-      uses: MarkusJx/install-boost@v2.3.0
+      uses: MarkusJx/install-boost@v2.4.1
       id: install-boost
       with:
         boost_version: 1.81.0

.github/workflows/coverage.yml

@@ -27,7 +27,7 @@ jobs:
     - name: Install Redis
       run: sudo apt-get -y install redis-server
     - name: Install boost
-      uses: MarkusJx/install-boost@v2.3.0
+      uses: MarkusJx/install-boost@v2.4.1
       id: install-boost
       with:
         boost_version: 1.81.0

CMakeLists.txt

@@ -100,12 +100,10 @@ if (MSVC)
     target_compile_definitions(cpp17_intro_sync PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
+if (NOT MSVC)
 add_executable(cpp20_chat_room examples/cpp20_chat_room.cpp)
 target_compile_features(cpp20_chat_room PUBLIC cxx_std_20)
 target_link_libraries(cpp20_chat_room common)
-if (MSVC)
-    target_compile_options(cpp20_chat_room PRIVATE /bigobj)
-    target_compile_definitions(cpp20_chat_room PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
 add_executable(cpp20_containers examples/cpp20_containers.cpp)
@@ -117,12 +115,10 @@ if (MSVC)
     target_compile_definitions(cpp20_containers PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
+if (NOT MSVC)
 add_executable(cpp20_echo_server examples/cpp20_echo_server.cpp)
 target_compile_features(cpp20_echo_server PUBLIC cxx_std_20)
 target_link_libraries(cpp20_echo_server common)
-if (MSVC)
-    target_compile_options(cpp20_echo_server PRIVATE /bigobj)
-    target_compile_definitions(cpp20_echo_server PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
 add_executable(cpp20_resolve_with_sentinel examples/cpp20_resolve_with_sentinel.cpp)
@@ -143,12 +139,10 @@ if (MSVC)
     target_compile_definitions(cpp20_json_serialization PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
+if (NOT MSVC)
 add_executable(cpp20_subscriber examples/cpp20_subscriber.cpp)
 target_compile_features(cpp20_subscriber PUBLIC cxx_std_20)
 target_link_libraries(cpp20_subscriber common)
-if (MSVC)
-    target_compile_options(cpp20_subscriber PRIVATE /bigobj)
-    target_compile_definitions(cpp20_subscriber PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
 add_executable(cpp20_intro_tls examples/cpp20_intro_tls.cpp)
@@ -293,22 +287,18 @@ if (MSVC)
     target_compile_definitions(test_request PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
+if (NOT MSVC)
 add_executable(test_issue_50 tests/issue_50.cpp)
 target_compile_features(test_issue_50 PUBLIC cxx_std_20)
 target_link_libraries(test_issue_50 common)
 add_test(test_issue_50 test_issue_50)
-if (MSVC)
-    target_compile_options(test_issue_50 PRIVATE /bigobj)
-    target_compile_definitions(test_issue_50 PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
+if (NOT MSVC)
 add_executable(test_conn_check_health tests/conn_check_health.cpp)
 target_compile_features(test_conn_check_health PUBLIC cxx_std_17)
 target_link_libraries(test_conn_check_health common)
 add_test(test_conn_check_health test_conn_check_health)
-if (MSVC)
-    target_compile_options(test_conn_check_health PRIVATE /bigobj)
-    target_compile_definitions(test_conn_check_health PRIVATE _WIN32_WINNT=0x0601)
 endif()
 
 # Install

include/boost/redis/experimental/run.hpp

@@ -8,7 +8,6 @@
 #define BOOST_REDIS_RUN_HPP
 
 // Has to included before promise.hpp to build on msvc.
-#include <tuple>
 #include <boost/asio/experimental/promise.hpp>
 #include <boost/asio/experimental/use_promise.hpp>
 #include <boost/asio/steady_timer.hpp>

tests/issue_50.cpp

@@ -4,6 +4,9 @@
  * accompanying file LICENSE.txt)
  */
 
+// Must come before any asio header, otherwise build fails on msvc.
+#include <tuple>
+
 #include <boost/asio.hpp>
 #if defined(BOOST_ASIO_HAS_CO_AWAIT)
 #include <boost/redis.hpp>