Fixes an exception when parsing intercalated errors and success msgs into generic_response #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges into generic_response close boostorg#287
mzimbres
reviewed
Jul 28, 2025
| BOOST_TEST(ec == error_code()); | ||
| exec_finished = true; | ||
| conn.cancel(); | ||
| }); |
There was a problem hiding this comment.
Early feedback: when async_exec fails to execute the commands of a request it should complete with an error. I think all adapters work like this.
There was a problem hiding this comment.
How the hell do tests pass then? lol
There was a problem hiding this comment.
Hm, none of general_aggregate nor general_simple seem to be setting the output error code on failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #287