Fix pretty-printers not working when constexpr variables are optimized away #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
- Coverage 98.24% 98.23% -0.01%
===========================================
Files 161 161
Lines 22224 22224
===========================================
- Hits 21833 21832 -1
- Misses 391 392 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| N = group["N"] | ||
| sentinel_ = group["sentinel_"] | ||
| N = 15 # `group["N"]` may be optimized out | ||
| sentinel_ = 1 # `group["sentinel_"]` may be optimized out | ||
| if self.is_regular_layout(group): |
There was a problem hiding this comment.
I'd rather define these as self.N and self.sentinel_ in BoostUnorderedFoaPrinter.__init__ so that we avoid the duplication of magic constants in BoostUnorderedFoaPrinter.chidlren.
…from the beginning This is not a public header. It is only meant to be consumed as a transitive include.
…d away Also do a few other things. * `groups` and `elements` are now stored inside `self` * `mask`, `n0`, and `n` aren't declared ahead of their first assignment * Remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #314