Skip to content

Commit 4441fd6

Browse files
committed
qemu: Use --inode-file-handles=fallback for older virtiofsd compat
This is the new default, but needs to be turned on for older versions that are shipped in the Ubuntu used in GHA. Signed-off-by: Colin Walters <[email protected]>
1 parent f0e2849 commit 4441fd6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

crates/kit/src/qemu.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -934,12 +934,15 @@ pub async fn spawn_virtiofsd_async(config: &VirtiofsConfig) -> Result<tokio::pro
934934
&config.sandbox,
935935
]);
936936

937+
// https://gitlab.com/virtio-fs/virtiofsd/-/issues/17 - this is the new default,
938+
// but we want to be compatible with older virtiofsd too.
939+
cmd.arg("--inode-file-handles=fallback");
940+
937941
// Redirect stdout/stderr to /dev/null unless debug mode is enabled
938942
if !config.debug {
939943
cmd.stdout(std::process::Stdio::null())
940944
.stderr(std::process::Stdio::null());
941945
} else {
942-
// In debug mode, prefix output to distinguish from QEMU
943946
cmd.stdout(std::process::Stdio::piped())
944947
.stderr(std::process::Stdio::piped());
945948
}

0 commit comments

Comments
 (0)