Minor cleanup of build warnings

There's plenty of other stuff that clippy complains about, but these
are the things bad enough that a bare `cargo build` or `cargo check`
was warning on.

Signed-off-by: John Eckersberg <[email protected]>

Author: jeckersb

crates/kit/src/cli_json.rs

@@ -1,6 +1,6 @@
 //! Export CLI structure as JSON for documentation generation
+#![cfg(feature = "docgen")]
 
-#[cfg(feature = "docgen")]
 use clap::Command;
 use serde::{Deserialize, Serialize};
 
@@ -36,7 +36,6 @@ pub struct CliPositional {
 }
 
 /// Convert a clap Command to our JSON representation
-#[cfg(feature = "docgen")]
 pub fn command_to_json(cmd: &Command) -> CliCommand {
     let mut options = Vec::new();
     let mut positionals = Vec::new();
@@ -128,7 +127,6 @@ pub fn command_to_json(cmd: &Command) -> CliCommand {
 }
 
 /// Dump the complete CLI structure as JSON
-#[cfg(feature = "docgen")]
 pub fn dump_cli_json() -> color_eyre::Result<String> {
     use clap::CommandFactory;
 

crates/kit/src/container_entrypoint.rs

@@ -1,6 +1,5 @@
 use clap::{Parser, Subcommand};
 use color_eyre::Result;
-use serde::{Deserialize, Serialize};
 use tokio::signal::unix::SignalKind;
 use tracing::debug;
 
@@ -34,16 +33,6 @@ pub struct SshOpts {
 #[derive(Parser)]
 pub struct MonitorStatusOpts {}
 
-/// Configuration passed via BCK_CONFIG environment variable
-#[derive(Serialize, Deserialize)]
-pub struct ContainerConfig {
-    pub memory_mb: u32,
-    pub vcpus: u32,
-    pub console: bool,
-    pub extra_args: Option<String>,
-    // Future: SSH config, etc.
-}
-
 pub async fn run_ephemeral_in_container() -> Result<()> {
     // Parse BCK_CONFIG from environment
     let config_json = std::env::var("BCK_CONFIG")?;

crates/kit/src/libvirt/run.rs

@@ -674,7 +674,7 @@ fn create_libvirt_domain_from_disk(
     if !opts.volumes.is_empty() {
         debug!("Processing {} volume mount(s)", opts.volumes.len());
 
-        for (idx, volume_str) in opts.volumes.iter().enumerate() {
+        for volume_str in opts.volumes.iter() {
             let (host_path, tag) = parse_volume_mount(volume_str)
                 .with_context(|| format!("Failed to parse volume mount '{}'", volume_str))?;
 

crates/kit/src/supervisor_status.rs

@@ -27,16 +27,6 @@ pub enum SupervisorState {
     Ready,
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub struct VmInfo {
-    /// Whether SSH is available
-    pub ssh_available: bool,
-    /// Port number for SSH if forwarded
-    pub ssh_port: Option<u16>,
-    /// IP address if available
-    pub ip_address: Option<String>,
-}
-
 impl SupervisorStatus {
     /// Create a new status with the given state
     pub fn new(state: SupervisorState) -> Self {