Skip to content

Commit 57111be

Browse files
committed
ostree-ext: Add bootc feature
This is aiming to fix coreos/rpm-ostree#5251 Basically we can't re-invoke the calling process if we aren't actually bootc. (There are solutions that make this work, but what we'll hopefully do shortly is propagate the logic to older streams to have bootc take over the handling anyways) Signed-off-by: Colin Walters <[email protected]>
1 parent 4c5e4f2 commit 57111be

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

lib/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ anyhow = { workspace = true }
1919
bootc-utils = { path = "../utils" }
2020
bootc-blockdev = { path = "../blockdev" }
2121
camino = { workspace = true, features = ["serde1"] }
22-
ostree-ext = { path = "../ostree-ext" }
22+
ostree-ext = { path = "../ostree-ext", features = ["bootc"] }
2323
chrono = { workspace = true, features = ["serde"] }
2424
clap = { workspace = true, features = ["derive","cargo"] }
2525
clap_mangen = { workspace = true, optional = true }

ostree-ext/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ features = ["dox"]
7070
docgen = ["clap_mangen"]
7171
dox = ["ostree/dox"]
7272
internal-testing-api = ["xshell", "indoc", "similar-asserts"]
73+
# Enable calling back into bootc
74+
bootc = []
7375

7476
[lints]
7577
workspace = true

ostree-ext/src/container/deploy.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,9 @@ pub async fn deploy(
143143
// crates. We need an option to skip though so when the *main*
144144
// bootc install code calls this API, we don't do this as it
145145
// will have already been handled.
146+
// Note also we do this under a feature gate to ensure rpm-ostree
147+
// doesn't try to invoke this, as that won't work right now.
148+
#[cfg(feature = "bootc")]
146149
if !options.skip_completion {
147150
// Note that the sysroot is provided as `.` but we use cwd_dir to
148151
// make the process current working directory the sysroot.

0 commit comments

Comments
 (0)