sysroot: Fix regression in status locking

The previous locking code was just wrong; my bad for not stress
testing it.

Fix it an add a test too.

Signed-off-by: Colin Walters <[email protected]>

Author: cgwalters

crates/ostree-ext/src/sysroot.rs

@@ -37,13 +37,9 @@ impl SysrootLock {
     /// immediately, a status message will be printed to standard output.
     /// The lock will be unlocked when this object is dropped.
     pub async fn new_from_sysroot(sysroot: &ostree::Sysroot) -> Result<Self> {
-        if sysroot.try_lock()? {
-            return Ok(Self {
-                sysroot: sysroot.clone(),
-                unowned: false,
-            });
-        }
-        async_task_with_spinner("Waiting for sysroot lock...", sysroot.lock_future()).await?;
+        let sysroot_clone = sysroot.clone();
+        let locker = tokio::task::spawn_blocking(move || sysroot_clone.lock());
+        async_task_with_spinner("Waiting for sysroot lock...", locker).await??;
         Ok(Self {
             sysroot: sysroot.clone(),
             unowned: false,

tmt/tests/booted/readonly/030-test-locking-read.nu

@@ -0,0 +1,32 @@
+# Verify we can spawn multiple bootc status at the same time
+use std assert
+use tap.nu
+
+tap begin "concurrent bootc status"
+
+# Fork via systemd-run
+let n = 10
+0..$n | each { |v|
+    # Clean up prior runs
+    systemctl stop $"bootc-status-($v)" | complete
+}
+# Fork off a concurrent bootc status
+0..$n | each { |v|
+    systemd-run --no-block -qr -u $"bootc-status-($v)" bootc status
+}
+
+# Await completion
+0..$n | each { |v|
+    loop {
+        let r = systemctl is-active $"bootc-status-($v)" | complete
+        if $r.exit_code == 0 {
+            break
+        }
+        # check status
+        systemctl status $"bootc-status-($v)" out> /dev/null
+        # Clean it up
+        systemctl reset-failed $"bootc-status-($v)"
+    }
+}
+
+tap ok