cli: add support for soft-reboots

This commit adds --queue-soft-reboot to the cli
which uses the ostree api's to setup soft-reboots
during switch, update and rollback operations.

Co-authored-by: Colin Walters <[email protected]>

Signed-off-by: Joseph Marrero Corchado <[email protected]>
Signed-off-by: Colin Walters <[email protected]>

Author: jmarrero

crates/lib/src/cli.rs

@@ -80,6 +80,13 @@ pub(crate) struct UpgradeOpts {
     #[clap(long, conflicts_with = "check")]
     pub(crate) apply: bool,
 
+    /// Queue a soft reboot after staging the deployment.
+    ///
+    /// This will prepare the system for a soft reboot instead of a full reboot,
+    /// which allows userspace to restart without rebooting the kernel.
+    #[clap(long, conflicts_with = "check")]
+    pub(crate) queue_soft_reboot: bool,
+
     #[clap(flatten)]
     pub(crate) progress: ProgressOptions,
 }
@@ -99,6 +106,13 @@ pub(crate) struct SwitchOpts {
     #[clap(long)]
     pub(crate) apply: bool,
 
+    /// Queue a soft reboot after staging the deployment.
+    ///
+    /// This will prepare the system for a soft reboot instead of a full reboot,
+    /// which allows userspace to restart without rebooting the kernel.
+    #[clap(long)]
+    pub(crate) queue_soft_reboot: bool,
+
     /// The transport; e.g. oci, oci-archive, containers-storage.  Defaults to `registry`.
     #[clap(long, default_value = "registry")]
     pub(crate) transport: String,
@@ -142,6 +156,13 @@ pub(crate) struct RollbackOpts {
     /// a userspace-only restart.
     #[clap(long)]
     pub(crate) apply: bool,
+
+    /// Queue a soft reboot after performing the rollback.
+    ///
+    /// This will prepare the system for a soft reboot instead of a full reboot,
+    /// which allows userspace to restart without rebooting the kernel.
+    #[clap(long)]
+    pub(crate) queue_soft_reboot: bool,
 }
 
 /// Perform an edit operation
@@ -562,7 +583,7 @@ pub(crate) enum Opt {
         Note on Rollbacks and the `/etc` Directory:
 
         When you perform a rollback (e.g., with `bootc rollback`), any
-        changes made to files in the `/etc` directory won’t carry over
+        changes made to files in the `/etc` directory won't carry over
         to the rolled-back deployment.  The `/etc` files will revert
         to their state from that previous deployment instead.
 
@@ -741,6 +762,40 @@ pub(crate) fn require_root(is_container: bool) -> Result<()> {
     Ok(())
 }
 
+/// Check if a deployment has soft reboot capability
+fn has_soft_reboot_capability(deployment: Option<&crate::spec::BootEntry>) -> bool {
+    deployment.map(|d| d.soft_reboot_capable).unwrap_or(false)
+}
+
+/// Prepare a soft reboot for the given deployment
+#[context("Preparing soft reboot")]
+fn prepare_soft_reboot(
+    sysroot: &crate::store::Storage,
+    deployment: &ostree::Deployment,
+) -> Result<()> {
+    let cancellable = ostree::gio::Cancellable::NONE;
+    sysroot
+        .sysroot
+        .deployment_set_soft_reboot(deployment, false, cancellable)
+        .context("Failed to prepare soft-reboot")?;
+    Ok(())
+}
+
+/// Perform a soft reboot for a staged deployment
+#[context("Soft reboot staged deployment")]
+fn soft_reboot_staged(sysroot: &crate::store::Storage) -> Result<()> {
+    println!("Staged deployment is soft-reboot capable, preparing for soft-reboot...");
+
+    let deployments_list = sysroot.deployments();
+    let staged_deployment = deployments_list
+        .iter()
+        .find(|d| d.is_staged())
+        .ok_or_else(|| anyhow::anyhow!("Failed to find staged deployment"))?;
+
+    prepare_soft_reboot(sysroot, staged_deployment)?;
+    Ok(())
+}
+
 /// A few process changes that need to be made for writing.
 /// IMPORTANT: This may end up re-executing the current process,
 /// so anything that happens before this should be idempotent.
@@ -859,7 +914,11 @@ async fn upgrade(opts: UpgradeOpts) -> Result<()> {
             .unwrap_or_default();
         if staged_unchanged {
             println!("Staged update present, not changed.");
-
+            if opts.queue_soft_reboot {
+                if has_soft_reboot_capability(host.status.staged.as_ref()) {
+                    soft_reboot_staged(sysroot)?;
+                }
+            }
             if opts.apply {
                 crate::reboot::reboot()?;
             }
@@ -881,6 +940,15 @@ async fn upgrade(opts: UpgradeOpts) -> Result<()> {
     if changed {
         sysroot.update_mtime()?;
 
+        if opts.queue_soft_reboot {
+            // At this point we have new staged deployment and the host definition has changed.
+            // We need the updated host status before we check if we can prepare the soft-reboot.
+            let updated_host = crate::status::get_status(sysroot, Some(&booted_deployment))?.1;
+            if has_soft_reboot_capability(updated_host.status.staged.as_ref()) {
+                soft_reboot_staged(sysroot)?;
+            }
+        }
+
         if opts.apply {
             crate::reboot::reboot()?;
         }
@@ -956,6 +1024,15 @@ async fn switch(opts: SwitchOpts) -> Result<()> {
 
     sysroot.update_mtime()?;
 
+    if opts.queue_soft_reboot {
+        // At this point we have staged the deployment and the host definition has changed.
+        // We need the updated host status before we check if we can prepare the soft-reboot.
+        let updated_host = crate::status::get_status(sysroot, Some(&booted_deployment))?.1;
+        if has_soft_reboot_capability(updated_host.status.staged.as_ref()) {
+            soft_reboot_staged(sysroot)?;
+        }
+    }
+
     if opts.apply {
         crate::reboot::reboot()?;
     }
@@ -969,6 +1046,22 @@ async fn rollback(opts: RollbackOpts) -> Result<()> {
     let sysroot = &get_storage().await?;
     crate::deploy::rollback(sysroot).await?;
 
+    if opts.queue_soft_reboot {
+        // Get status of rollback deployment to check soft-reboot capability
+        let host = crate::status::get_status_require_booted(sysroot)?.2;
+
+        if has_soft_reboot_capability(host.status.rollback.as_ref()) {
+            println!("Rollback deployment is soft-reboot capable, preparing for soft-reboot...");
+
+            let deployments_list = sysroot.deployments();
+            let target_deployment = deployments_list
+                .first()
+                .ok_or_else(|| anyhow::anyhow!("No rollback deployment found!"))?;
+
+            prepare_soft_reboot(sysroot, target_deployment)?;
+        }
+    }
+
     if opts.apply {
         crate::reboot::reboot()?;
     }

crates/lib/src/deploy.rs

@@ -577,10 +577,6 @@ async fn deploy(
                 &opts,
                 Some(cancellable),
             )?;
-            tracing::debug!(
-                "Soft reboot capable: {:?}",
-                sysroot.deployment_can_soft_reboot(&d)
-            );
             Ok(d.index())
         }),
     )

crates/lib/src/spec.rs

@@ -176,6 +176,9 @@ pub struct BootEntry {
     pub incompatible: bool,
     /// Whether this entry will be subject to garbage collection
     pub pinned: bool,
+    /// This is true if (relative to the booted system) this is a possible target for a soft reboot
+    #[serde(default)]
+    pub soft_reboot_capable: bool,
     /// The container storage backend
     #[serde(default)]
     pub store: Option<Store>,
@@ -517,6 +520,7 @@ mod tests {
                 image: None,
                 cached_update: None,
                 incompatible: false,
+                soft_reboot_capable: false,
                 pinned: false,
                 store: None,
                 ostree: None,

crates/lib/src/status.rs

@@ -86,6 +86,11 @@ impl From<ImageReference> for OstreeImageReference {
     }
 }
 
+/// Check if a deployment has soft reboot capability
+fn has_soft_reboot_capability(sysroot: &Storage, deployment: &ostree::Deployment) -> bool {
+    ostree_ext::systemd_has_soft_reboot() && sysroot.deployment_can_soft_reboot(deployment)
+}
+
 /// Parse an ostree origin file (a keyfile) and extract the targeted
 /// container image reference.
 fn get_image_origin(origin: &glib::KeyFile) -> Result<Option<OstreeImageReference>> {
@@ -144,10 +149,13 @@ fn boot_entry_from_deployment(
         (None, CachedImageStatus::default(), false)
     };
 
+    let soft_reboot_capable = has_soft_reboot_capability(sysroot, deployment);
+
     let r = BootEntry {
         image,
         cached_update,
         incompatible,
+        soft_reboot_capable,
         store,
         pinned: deployment.is_pinned(),
         ostree: Some(crate::spec::BootEntryOstree {
@@ -381,6 +389,27 @@ fn render_verbose_ostree_info(
     Ok(())
 }
 
+/// Helper function to render if soft-reboot capable
+fn write_soft_reboot(
+    mut out: impl Write,
+    entry: &crate::spec::BootEntry,
+    prefix_len: usize,
+) -> Result<()> {
+    // Show soft-reboot capability
+    write_row_name(&mut out, "Soft-reboot", prefix_len)?;
+    writeln!(
+        out,
+        "{}",
+        if entry.soft_reboot_capable {
+            "yes"
+        } else {
+            "no"
+        }
+    )?;
+
+    Ok(())
+}
+
 /// Write the data for a container image based status.
 fn human_render_slot(
     mut out: impl Write,
@@ -463,6 +492,9 @@ fn human_render_slot(
                 }
             }
         }
+
+        // Show soft-reboot capability
+        write_soft_reboot(&mut out, entry, prefix_len)?;
     }
 
     tracing::debug!("pinned={}", entry.pinned);
@@ -500,6 +532,9 @@ fn human_render_slot_ostree(
         if let Some(ostree) = &entry.ostree {
             render_verbose_ostree_info(&mut out, ostree, slot, prefix_len)?;
         }
+
+        // Show soft-reboot capability
+        write_soft_reboot(&mut out, entry, prefix_len)?;
     }
 
     tracing::debug!("pinned={}", entry.pinned);
@@ -721,5 +756,6 @@ mod tests {
         assert!(w.contains("Deploy serial:"));
         assert!(w.contains("Staged:"));
         assert!(w.contains("Commit:"));
+        assert!(w.contains("Soft-reboot:"));
     }
 }

crates/ostree-ext/src/lib.rs

@@ -78,3 +78,12 @@ pub mod prelude {
 pub mod fixture;
 #[cfg(feature = "internal-testing-api")]
 pub mod integrationtest;
+
+/// Check if the system has the soft reboot target, which signals
+/// systemd support for soft reboots.
+pub fn systemd_has_soft_reboot() -> bool {
+    const UNIT: &str = "/usr/lib/systemd/system/soft-reboot.target";
+    use std::sync::OnceLock;
+    static EXISTS: OnceLock<bool> = OnceLock::new();
+    *EXISTS.get_or_init(|| std::path::Path::new(UNIT).exists())
+}

tmt/plans/integration.fmf

@@ -62,3 +62,11 @@ execute:
     test:
         - /tmt/tests/bootc-install-provision
         - /tmt/tests/test-24-local-upgrade-reboot
+
+/test-25-soft-reboot:
+  summary: Soft reboot support
+  discover:
+    how: fmf
+    test:
+        - /tmt/tests/bootc-install-provision
+        - /tmt/tests/test-25-soft-reboot

tmt/tests/booted/test-soft-reboot.nu

@@ -0,0 +1,85 @@
+# Verify that soft reboot works (on by default)
+use std assert
+use tap.nu
+
+let soft_reboot_capable = "/usr/lib/systemd/system/soft-reboot.target" | path exists
+if not $soft_reboot_capable {
+    echo "Skipping, system is not soft reboot capable"
+    return
+}
+
+# This code runs on *each* boot.
+# Here we just capture information.
+bootc status
+
+# Run on the first boot
+def initial_build [] {
+    tap begin "local image push + pull + upgrade"
+
+    let td = mktemp -d
+    cd $td
+
+    bootc image copy-to-storage
+
+    # A simple derived container that adds a file, but also injects some kargs
+    "FROM localhost/bootc
+RUN echo test content > /usr/share/testfile-for-soft-reboot.txt
+" | save Dockerfile
+    # Build it
+    podman build -t localhost/bootc-derived .
+
+    assert (not ("/run/nextroot" | path exists))
+    
+    bootc switch --queue-soft-reboot --transport containers-storage localhost/bootc-derived
+    let st = bootc status --json | from json
+    assert $st.status.staged.softRebootCapable
+
+    assert ("/run/nextroot" | path exists)
+
+    #Let's reset the soft-reboot as we still can't correctly soft-reboot with tmt
+    ostree admin prepare-soft-reboot --reset
+    # https://tmt.readthedocs.io/en/stable/stories/features.html#reboot-during-test
+    tmt-reboot
+}
+
+# The second boot; verify we're in the derived image
+def second_boot [] {
+    assert ("/usr/share/testfile-for-soft-reboot.txt" | path exists)
+    #tmt-reboot seems not to be using systemd soft-reboot 
+    # and tmt-reboot -c "systemctl soft-reboot" is not connecting back
+    # let's comment this check.
+    #assert equal (systemctl show -P SoftRebootsCount) "1"
+
+    # A new derived with new kargs which should stop the soft reboot.
+    "FROM localhost/bootc
+RUN echo test content > /usr/share/testfile-for-soft-reboot.txt
+RUN echo 'kargs = ["foo1=bar2"]' | tee /usr/lib/bootc/kargs.d/00-foo1bar2.toml > /dev/null
+" | save Dockerfile
+    # Build it
+    podman build -t localhost/bootc-derived .
+
+    bootc update --queue-soft-reboot
+    let st = bootc status --json | from json
+    # Should not be soft-reboot capable because of kargs diff
+    assert (not $st.status.staged.softRebootCapable)
+
+    # And reboot into it
+    tmt-reboot
+}
+
+# The third boot; verify we're in the derived image
+def third_boot [] {
+    assert ("/usr/lib/bootc/kargs.d/00-foo1bar2.toml" | path exists)
+
+    assert equal (systemctl show -P SoftRebootsCount) "0"
+}
+
+def main [] {
+    # See https://tmt.readthedocs.io/en/stable/stories/features.html#reboot-during-test
+    match $env.TMT_REBOOT_COUNT? {
+        null | "0" => initial_build,
+        "1" => second_boot,
+        "2" => third_boot,
+        $o => { error make { msg: $"Invalid TMT_REBOOT_COUNT ($o)" } },
+    }
+}

tmt/tests/test-25-soft-reboot.fmf

@@ -0,0 +1,3 @@
+summary: Execute soft reboot test
+test: nu booted/test-soft-reboot.nu
+duration: 30m