Skip to content

Commit fff106e

Browse files
committed
store: Load previous state earlier
Prep for pull-by-digest noop. Signed-off-by: Colin Walters <[email protected]>
1 parent 94f82b4 commit fff106e

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

ostree-ext/src/container/store.rs

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -682,6 +682,8 @@ impl ImageImporter {
682682
_ => {}
683683
}
684684

685+
let previous_state = try_query_image(&self.repo, &self.imgref.imgref)?;
686+
685687
let proxy_img = self
686688
.proxy
687689
.open_image(&self.imgref.imgref.to_string())
@@ -693,22 +695,21 @@ impl ImageImporter {
693695

694696
// Query for previous stored state
695697

696-
let (previous_state, previous_imageid) =
697-
if let Some(previous_state) = try_query_image(&self.repo, &self.imgref.imgref)? {
698-
// If the manifest digests match, we're done.
699-
if previous_state.manifest_digest == manifest_digest {
700-
return Ok(PrepareResult::AlreadyPresent(previous_state));
701-
}
702-
// Failing that, if they have the same imageID, we're also done.
703-
let previous_imageid = previous_state.manifest.config().digest();
704-
if previous_imageid == new_imageid {
705-
return Ok(PrepareResult::AlreadyPresent(previous_state));
706-
}
707-
let previous_imageid = previous_imageid.to_string();
708-
(Some(previous_state), Some(previous_imageid))
709-
} else {
710-
(None, None)
711-
};
698+
let (previous_state, previous_imageid) = if let Some(previous_state) = previous_state {
699+
// If the manifest digests match, we're done.
700+
if previous_state.manifest_digest == manifest_digest {
701+
return Ok(PrepareResult::AlreadyPresent(previous_state));
702+
}
703+
// Failing that, if they have the same imageID, we're also done.
704+
let previous_imageid = previous_state.manifest.config().digest();
705+
if previous_imageid == new_imageid {
706+
return Ok(PrepareResult::AlreadyPresent(previous_state));
707+
}
708+
let previous_imageid = previous_imageid.to_string();
709+
(Some(previous_state), Some(previous_imageid))
710+
} else {
711+
(None, None)
712+
};
712713

713714
let config = self.proxy.fetch_config(&proxy_img).await?;
714715

0 commit comments

Comments
 (0)