Skip to content

Conversation

@ckyrouac
Copy link
Collaborator

This allows files with duplicate contents (and checksums) to be stored in different layers when using the rechunker.

@gemini-code-assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would frame this as "don't deduplicate by checksum with exclusive components" - right?

Doesn't it open the question a bit whether we should also stop doing that for non-exclusive?

I think that's OK for now, but probably worth noting.

Anyways just style nits

@ckyrouac
Copy link
Collaborator Author

Doesn't it open the question a bit whether we should also stop doing that for non-exclusive?

The way I've been thinking about it is when a user explicitly defines an exclusive component, the expectation is the files go exactly where they want. The package based rechunking is an automatic process that the user doesn't really control so it's less surprising when duplicate files are in the same layer. I'll add docs to explain this in a followup.

This allows files with duplicate contents (and checksums) to be stored
in different layers when using the rechunker.

Signed-off-by: ckyrouac <[email protected]>
@ckyrouac ckyrouac force-pushed the rechunker-duplicates branch from 243d001 to 72c3f9b Compare August 18, 2025 15:45
@ckyrouac ckyrouac marked this pull request as ready for review August 18, 2025 16:49
@ckyrouac ckyrouac merged commit 05030a3 into bootc-dev:main Aug 18, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants