log to journal if root #1589
Merged
log to journal if root #1589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have multiple places which are re-executing the current binary; one of those writes a temp file. Ensure that `argv0` in the new binary is `bootc` which means it should be used as e.g. a syslog identifier. Signed-off-by: Colin Walters <[email protected]>
This is expected the *first* time. Signed-off-by: Colin Walters <[email protected]>
The intention was to always log to the systemd journal, even if we're spawned directly on the CLI outside of a unit. Signed-off-by: Colin Walters <[email protected]>
|
After a ton of head scratching I figured out this soft requires tokio-rs/tracing#3372 |
What we really want to be clear is for the syslog identifier to be i.e. we want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to look at our journal logging and it didn't do what I expected.
The intention was to always log to the systemd journal,
even if we're spawned directly on the CLI outside of a unit.