-
Notifications
You must be signed in to change notification settings - Fork 149
test: Fix OSCI gating failure #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an OSCI gating failure by adapting the test environment setup for different CI systems and making the reboot process more robust. The changes in hack/Containerfile.packit and hack/provision-packit.sh correctly handle different locations for tmt scripts. The addition of timeouts in hack/packit-reboot.yml is a good improvement for CI stability. My review includes a few suggestions to clean up debugging commands left in the scripts and a minor shell scripting improvement.
| if [[ -d /var/lib/tmt/scripts ]]; then | ||
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | ||
| ls -al "${BOOTC_TEMPDIR}/scripts" | ||
| else | ||
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | ||
| ls -al "${BOOTC_TEMPDIR}/bin" | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ls -al commands on lines 27 and 30 seem to be for debugging. It's best to remove them to keep the script and its output clean.
| if [[ -d /var/lib/tmt/scripts ]]; then | |
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | |
| ls -al "${BOOTC_TEMPDIR}/scripts" | |
| else | |
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | |
| ls -al "${BOOTC_TEMPDIR}/bin" | |
| fi | |
| if [[ -d /var/lib/tmt/scripts ]]; then | |
| cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR" | |
| else | |
| cp -r /usr/local/bin "$BOOTC_TEMPDIR" | |
| fi |
|
|
||
| # Let's check things in hack folder | ||
| ls -al "$BOOTC_TEMPDIR" "${BOOTC_TEMPDIR}/bin" | ||
| ls -al "$BOOTC_TEMPDIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Xiaofeng Wang <[email protected]>
c31f58d to
e26c202
Compare
This PR fixed OSCI gating failure.