Skip to content

Conversation

@henrywang
Copy link
Collaborator

This PR fixed OSCI gating failure.

@bootc-bot bootc-bot bot requested a review from gursewak1997 November 5, 2025 01:38
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an OSCI gating failure by adapting the test environment setup for different CI systems and making the reboot process more robust. The changes in hack/Containerfile.packit and hack/provision-packit.sh correctly handle different locations for tmt scripts. The addition of timeouts in hack/packit-reboot.yml is a good improvement for CI stability. My review includes a few suggestions to clean up debugging commands left in the scripts and a minor shell scripting improvement.

Comment on lines 25 to 31
if [[ -d /var/lib/tmt/scripts ]]; then
cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR"
ls -al "${BOOTC_TEMPDIR}/scripts"
else
cp -r /usr/local/bin "$BOOTC_TEMPDIR"
ls -al "${BOOTC_TEMPDIR}/bin"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ls -al commands on lines 27 and 30 seem to be for debugging. It's best to remove them to keep the script and its output clean.

Suggested change
if [[ -d /var/lib/tmt/scripts ]]; then
cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR"
ls -al "${BOOTC_TEMPDIR}/scripts"
else
cp -r /usr/local/bin "$BOOTC_TEMPDIR"
ls -al "${BOOTC_TEMPDIR}/bin"
fi
if [[ -d /var/lib/tmt/scripts ]]; then
cp -r /var/lib/tmt/scripts "$BOOTC_TEMPDIR"
else
cp -r /usr/local/bin "$BOOTC_TEMPDIR"
fi


# Let's check things in hack folder
ls -al "$BOOTC_TEMPDIR" "${BOOTC_TEMPDIR}/bin"
ls -al "$BOOTC_TEMPDIR"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This ls command appears to be for debugging. It should be removed to keep the script's output clean.

@henrywang henrywang changed the title test: Fix OSCI gating failure [WIP] test: Fix OSCI gating failure Nov 5, 2025
Signed-off-by: Xiaofeng Wang <[email protected]>
@henrywang henrywang changed the title [WIP] test: Fix OSCI gating failure test: Fix OSCI gating failure Nov 5, 2025
@cgwalters cgwalters enabled auto-merge (rebase) November 5, 2025 12:32
@cgwalters cgwalters merged commit 73d08d9 into bootc-dev:main Nov 5, 2025
37 checks passed
@henrywang henrywang deleted the fix_osci_gating branch November 5, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants