Skip to content

Conversation

@cgwalters
Copy link
Collaborator

Renovate is currently failing because of the composefs-rs git submodule (trying to debug that) so we're behind. At least this one gets rid of multiple copies of rustix and an old toml version.

@bootc-bot bootc-bot bot requested a review from gursewak1997 November 7, 2025 19:32
Renovate is currently failing because of the composefs-rs git
submodule (trying to debug that) so we're behind. At least this
one gets rid of multiple copies of rustix and an old toml version.

Signed-off-by: Colin Walters <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's dependencies by running cargo update. The main benefit, as noted in the description, is the consolidation of dependencies, particularly rustix and toml, which now resolve to a single version across the workspace. This is a good improvement for maintenance and consistency.

I've reviewed the changes in Cargo.lock. The updates are mostly minor and patch version bumps, which are generally safe. I did notice a few major version bumps for transitive dependencies:

  • litrs updated from 0.4.2 to 1.0.0. This is a build-time dependency for documentation generation and is unlikely to cause issues.
  • The wasi dependency from getrandom has been updated and renamed to wasip2. Since this project targets Linux, this change for the WASI target should not have any impact.

Overall, the changes look good and align with the goal of keeping dependencies up-to-date and tidy. Assuming CI passes, this PR is good to merge.

Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Only thing I see is that we get a new deprecation warning:

warning: use of deprecated unit variant `rustix::thread::Capability::SystemAdmin`: Use CapabilitySet with a single bit instead
   --> crates/lib/src/cli.rs:743:83
    |
743 |         rustix::thread::capability_is_in_bounding_set(rustix::thread::Capability::SystemAdmin)?,
    |                                                                                   ^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: `bootc-lib` (lib) generated 1 warning

But that can be fixed in a followup.

@cgwalters cgwalters enabled auto-merge (rebase) November 7, 2025 20:38
@cgwalters cgwalters merged commit d596a32 into bootc-dev:main Nov 7, 2025
36 checks passed
@jeckersb
Copy link
Collaborator

👍

Only thing I see is that we get a new deprecation warning:

warning: use of deprecated unit variant `rustix::thread::Capability::SystemAdmin`: Use CapabilitySet with a single bit instead
   --> crates/lib/src/cli.rs:743:83
    |
743 |         rustix::thread::capability_is_in_bounding_set(rustix::thread::Capability::SystemAdmin)?,
    |                                                                                   ^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: `bootc-lib` (lib) generated 1 warning

But that can be fixed in a followup.

➡️ #1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants