Skip to content

Commit 612c965

Browse files
committed
Test that CI successfully fails
I think a good pattern is to keep an open (draft) pull request that *should* fail CI, and verify that it actually does. It's surprisingly easily to e.g. have CI not actually test the code. In this case we have our "reverse dependency testing" which patches the crate to use the local code, and that could easily not work.
1 parent 4c039d4 commit 612c965

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/imageproxy.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -376,11 +376,12 @@ impl ImageProxy {
376376
#[instrument]
377377
async fn finish_pipe(&self, pipeid: u32) -> Result<()> {
378378
tracing::debug!("closing pipe");
379-
let (r, fd) = self.impl_request("FinishPipe", [pipeid]).await?;
380-
if fd.is_some() {
381-
return Err(anyhow!("Unexpected fd in finish_pipe reply"));
382-
}
383-
Ok(r)
379+
anyhow::bail!("synthetic CI failure");
380+
//let (r, fd) = self.impl_request("FinishPipe", [pipeid]).await?;
381+
//if fd.is_some() {
382+
// return Err(anyhow!("Unexpected fd in finish_pipe reply"));
383+
//}
384+
//Ok(r)
384385
}
385386

386387
#[instrument]

0 commit comments

Comments
 (0)