test_frontend: split up into multiple classes

Author: bootc

tests/test_frontend.py

@@ -22,18 +22,18 @@
 from pypuppetdbquery import parse, query_facts
 
 
-class FakeNode(object):
+class _FakeNode(object):
     def __init__(self, node, name, value):
         self.node = node
         self.name = name
         self.value = value
 
 
-class TestFrontend(unittest.TestCase):
+class TestFrontendParse(unittest.TestCase):
     """
-    Test cases targetting :mod:`pypuppetdbquery`, and particularly
-    :func:`pypuppetdbquery.parse`.
+    Test cases targetting :func:`pypuppetdbquery.parse`.
     """
+
     def _parse(self, s, **kwargs):
         return parse(
             s,
@@ -48,19 +48,6 @@ def _parse(self, s, **kwargs):
             },
             **kwargs)
 
-    def _query_facts(self, pdb, s, facts=None, raw=False):
-        return query_facts(
-            pdb, s, facts, raw,
-            lex_options={
-                'debug': False,
-                'optimize': False,
-            },
-            yacc_options={
-                'debug': False,
-                'optimize': False,
-                'write_tables': False,
-            })
-
     def test_empty_queries(self):
         out = self._parse('')
         self.assertTrue(out is None)
@@ -87,10 +74,29 @@ def test_simple_raw(self):
                ['=', 'value', 'bar']]]]]
         self.assertEqual(out, expect)
 
+
+class TestFrontendQueryFacts(unittest.TestCase):
+    """
+    Test cases targetting :func:`pypuppetdbquery.query_facts`.
+    """
+
+    def _query_facts(self, pdb, s, facts=None, raw=False):
+        return query_facts(
+            pdb, s, facts, raw,
+            lex_options={
+                'debug': False,
+                'optimize': False,
+            },
+            yacc_options={
+                'debug': False,
+                'optimize': False,
+                'write_tables': False,
+            })
+
     def test_query_facts_with_query_and_facts_list(self):
         mock_pdb = mock.NonCallableMock()
         mock_pdb.facts = mock.Mock(return_value=[
-            FakeNode('alpha', 'foo', 'bar'),
+            _FakeNode('alpha', 'foo', 'bar'),
         ])
 
         node_facts = self._query_facts(mock_pdb, 'foo=bar', ['foo'])
@@ -113,7 +119,7 @@ def test_query_facts_with_query_and_facts_list(self):
     def test_query_facts_with_query_and_facts_list_regex(self):
         mock_pdb = mock.NonCallableMock()
         mock_pdb.facts = mock.Mock(return_value=[
-            FakeNode('alpha', 'foo', 'bar'),
+            _FakeNode('alpha', 'foo', 'bar'),
         ])
 
         node_facts = self._query_facts(mock_pdb, 'foo=bar', ['/foo/'])
@@ -136,7 +142,7 @@ def test_query_facts_with_query_and_facts_list_regex(self):
     def test_query_facts_with_facts_list_only(self):
         mock_pdb = mock.NonCallableMock()
         mock_pdb.facts = mock.Mock(return_value=[
-            FakeNode('alpha', 'foo', 'bar'),
+            _FakeNode('alpha', 'foo', 'bar'),
         ])
 
         node_facts = self._query_facts(mock_pdb, '', ['foo'])
@@ -156,7 +162,7 @@ def test_query_facts_without_query_or_facts(self):
     def test_query_facts_in_raw_mode(self):
         mock_pdb = mock.NonCallableMock()
         mock_pdb.facts = mock.Mock(return_value=[
-            FakeNode('alpha', 'foo', 'bar'),
+            _FakeNode('alpha', 'foo', 'bar'),
         ])
 
         node_facts = self._query_facts(mock_pdb, 'foo=bar', raw=True)