Rename variable max to maxIndex

bootjp · bootjp · commit 2ab2fb1242ab · 2025-12-29T16:35:01.000+09:00
diff --git a/kv/shard_router.go b/kv/shard_router.go
@@ -59,7 +59,7 @@ func (s *ShardRouter) process(reqs []*pb.Request, fn func(*routerGroup, []*pb.Re
 	}
 
 	var firstErr error
-	var max uint64
+	var maxIndex uint64
 	for gid, rs := range grouped {
 		g, ok := s.getGroup(gid)
 		if !ok {
@@ -72,14 +72,14 @@ func (s *ShardRouter) process(reqs []*pb.Request, fn func(*routerGroup, []*pb.Re
 			}
 			continue
 		}
-		if r.CommitIndex > max {
-			max = r.CommitIndex
+		if r.CommitIndex > maxIndex {
+			maxIndex = r.CommitIndex
 		}
 	}
 	if firstErr != nil {
 		return nil, firstErr
 	}
-	return &TransactionResponse{CommitIndex: max}, nil
+	return &TransactionResponse{CommitIndex: maxIndex}, nil
 }
 
 func (s *ShardRouter) getGroup(id uint64) (*routerGroup, bool) {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func (s ShardRouter) process(reqs []pb.Request, fn func(routerGroup, []pb.Re`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`var firstErr error`
`62`		`- var max uint64`
	`62`	`+ var maxIndex uint64`
`63`	`63`	`for gid, rs := range grouped {`
`64`	`64`	`g, ok := s.getGroup(gid)`
`65`	`65`	`if !ok {`
`@@ -72,14 +72,14 @@ func (s ShardRouter) process(reqs []pb.Request, fn func(routerGroup, []pb.Re`
`72`	`72`	`}`
`73`	`73`	`continue`
`74`	`74`	`}`
`75`		`- if r.CommitIndex > max {`
`76`		`- max = r.CommitIndex`
	`75`	`+ if r.CommitIndex > maxIndex {`
	`76`	`+ maxIndex = r.CommitIndex`
`77`	`77`	`}`
`78`	`78`	`}`
`79`	`79`	`if firstErr != nil {`
`80`	`80`	`return nil, firstErr`
`81`	`81`	`}`
`82`		`- return &TransactionResponse{CommitIndex: max}, nil`
	`82`	`+ return &TransactionResponse{CommitIndex: maxIndex}, nil`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`func (s ShardRouter) getGroup(id uint64) (routerGroup, bool) {`