Fix error handling for missing keys in stores

bootjp · bootjp · commit fbef0780c96e · 2025-12-24T01:33:38.000+09:00
diff --git a/store/bolt_store_test.go b/store/bolt_store_test.go
@@ -34,9 +34,8 @@ func TestBoltStore(t *testing.T) {
 		assert.Equal(t, []byte("bar"), res)
 		assert.NoError(t, st.Delete(ctx, key))
 		// bolt store does not support NotFound
-		res, err = st.Get(ctx, []byte("aaaaaa"))
-		assert.NoError(t, err)
-		assert.Nil(t, res)
+		_, err = st.Get(ctx, []byte("aaaaaa"))
+		assert.Equal(t, err, ErrKeyNotFound)
 	}
 }
 
diff --git a/store/rb_memory_store.go b/store/rb_memory_store.go
@@ -85,7 +85,7 @@ func (s *rbMemoryStore) Get(ctx context.Context, key []byte) ([]byte, error) {
 
 	vv, ok := v.([]byte)
 	if !ok {
-		return nil, errors.WithStack(ErrKeyNotFound)
+		return nil, ErrKeyNotFound
 	}
 
 	return vv, nil

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,8 @@ func TestBoltStore(t *testing.T) {`
`34`	`34`	`assert.Equal(t, []byte("bar"), res)`
`35`	`35`	`assert.NoError(t, st.Delete(ctx, key))`
`36`	`36`	`// bolt store does not support NotFound`
`37`		`- res, err = st.Get(ctx, []byte("aaaaaa"))`
`38`		`- assert.NoError(t, err)`
`39`		`- assert.Nil(t, res)`
	`37`	`+ _, err = st.Get(ctx, []byte("aaaaaa"))`
	`38`	`+ assert.Equal(t, err, ErrKeyNotFound)`
`40`	`39`	`}`
`41`	`40`	`}`
`42`	`41`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func (s *rbMemoryStore) Get(ctx context.Context, key []byte) ([]byte, error) {`
`85`	`85`
`86`	`86`	`vv, ok := v.([]byte)`
`87`	`87`	`if !ok {`
`88`		`- return nil, errors.WithStack(ErrKeyNotFound)`
	`88`	`+ return nil, ErrKeyNotFound`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`return vv, nil`