Skip to content

Commit c72b6cf

Browse files
author
ehowlsla
committed
통계 버그 수정
1 parent 9a4c811 commit c72b6cf

File tree

5 files changed

+35
-29
lines changed

5 files changed

+35
-29
lines changed

bootpay/src/main/java/kr/co/bootpay/BootpayAnalytics.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@
33
import android.content.Context;
44
import android.support.annotation.NonNull;
55

6+
import java.util.ArrayList;
7+
import java.util.List;
8+
69
import kr.co.bootpay.analytics.BootpayAnalyticsPresenter;
710
import kr.co.bootpay.enums.Gender;
11+
import kr.co.bootpay.model.StatItem;
812
import kr.co.bootpay.pref.UserInfo;
913
import kr.co.bootpay.secure.SecurePreference;
1014

@@ -127,17 +131,13 @@ public static void login(
127131
}
128132

129133

130-
public static void start(@NonNull String url) {
131-
start(url, "", "", "", "");
134+
public static void start() {
135+
start(new ArrayList<StatItem>());
132136
}
133137

134-
public static void start(@NonNull String url,
135-
@NonNull String page_type,
136-
@NonNull String imageUrl,
137-
@NonNull String itemUnique,
138-
@NonNull String itemName) {
138+
public static void start(@NonNull List<StatItem> items) {
139139
if (presenter == null) throw new IllegalStateException("Analytics is not initialized.");
140-
else presenter.call(url, page_type, imageUrl, itemUnique, itemName);
140+
else presenter.call(items);
141141
}
142142
}
143143

bootpay/src/main/java/kr/co/bootpay/analytics/BootpayAnalyticsPresenter.kt

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package kr.co.bootpay.analytics
22

33
import android.content.Context
44
import android.util.Log
5+
import kr.co.bootpay.model.StatItem
56
import kr.co.bootpay.pref.UserInfo
67
import rx.Scheduler
78
import rx.schedulers.Schedulers
@@ -35,21 +36,17 @@ internal class BootpayAnalyticsPresenter(context: Context) {
3536
}, Throwable::printStackTrace)
3637
}
3738

38-
fun call(url: String?, page_type: String?, imageUrl: String?, itemUnique: String?, itemName: String?) {
39+
fun call(items: MutableList<StatItem>) {
3940
rest.api.call(
4041
UserInfo.bootpay_application_id,
4142
UserInfo.bootpay_uuid,
42-
url ?: "",
43-
page_type ?: "",
44-
imageUrl ?: "",
45-
itemUnique ?: "",
46-
itemName ?: "",
43+
items,
4744
UserInfo.bootpay_sk,
4845
UserInfo.bootpay_user_id,
4946
"")
5047
.subscribeOn(executor)
5148
.subscribe({
52-
Log.d("BootpayAnalytics", url)
49+
Log.d("BootpayAnalytics", "call")
5350
}, Throwable::printStackTrace)
5451
}
5552

bootpay/src/main/java/kr/co/bootpay/analytics/RestApi.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package kr.co.bootpay.analytics
22

3+
import kr.co.bootpay.model.StatItem
34
import retrofit2.http.Field
45
import retrofit2.http.FormUrlEncoded
56
import retrofit2.http.POST
@@ -24,11 +25,7 @@ internal interface RestApi {
2425
fun call(
2526
@Field("application_id") applicationId: String,
2627
@Field("uuid") uuid: String,
27-
@Field("url") url: String,
28-
@Field("page_type") pageType: String,
29-
@Field("img") imageUrl: String,
30-
@Field("unique") itemUnique: String,
31-
@Field("item_name") itemName: String,
28+
@Field("items") items: MutableList<StatItem>,
3229
@Field("sk") sk: String,
3330
@Field("user_id") userId: String,
3431
@Field("referer") referer: String
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package kr.co.bootpay.model
2+
3+
class StatItem(
4+
val item_name: String,
5+
val item_img: String,
6+
val unique: String,
7+
val cat1: String,
8+
val cat2: String,
9+
val cat3: String
10+
)

sample/src/main/java/bootpay/co/kr/samplepayment/MainActivity.java

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
import android.util.Log;
77
import android.view.View;
88

9+
import java.util.ArrayList;
10+
import java.util.List;
11+
912
import kr.co.bootpay.BootpayAnalytics;
1013
import kr.co.bootpay.Bootpay;
1114
import kr.co.bootpay.CancelListener;
@@ -14,6 +17,7 @@
1417
import kr.co.bootpay.ErrorListener;
1518
import kr.co.bootpay.enums.Method;
1619
import kr.co.bootpay.enums.PG;
20+
import kr.co.bootpay.model.StatItem;
1721

1822
public class MainActivity extends AppCompatActivity {
1923

@@ -24,7 +28,7 @@ protected void onCreate(Bundle savedInstanceState) {
2428
super.onCreate(savedInstanceState);
2529
setContentView(R.layout.activity_main);
2630

27-
// 초기설정 - 해당 프로젝트(안드로이드)의 application id 값을 설정합니다. 통계를 위해 꼭 필요합니다.
31+
// 초기설정 - 해당 프로젝트(안드로이드)의 application id 값을 설정합니다. 결제와 통계를 위해 꼭 필요합니다.
2832
BootpayAnalytics.init(this, "59a7e647396fa64fcad4a8c2");
2933
// BootpayAnalytics.init(this, "59bfc733e13f337dbd6ca489");
3034

@@ -42,12 +46,10 @@ protected void onCreate(Bundle savedInstanceState) {
4246

4347
public void onClick_request(View v) {
4448
// 통계 - 페이지 추적
45-
BootpayAnalytics.start(
46-
"item_list", // 페이지를 구분하는 주소
47-
"아이템", // 페이지 유형|카테고리|태그
48-
"", // 대표 상품 이미지 url
49-
"1", // 대표 상품의 고유 키
50-
"철산동핫도그"); // 대표 상품명
49+
List<StatItem> items = new ArrayList<>();
50+
items.add(new StatItem("마우스", "https://image.mouse.com/1234", "ITEM_CODE_MOUSE", "", "", ""));
51+
items.add(new StatItem("키보드", "https://image.keyboard.com/12345", "ITEM_CODE_KEYBOARD", "패션", "여성상의", "블라우스"));
52+
BootpayAnalytics.start(items);
5153

5254
// 결제호출
5355
Bootpay.init(getFragmentManager())
@@ -58,8 +60,8 @@ public void onClick_request(View v) {
5860
.setName("맥북프로임다") // 결제할 상품명
5961
.setOrderId("1234") // 결제 고유번호
6062
.setPrice(1000) // 결제할 금액
61-
.addItem("마우스", 1, "123", 100) // 주문정보에 담길 상품정보, 통계를 위해 사용
62-
.addItem("키보드", 1, "122", 200, "패션", "여성상의", "블라우스") // 주문정보에 담길 상품정보, 통계를 위해 사용
63+
.addItem("마우스", 1, "ITEM_CODE_MOUSE", 100) // 주문정보에 담길 상품정보, 통계를 위해 사용
64+
.addItem("키보드", 1, "ITEM_CODE_KEYBOARD", 200, "패션", "여성상의", "블라우스") // 주문정보에 담길 상품정보, 통계를 위해 사용
6365
.onConfirm(new ConfirmListener() { // 결제가 진행되기 바로 직전 호출되는 함수로, 주로 재고처리 등의 로직이 수행
6466
@Override
6567
public void onConfirmed(@Nullable String message) {

0 commit comments

Comments
 (0)