Skip to content

Commit 29ca4c9

Browse files
committed
_BPCWebViewCLS undefined symbol bug fixed
1 parent 94c0017 commit 29ca4c9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

apple/BPCWebView.mm

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
using namespace facebook::react;
1414

15-
auto BPStringToOnShouldStartLoadWithRequestNavigationTypeEnum(std::string value) {
15+
auto BPCSringToOnShouldStartLoadWithRequestNavigationTypeEnum(std::string value) {
1616
if (value == "click") return BPCWebViewEventEmitter::OnShouldStartLoadWithRequestNavigationType::Click;
1717
if (value == "formsubmit") return BPCWebViewEventEmitter::OnShouldStartLoadWithRequestNavigationType::Formsubmit;
1818
if (value == "backforward") return BPCWebViewEventEmitter::OnShouldStartLoadWithRequestNavigationType::Backforward;
@@ -21,7 +21,7 @@ auto BPStringToOnShouldStartLoadWithRequestNavigationTypeEnum(std::string value)
2121
return BPCWebViewEventEmitter::OnShouldStartLoadWithRequestNavigationType::Other;
2222
}
2323

24-
auto BPStringToOnLoadingStartNavigationTypeEnum(std::string value) {
24+
auto BPCStringToOnLoadingStartNavigationTypeEnum(std::string value) {
2525
if (value == "click") return BPCWebViewEventEmitter::OnLoadingStartNavigationType::Click;
2626
if (value == "formsubmit") return BPCWebViewEventEmitter::OnLoadingStartNavigationType::Formsubmit;
2727
if (value == "backforward") return BPCWebViewEventEmitter::OnLoadingStartNavigationType::Backforward;
@@ -30,7 +30,7 @@ auto BPStringToOnLoadingStartNavigationTypeEnum(std::string value) {
3030
return BPCWebViewEventEmitter::OnLoadingStartNavigationType::Other;
3131
}
3232

33-
auto BPStringToOnLoadingFinishNavigationTypeEnum(std::string value) {
33+
auto BPCStringToOnLoadingFinishNavigationTypeEnum(std::string value) {
3434
if (value == "click") return BPCWebViewEventEmitter::OnLoadingFinishNavigationType::Click;
3535
if (value == "formsubmit") return BPCWebViewEventEmitter::OnLoadingFinishNavigationType::Formsubmit;
3636
if (value == "backforward") return BPCWebViewEventEmitter::OnLoadingFinishNavigationType::Backforward;
@@ -81,7 +81,7 @@ - (instancetype)initWithFrame:(CGRect)frame
8181
.url = std::string([[dictionary valueForKey:@"url"] UTF8String]),
8282
.lockIdentifier = [[dictionary valueForKey:@"lockIdentifier"] doubleValue],
8383
.title = std::string([[dictionary valueForKey:@"title"] UTF8String]),
84-
.navigationType = BPStringToOnShouldStartLoadWithRequestNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String])),
84+
.navigationType = BPCStringToOnShouldStartLoadWithRequestNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String])),
8585
.canGoBack = static_cast<bool>([[dictionary valueForKey:@"canGoBack"] boolValue]),
8686
.canGoForward = static_cast<bool>([[dictionary valueForKey:@"canGoForward"] boolValue]),
8787
.isTopFrame = static_cast<bool>([[dictionary valueForKey:@"isTopFrame"] boolValue]),
@@ -98,7 +98,7 @@ - (instancetype)initWithFrame:(CGRect)frame
9898
.url = std::string([[dictionary valueForKey:@"url"] UTF8String]),
9999
.lockIdentifier = [[dictionary valueForKey:@"lockIdentifier"] doubleValue],
100100
.title = std::string([[dictionary valueForKey:@"title"] UTF8String]),
101-
.navigationType = BPStringToOnLoadingStartNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String])),
101+
.navigationType = BPCStringToOnLoadingStartNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String])),
102102
.canGoBack = static_cast<bool>([[dictionary valueForKey:@"canGoBack"] boolValue]),
103103
.canGoForward = static_cast<bool>([[dictionary valueForKey:@"canGoForward"] boolValue]),
104104
.loading = static_cast<bool>([[dictionary valueForKey:@"loading"] boolValue]),
@@ -146,7 +146,7 @@ - (instancetype)initWithFrame:(CGRect)frame
146146
.url = std::string([[dictionary valueForKey:@"url"] UTF8String]),
147147
.lockIdentifier = [[dictionary valueForKey:@"lockIdentifier"] doubleValue],
148148
.title = std::string([[dictionary valueForKey:@"title"] UTF8String]),
149-
.navigationType = BPStringToOnLoadingFinishNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String], [[dictionary valueForKey:@"navigationType"] lengthOfBytesUsingEncoding:NSUTF8StringEncoding])),
149+
.navigationType = BPCStringToOnLoadingFinishNavigationTypeEnum(std::string([[dictionary valueForKey:@"navigationType"] UTF8String], [[dictionary valueForKey:@"navigationType"] lengthOfBytesUsingEncoding:NSUTF8StringEncoding])),
150150
.canGoBack = static_cast<bool>([[dictionary valueForKey:@"canGoBack"] boolValue]),
151151
.canGoForward = static_cast<bool>([[dictionary valueForKey:@"canGoForward"] boolValue]),
152152
.loading = static_cast<bool>([[dictionary valueForKey:@"loading"] boolValue]),

apple/BPCWebViewModule.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ @implementation BPCWebViewModule
2323

2424
#ifdef RCT_NEW_ARCH_ENABLED
2525
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params {
26-
return std::make_shared<facebook::react::NativeBPCWebViewModuleSpecJSI>(params);
26+
return std::make_shared<facebook::react::NativeRNCWebViewModuleSpecJSI>(params);
2727
}
2828
#endif /* RCT_NEW_ARCH_ENABLED */
2929

0 commit comments

Comments
 (0)