Skip to content

Commit 9ca8944

Browse files
committed
Remove unnecessary change to config
1 parent 6cab142 commit 9ca8944

File tree

5 files changed

+10
-19
lines changed

5 files changed

+10
-19
lines changed

lib/bootstrap_form.rb

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@ def eager_load!
2626
BootstrapForm::Inputs.eager_load!
2727
end
2828

29-
def config
30-
deprecator.warn(<<~MESSAGE.squish)
31-
BootstrapForm.config will be removed in a future release.
32-
Please use BootstrapForm.configuration instead.
33-
MESSAGE
34-
35-
configuration
36-
end
37-
3829
def deprecator
3930
@deprecator ||= ActiveSupport::Deprecation.new("a future release", "BootstrapForm")
4031
end

lib/bootstrap_form/configuration.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ def default_form_attributes=(attributes)
99
when Hash
1010
BootstrapForm.deprecator.warn(<<~MESSAGE.squish)
1111
BootstrapForm::Configuration#default_form_attributes= will be removed in a future release.
12-
Please use Rails.application.config.bootstrap_form.default_form_attributes= instead.
12+
Please use BootstrapForm.config.default_form_attributes= instead.
1313
MESSAGE
1414
@default_form_attributes = attributes
15-
Rails.application.config.bootstrap_form.default_form_attributes = attributes
15+
BootstrapForm.config.default_form_attributes = attributes
1616
else
1717
raise ArgumentError, "Unsupported default_form_attributes #{attributes.inspect}"
1818
end
@@ -21,17 +21,17 @@ def default_form_attributes=(attributes)
2121
def default_form_attributes
2222
BootstrapForm.deprecator.warn(<<~MESSAGE.squish)
2323
BootstrapForm::Configuration#default_form_attributes will be removed in a future release.
24-
Please use Rails.application.config.bootstrap_form.default_form_attributes instead.
24+
Please use BootstrapForm.config.default_form_attributes instead.
2525
MESSAGE
26-
Rails.application.config.bootstrap_form.default_form_attributes
26+
BootstrapForm.config.default_form_attributes
2727
end
2828
end
2929

30-
mattr_accessor :configuration, default: ActiveSupport::OrderedOptions.new
30+
mattr_accessor :config, default: ActiveSupport::OrderedOptions.new
3131

3232
class << self
3333
def configure
34-
yield(configuration) if block_given?
34+
yield(config) if block_given?
3535
end
3636
end
3737
end

lib/bootstrap_form/engine.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class Engine < Rails::Engine
77
config.eager_load_namespaces << BootstrapForm
88
config.autoload_paths << File.expand_path("lib", __dir__)
99

10-
config.bootstrap_form = BootstrapForm.configuration
10+
config.bootstrap_form = BootstrapForm.config
1111
config.bootstrap_form.default_form_attributes ||= {}
1212

1313
initializer "bootstrap_form.deprecator" do |app|

lib/bootstrap_form/form_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def initialize(object_name, object, template, options)
7171

7272
def add_default_form_attributes_and_form_inline(options)
7373
options[:html] ||= {}
74-
options[:html].reverse_merge!(BootstrapForm.configuration.default_form_attributes)
74+
options[:html].reverse_merge!(BootstrapForm.config.default_form_attributes)
7575

7676
return unless options[:layout] == :inline
7777

test/bootstrap_form_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ def warn(message, ...)
377377
end
378378

379379
test "allows to set blank default form attributes via configuration" do
380-
BootstrapForm.configuration.stubs(:default_form_attributes).returns({})
380+
BootstrapForm.config.stubs(:default_form_attributes).returns({})
381381
expected = <<~HTML
382382
<form accept-charset="UTF-8" action="/users" class="new_user" id="new_user" method="post">
383383
</form>
@@ -386,7 +386,7 @@ def warn(message, ...)
386386
end
387387

388388
test "allows to set custom default form attributes via configuration" do
389-
BootstrapForm.configuration.stubs(:default_form_attributes).returns(foo: "bar")
389+
BootstrapForm.config.stubs(:default_form_attributes).returns(foo: "bar")
390390
expected = <<~HTML
391391
<form accept-charset="UTF-8" action="/users" class="new_user" foo="bar" id="new_user" method="post">
392392
</form>

0 commit comments

Comments
 (0)