Skip to content

Commit 1c0bf36

Browse files
authored
remove handwritten bash/zsh shell completions, fixes #9178
Remove the handwritten bash and zsh shell completion scripts now that auto-generated completions via borg completion bash/zsh (powered by shtab, #9172) are tested and working. Fish completions are kept as shtab does not yet support fish. Replace string-matching tests with focused behavior tests: script size sanity, shell syntax validation (bash -n / zsh -n), and tests that invoke the custom preamble functions in bash (sortby key dedup, filescachemode mutual exclusivity, archive name and aid: prefix completion against a real repository).
1 parent a4bfc18 commit 1c0bf36

File tree

5 files changed

+179
-1852
lines changed

5 files changed

+179
-1852
lines changed

docs/changes.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,15 @@ Fixes:
167167

168168
Other changes:
169169

170+
- remove handwritten bash and zsh shell completions, #9178.
171+
these are now auto-generated via ``borg completion bash/zsh`` (using shtab).
172+
fish completions are kept until shtab gains fish support.
170173
- mount: warn about symlinks pointing outside of the mountpoint, #9254
171174
- Version: do not access private attributes, #9263
172175
- tests / CI:
173176

177+
- completion: focused tests for auto-generated shell completions
178+
(syntax validation, size sanity, borg-specific preamble behavior)
174179
- fix and re-enable Windows CI (some tests are skipped on Windows)
175180
- CI: faster with borg-dir/borg.exe, #9236
176181
- fix mismatch in xattr test, #9238

scripts/shell_completions/bash/borg

Lines changed: 0 additions & 223 deletions
This file was deleted.

0 commit comments

Comments
 (0)