windows: implement st_birthtime restoration, fixes #8730#9341
Open
trxvorr wants to merge 1 commit intoborgbackup:masterfrom
Open
windows: implement st_birthtime restoration, fixes #8730#9341trxvorr wants to merge 1 commit intoborgbackup:masterfrom
trxvorr wants to merge 1 commit intoborgbackup:masterfrom
Conversation
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
from
d6dbc75 to
2f50ad0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9341 +/- ##
==========================================
- Coverage 76.50% 76.48% -0.03%
==========================================
Files 85 85
Lines 14818 14826 +8
Branches 2214 2215 +1
==========================================
+ Hits 11337 11339 +2
- Misses 2803 2809 +6
Partials 678 678 ☔ View full report in Codecov by Sentry. |
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
6 times, most recently
from
9b57619 to
a1face0
Compare
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
4 times, most recently
from
55000f7 to
91be6ae
Compare
Member
|
Please update your local master branch and then rebase this branch onto that master and force push. That should solve the CI test failures that are unrelated to your work. |
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
3 times, most recently
from
bccac20 to
ac834f1
Compare
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
7 times, most recently
from
9dac1c1 to
92d9236
Compare
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
2 times, most recently
from
af89193 to
b54336a
Compare
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
5 times, most recently
from
504fd15 to
ac40448
Compare
trxvorr
force-pushed
the
fix-8730-win-birthtime
branch
from
ac40448 to
bb3cb35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the restoration of file creation time (
st_birthtime) on Windows, addressing Issue #8730.Changes
ctypesandSetFileTimeto precisely set creation time on NTFS.Archive.restore_attrsto call set_birthtime on Windows when birthtime metadata is present.win32_birthtime_test.py) and E2E (win32_birthtime_e2e_test.py) tests verifying birthtime preservation.st_birthtime!=st_mtimesemantics).Verification