Skip to content

"Abort or break the lock" buttons are unnecessarily (possibly dangerously) confusing #2315

@cincodenada

Description

@cincodenada

Description

The prompt when attempting to run a command against a locked repo ends "Abort or break the lock?" and then the buttons are "Abort" and "Continue". While the lead-in is very helpful in steering towards the correct reading, I was less certain about it than I wanted to be which button did what, especially for a decision that was potentially disastrous.

I think tweaking the button text would help a lot. Since the call to action is "Abort or break the lock", making the buttons be "Abort" and "Break the lock" seems the simplest to me, I think, and removes the ambiguity. Crucially, it makes it unambiguous that clicking that button will do the scary thing that the dialog recommends against.

But there are obviously many options (and "Abort or break the lock?" hints that there may have already been revisions here!) but as a secondary tweak: I think using "Abort" in relation to a process that hasn't actually started yet (in any meaningful way, anyway) is stronger than it needs to be, and is necessarily "scary", especially if it's the action we're trying to steer the user towards. Thus, an additional tweak could be toning that down to "Cancel" (both in "Cancel or break the lock", and on the button itself). Or even "Nevermind", although that is more colloquial and perhaps more annoying to localize.

I realize this may sound very nitpicky, but UX is so crucial especially when presenting the user with potentially-disastrous choices, and I think making this as clear as possible is important.

Happy to open a PR for this if folks are on board!

Background

I absentmindedly tried to run a diff while my repo was busy doing other things, and Vorta popped up a very nice dialog box with a clear explanation - but then the action buttons for that dialog that gave me pause.

While my takeaway after re-reading was that "Abort" means "abort the diff, leave the lock alone" and "Continue" meant "continue with the diff, break the lock", my initial read was just confusion. I think that's mainly because of the connotations: "Continue" is a fairly neutral word used, in this case, for a very dangerous action; "Abort" is generally a "big deal" scary word, used here for the neutral, safe, and recommended action. Because of those connotations, I hesitated: what if "Abort" meant aborting the remote process (and breaking the lock), and "Continue" meant "never mind, let the remote process continue, I don't need to run a diff right now"?

To be clear: I realize this is not the straightforward reading. I was in fact certain enough in my reading to (correctly, thankfully) press "Abort" despite it being the scarier word. But: there is enough atrocious UX in this world that there was some lingering uncertainty, and I've been bitten by enough similar situations that it gave me pause and I held my breath a bit. Other software has absolutely presented me with similar dialogs where "Abort" was indeed the disastrous choice, despite other indications. I should be holding my breath when breaking the lock, not when I am cancelling my trivial diff, and I think even clearer wording would have saved me the anxiety here :)

Also, thank you for this project! I've been meaning to get backups running for ages, and have bounced off borg a couple times in attempting, but I found Vorta yesterday and it was the missing piece. It made getting everything set up SO much easier, while still giving me the information and control I want as a power user. Excellent work!

Reproduction

  • I tried to reproduce the issue.
  • I was able to reproduce the issue.

OS

Ubuntu 25.04, xfce

Version of Vorta

Vorta 0.10.3

What did you install Vorta with?

Distribution package

Version of Borg

Borg 1.4.0

Logs

2025-12-15 10:44:37,089 - vorta.borg.borg_job - INFO - Running command /usr/bin/borg diff --remote-path=borg14 --info --log-json --json-lines ssh://[user]@[repo]/./borg::[hostname]-2025-12-14-214007 [hostname]-2025-12-15-004033
2025-12-15 10:44:37,623 - vorta.borg.borg_job - WARNING - Remote: Host key fingerprint is SHA256:[snip]
2025-12-15 10:44:37,624 - vorta.borg.borg_job - WARNING - Remote: +---[ECDSA 256]---+
[snip, I know it's not _actually_ sensitive, but, why add the noise]
2025-12-15 10:44:37,626 - vorta.borg.borg_job - WARNING - Remote: +----[SHA256]-----+
2025-12-15 10:44:40,524 - vorta.borg.borg_job - ERROR - Failed to create/acquire the lock /data3/home/de1834/borg/lock.exclusive (timeout).
2025-12-15 10:44:40,741 - vorta.borg.jobs_manager - DEBUG - Finish job for site: 1
2025-12-15 10:44:40,743 - vorta.borg.jobs_manager - DEBUG - No more jobs for site: 1

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:enhancementImprovement of an existing function

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions