feat: Enhance OTA upgrade process with cancellation functionality and online status check

Author: oldrev

client/lib/devices/borneo/lyfi/views/settings_screen.dart

@@ -268,6 +268,7 @@ class SettingsScreen extends StatelessWidget {
     final otaVm = DeviceOtaViewModel(
       otaProvider: context.read<OtaProvider>(),
       boundDevice: bound,
+      isOnlineProvider: () => svm.isOnline,
       eventBus: context.read<EventBus>(),
       gt: context.read<GettextLocalizations>(),
       logger: context.read<Logger>(),

client/lib/devices/view_models/device_ota_view_model.dart

@@ -1,10 +1,10 @@
 import 'dart:async';
 
 import 'package:borneo_app/core/events/app_events.dart';
+import 'package:cancellation_token/cancellation_token.dart';
 import 'package:flutter/foundation.dart';
 import 'package:borneo_app/core/services/devices/ota_providers.dart';
 import 'package:borneo_kernel_abstractions/models/bound_device.dart';
-import 'package:cancellation_token/cancellation_token.dart';
 import 'package:event_bus/event_bus.dart';
 
 import '../../shared/view_models/base_view_model.dart';
@@ -15,6 +15,10 @@ class DeviceOtaViewModel extends BaseViewModel with ViewModelEventBusMixin {
   final OtaProvider otaProvider;
   final BoundDevice boundDevice;
 
+  /// Returns whether the device is currently reachable.
+  /// Provided as a callback so the getter stays live after construction.
+  final bool Function() _isOnlineProvider;
+
   OtaState _state = OtaState.idle;
   OtaState get state => _state;
 
@@ -35,19 +39,25 @@ class DeviceOtaViewModel extends BaseViewModel with ViewModelEventBusMixin {
 
   bool get canCheck => _state != OtaState.checking && _state != OtaState.upgrading;
 
-  bool get canUpgrade => _state == OtaState.updateAvailable && (_upgradeInfo?.canUpgrade ?? false);
+  bool get isOnline => _isOnlineProvider();
+
+  bool get canUpgrade => isOnline && _state == OtaState.updateAvailable && (_upgradeInfo?.canUpgrade ?? false);
 
   /// In debug builds the user can force-push firmware even when already up to date.
   bool get canForceUpgrade =>
-      kDebugMode && _upgradeInfo != null && (_state == OtaState.upToDate || _state == OtaState.updateAvailable);
+      kDebugMode &&
+      isOnline &&
+      _upgradeInfo != null &&
+      (_state == OtaState.upToDate || _state == OtaState.updateAvailable);
 
   DeviceOtaViewModel({
     required this.otaProvider,
     required this.boundDevice,
+    required bool Function() isOnlineProvider,
     required EventBus eventBus,
     required super.gt,
     super.logger,
-  }) {
+  }) : _isOnlineProvider = isOnlineProvider {
     super.globalEventBus = eventBus;
   }
 
@@ -84,13 +94,23 @@ class DeviceOtaViewModel extends BaseViewModel with ViewModelEventBusMixin {
       await service.upgrade(boundDevice, cancelToken: _cancelToken, force: force);
       if (isDisposed) return;
       _setState(OtaState.success);
+    } on CancelledException {
+      if (isDisposed) return;
+      // Restore to updateAvailable so the user can retry
+      _setState(_upgradeInfo?.canUpgrade == true ? OtaState.updateAvailable : OtaState.upToDate);
     } catch (e, st) {
       _errorMessage = e.toString();
       _setState(OtaState.error);
       logger?.e('OTA upgrade failed', error: e, stackTrace: st);
     }
   }
 
+  /// Cancels an in-progress upgrade.
+  void cancelUpgrade() {
+    if (!isUpgrading) return;
+    _cancelToken?.cancel();
+  }
+
   void _setState(OtaState newState) {
     _state = newState;
     if (!isDisposed) notifyListeners();

client/lib/devices/views/device_ota_screen.dart

@@ -116,8 +116,8 @@ class _DeviceOtaScreenState extends State<DeviceOtaScreen> with TickerProviderSt
                   'Firmware update is in progress. Interrupting the update may permanently damage the device. Are you sure you want to abort?',
                 ),
               );
-              if (confirmed && context.mounted) {
-                Navigator.of(context).pop();
+              if (confirmed) {
+                vm.cancelUpgrade();
               }
             },
             child: Scaffold(
@@ -418,7 +418,20 @@ class _DeviceOtaScreenState extends State<DeviceOtaScreen> with TickerProviderSt
     if (vm.isUpgrading) {
       return SizedBox(
         width: double.infinity,
-        child: FilledButton.tonal(onPressed: null, child: Text(context.translate('Updating...'))),
+        child: FilledButton.tonal(
+          onPressed: () async {
+            final confirmed = await AsyncConfirmationSheet.show(
+              context,
+              message: context.translate(
+                'Firmware update is in progress. Interrupting the update may permanently damage the device. Are you sure you want to cancel?',
+              ),
+            );
+            if (confirmed) {
+              vm.cancelUpgrade();
+            }
+          },
+          child: Text(context.translate('Cancel')),
+        ),
       );
     }