Add properties, method and template tag for showing the right name (#2034)

Author: 0xUnicorn

src/backoffice/templates/approve_public_credit_names.html

@@ -19,17 +19,15 @@ <h2>Approve Public Credit Names</h2>
     <table class="table table-hover datatable">
       <thead>
         <tr>
-          <th>Username</th>
-          <th>Email</th>
-          <th>Public Credit Name</th>
+          <th>Private name</th>
+          <th>Public credit name</th>
           <th>Actions</th>
         </tr>
       </thead>
       <tbody>
         {% for profile in profiles %}
           <tr>
-            <td>{{ profile.user.username }}</td>
-            <td>{{ profile.user.email }}</td>
+            <td>{{ profile.private_name }}</td>
             <td>{{ profile.public_credit_name }}</td>
             <td>
               <a href="/admin/profiles/profile/{{ profile.pk }}/change/" class="btn btn-success">Open In Admin</a>

src/backoffice/templates/facilityfeedback_backoffice.html

@@ -16,36 +16,38 @@ <h3 class="card-title">Facility Feedback for {{ team.name }} Team ({{ feedback_l
         <form method="post">
           {{ formset.management_form }}
           {% csrf_token %}
-          {% for form, feedback in formset|zip:feedback_list %}
+          {% for form in formset %}
             <div class="card">
               <div class="card-header">
-                <h4 class="card-title">Feedback for {{ feedback.facility.name }} by {{ feedback.user.profile.public_credit_name|default:"Anonymous User" }}</h4>
+                <h4 class="card-title">
+                  Feedback for {{ form.instance.facility.name }} by {{ form.instance.user.profile.public_name|default:'Anonymous user' }}
+                </h4>
               </div>
               <div class="card-body">
                 <table class="table">
                   <tr>
-                    <th>Username</th>
-                    <td>{{ feedback.user }}</td>
+                    <th>User</th>
+                    <td>{{ form.instance.user.profile.private_name|default:'Anonymous user' }}</td>
                   </tr>
                   <tr>
                     <th>Created</th>
-                    <td>{{ feedback.created }}</td>
+                    <td>{{ form.instance.created }}</td>
                   </tr>
                   <tr>
                     <th>Facility</th>
-                    <td>{{ feedback.facility }}</td>
+                    <td>{{ form.instance.facility }}</td>
                   </tr>
                   <tr>
                     <th>Quick Feedback</th>
-                    <td><i class="{{ feedback.quick_feedback.icon }} fa-2x"></i> {{ feedback.quick_feedback }}</td>
+                    <td><i class="{{ form.instance.quick_feedback.icon }} fa-2x"></i> {{ form.instance.quick_feedback }}</td>
                   </tr>
                   <tr>
                     <th>Comment</th>
-                    <td>{{ feedback.comment|default:"N/A" }}</td>
+                    <td>{{ form.instance.comment|default:"N/A" }}</td>
                   </tr>
                   <tr>
                     <th>Urgent</th>
-                    <td class="{% if feedback.urgent %}text-bg-danger{% endif %}">{{ feedback.urgent|yesno }}</td>
+                    <td class="{% if form.instance.urgent %}text-bg-danger{% endif %}">{{ form.instance.urgent|yesno }}</td>
                   </tr>
                   <tr>
                     <th>Handled</th>

src/backoffice/templates/feedback_detail.html

@@ -1,4 +1,5 @@
 {% extends 'base.html' %}
+{% load profile_display %}
 
 {% block title %}
   Camp Feedback Detail | Orga | BackOffice | {{ block.super }}
@@ -28,7 +29,7 @@ <h3 class="card-title">
             {{ feedback.feedback|linebreaks }}
           </blockquote>
           <figcaption class="blockquote-footer">
-            <cite title="Source Title">{{ feedback.user.profile.public_credit_name }}</cite>
+            <cite title="Source Title">{% display_name feedback.user.profile %}</cite>
           </figcaption>
         </figure>
       </div>

src/backoffice/templates/feedback_list.html

@@ -20,8 +20,8 @@ <h2>Camp Feedback List</h2>
     <table class="table table-hover datatable">
       <thead>
         <tr>
-          <th>Username</th>
-          <th>Public Credit Name</th>
+          <th>Private name</th>
+          <th>Public credit name</th>
           <th>Feedback</th>
           <th>State</th>
           <th>Processed at</th>
@@ -32,8 +32,8 @@ <h2>Camp Feedback List</h2>
       <tbody>
         {% for feedback in object_list %}
           <tr>
-            <td>{{ feedback.user.username }}</td>
-            <td>{{ feedback.user.profile.public_credit_name }}</td>
+            <td>{{ feedback.user.profile.private_name }}</td>
+            <td>{{ feedback.user.profile.public_name }}</td>
             <td>{{ feedback.feedback|truncatewords:25 }}</td>
             <td>
               <span

src/backoffice/templates/feedback_processed_confirm.html

@@ -1,4 +1,5 @@
 {% extends 'base.html' %}
+{% load profile_display %}
 
 {% block title %}
   Confirm Camp Feedback Processed | {{ block.super }}
@@ -16,7 +17,7 @@ <h3 class="card-title">Mark event feedback as {{ state }}</h3>
             {{ feedback.feedback|linebreaks }}
           </blockquote>
           <figcaption class="blockquote-footer">
-            <cite title="Source Title">{{ feedback.user.profile.public_credit_name }}</cite>
+            <cite title="Source Title">{% display_name feedback.user.profile %}</cite>
           </figcaption>
         </figure>
       </div>

src/backoffice/templates/includes/invoice_list_panel.html

@@ -1,4 +1,6 @@
 {% load bornhack %}
+{% load profile_display %}
+
 {% if invoice_list %}
   <table class="table table-hover datatable">
     <thead>
@@ -16,7 +18,7 @@
       {% for invoice in invoice_list %}
         <tr>
           <td>{{ invoice.id }}</td>
-          <td>{% if invoice.order %}{{ invoice.order.user.username }} &lt;{{ invoice.order.user.email }}&gt;{% else %}{{ invoice.customorder.customer }}{% endif %}</td>
+          <td>{% if invoice.order %}{% display_name invoice.order.user.profile %} &lt;{{ invoice.order.user.email }}&gt;{% else %}{{ invoice.customorder.customer }}{% endif %}</td>
           <td data-order="{{ invoice.created|sortable }}">{{ invoice.created|date }}</td>
           <td data-order="{% if invoice.order %}{{ invoice.order.total }}{% else %}{{ invoice.customorder.amount }}{% endif %}">{% if invoice.order %}{{ invoice.order.total }}{% else %}{{ invoice.customorder.amount }}{% endif %}&nbsp;DKK</td>
           <td>{{ invoice.get_order }}</td>

src/backoffice/templates/includes/posreport_list_table.html

@@ -19,10 +19,10 @@
       <tr>
         <td data-order="{{ pr.period.lower|sortable }}"><a href="{% url 'backoffice:posreport_detail' camp_slug=camp.slug pos_slug=pos.slug posreport_uuid=pr.uuid %}">{{ pr.period.lower }} - {{ pr.period.upper }}</a></td>
         <td>
-            Bank&nbsp;Start:&nbsp;{{ pr.bank_responsible_start.profile.get_name|default:"N/A" }}<br>
-            Bank&nbsp;End:&nbsp;{{ pr.bank_responsible_end.profile.get_name|default:"N/A" }}<br>
-            Pos&nbsp;Start:&nbsp;{{ pr.pos_responsible_start.profile.get_name|default:"N/A" }}<br>
-            Pos&nbsp;End:&nbsp;{{ pr.pos_responsible_end.profile.get_name|default:"N/A" }}
+            Bank&nbsp;Start:&nbsp;{{ pr.bank_responsible_start.profile.private_name|default:"N/A" }}<br>
+            Bank&nbsp;End:&nbsp;{{ pr.bank_responsible_end.profile.private_name|default:"N/A" }}<br>
+            Pos&nbsp;Start:&nbsp;{{ pr.pos_responsible_start.profile.private_name|default:"N/A" }}<br>
+            Pos&nbsp;End:&nbsp;{{ pr.pos_responsible_end.profile.private_name|default:"N/A" }}
         </td>
         <td data-order="{{ pr.dkk_sales_izettle }}">{{ pr.dkk_sales_izettle }}&nbsp;DKK</td>
         <td data-order="{{ pr.dkk_balance }}" class="text-right">

src/backoffice/templates/includes/refund_list_panel.html

@@ -1,4 +1,6 @@
 {% load bornhack %}
+{% load profile_display %}
+
 <table class="table table-hover datatable">
   <thead>
     <tr>
@@ -19,7 +21,7 @@
     {% for refund in refund_list %}
       <tr>
         <td>{{ refund.id }}</td>
-        <td>{{ refund.order.user.username }} &lt;{{ refund.order.user.email }}&gt;</td>
+        <td>{% display_name refund.order.user.profile %} &lt;{{ refund.order.user.email }}&gt;</td>
         <td data-order="{{ refund.amount }}">{{ refund.amount }} DKK</td>
         <td data-order="{{ refund.created|sortable }}">{{ refund.created }}</td>
         <td data-order="{{ refund.updated|sortable }}">{{ refund.updated }}</td>

src/backoffice/templates/permissions_by_permission.html

@@ -27,13 +27,17 @@
                 <td>{{ perm.name }}</td>
                 <td>
                   <table class="table">
-                    <thead><tr><th>Username</th><th>Name</th><th>Public Credit Name</th></tr></thead>
+                    <thead>
+                      <tr>
+                        <th>Private name</th>
+                        <th>Public credit name</th>
+                      </tr>
+                    </thead>
                     <tbody>
                       {% for user in users %}
                         <tr>
-                          <td>{{ user.username }}</td>
-                          <td>{{ user.profile.name }}</td>
-                          <td>{{ user.profile.public_credit_name }}</td>
+                          <td>{{ user.profile.private_name }}</td>
+                          <td>{{ user.profile.public_name }}</td>
                         </tr>
                       {% endfor %}
                     </table>

src/backoffice/templates/permissions_by_user.html

@@ -14,9 +14,8 @@
       <table class="table table-striped table-hover datatable">
         <thead>
           <tr>
-            <th>Username</th>
-            <th>Name</th>
-            <th>Public Credit Name</th>
+            <th>Private name</th>
+            <th>Public credit name</th>
             <th class="text-center">Staff</th>
             <th class="text-center">Superuser</th>
             <th>User Permissions</th>
@@ -26,9 +25,8 @@
         <tbody>
           {% for user in user_list %}
             <tr>
-              <td>{{ user.username }}</td>
-              <td>{{ user.profile.name }}</td>
-              <td>{{ user.profile.public_credit_name }}</td>
+              <td>{{ user.profile.private_name }}</td>
+              <td>{{ user.profile.public_name }}</td>
               <td class="text-center">{{ user.is_staff|truefalseicon }}</td>
               <td class="text-center">{{ user.is_superuser|truefalseicon }}</td>
               <td>{% if user.is_superuser %}ALL{% else %}{% for perm in user.get_user_permissions %}{% if perm|slice:"0:6" == "camps." %}{{ perm }}<br>{% endif %}{% endfor %}{% endif %}</td>