Updated Coinify api

Author: zarya

.gitmodules

@@ -1,5 +0,0 @@
-
-[submodule "src/vendor/coinify"]
-	path = src/vendor/coinify
-	url = https://github.com/tykling/python-sdk
-	branch = python3-support

src/bornhack/environment_settings.py.dist

@@ -49,10 +49,9 @@ PDF_ARCHIVE_PATH='{{ pdf_archive_path }}'
 QUICKPAY_API_KEY="{{ quickpay_api_key }}"
 QUICKPAY_PRIVATE_KEY="{{ quickpay_private_key }}"
 
+COINIFY_API_URL='{{ coinify_api_url }}'
 COINIFY_API_KEY='{{ coinify_api_key }}'
-COINIFY_API_SECRET='{{ coinify_api_secret }}'
 COINIFY_IPN_SECRET='{{ coinify_ipn_secret }}'
-COINIFY_CALLBACK_HOSTNAME='{{ coinify_callback_hostname | default('') }}' # leave empty or comment out to use hostname from request
 
 # shop settings
 BANKACCOUNT_BANK='{{ bank_name }}'

src/shop/coinify.py

@@ -5,26 +5,26 @@
 from django.conf import settings
 
 from .models import CoinifyAPICallback
-from .models import CoinifyAPIInvoice
+from .models import CoinifyAPIPaymentIntent
 from .models import CoinifyAPIRequest
-from vendor.coinify.coinify_api import CoinifyAPI
 
 logger = logging.getLogger("bornhack.%s" % __name__)
 
 
-def process_coinify_invoice_json(invoicejson, order, request):
-    # create or update the invoice object in our database
-    coinifyinvoice, created = CoinifyAPIInvoice.objects.update_or_create(
-        coinify_id=invoicejson["id"],
+def process_coinify_payment_intent_json(intentjson, order, request):
+    # create or update the intent object in our database
+    coinifyintent, created = CoinifyAPIPaymentIntent.objects.update_or_create(
+        coinify_id=intentjson["id"],
         order=order,
-        defaults={"invoicejson": invoicejson},
+        defaults={"paymentintentjson": intentjson},
     )
 
     # if the order is paid in full call the mark as paid method now
-    if invoicejson["state"] == "complete" and not coinifyinvoice.order.paid:
-        coinifyinvoice.order.mark_as_paid(request=request)
+    if "state" in intentjson:
+        if intentjson["state"] == "complete" and not coinifyintent.order.paid:
+            coinifyintent.order.mark_as_paid(request=request)
 
-    return coinifyinvoice
+    return coinifyintent
 
 
 def save_coinify_callback(request, order):
@@ -51,55 +51,49 @@ def save_coinify_callback(request, order):
     return callbackobject
 
 
-def coinify_api_request(api_method, order, **kwargs):
-    # Initiate coinify API
-    coinifyapi = CoinifyAPI(settings.COINIFY_API_KEY, settings.COINIFY_API_SECRET)
-
-    # is this a supported method?
-    if not hasattr(coinifyapi, api_method):
-        logger.error("coinify api method not supported" % api_method)
-        return False
-
-    # get and run the API call using the SDK
-    method = getattr(coinifyapi, api_method)
-
-    # catch requests exceptions as described in https://github.com/CoinifySoftware/python-sdk#catching-errors and
-    # http://docs.python-requests.org/en/latest/user/quickstart/#errors-and-exceptions
+def coinify_api_request(api_method, order, payload):
+    url = f"{settings.COINIFY_API_URL}{api_method}"
+    headers = {
+        "accept": "application/json",
+        "content-type": "application/json",
+        "X-API-KEY": settings.COINIFY_API_KEY,
+    }
     try:
-        response = method(**kwargs)
+        response = requests.post(url, data=json.dumps(payload), headers=headers)
     except requests.exceptions.RequestException as E:
         logger.error("requests exception during coinify api request: %s" % E)
         return False
 
+    logger.error(response.text)
     # save this API request to the database
     req = CoinifyAPIRequest.objects.create(
         order=order,
         method=api_method,
-        payload=kwargs,
-        response=response,
+        payload=payload,
+        response=response.json(),
     )
     logger.debug("saved coinify api request %s in db" % req.id)
 
     return req
 
 
 def handle_coinify_api_response(apireq, order, request):
-    if apireq.method == "invoice_create" or apireq.method == "invoice_get":
+    if apireq.method == "payment-intents":
         # Parse api response
-        if apireq.response["success"]:
-            # save this new coinify invoice to the DB
-            coinifyinvoice = process_coinify_invoice_json(
-                invoicejson=apireq.response["data"],
+        if "paymentWindowUrl" in apireq.response:
+            # save this new coinify intent to the DB
+            coinifyintent = process_coinify_payment_intent_json(
+                intentjson=apireq.response,
                 order=order,
                 request=request,
             )
-            return coinifyinvoice
+            return coinifyintent
         else:
-            api_error = apireq.response["error"]
+            api_error = apireq.json()
             logger.error(
                 "coinify API error: {} ({})".format(
-                    api_error["message"],
-                    api_error["code"],
+                    api_error["errorMessage"],
+                    api_error["errorCode"],
                 ),
             )
             return False
@@ -112,36 +106,26 @@ def handle_coinify_api_response(apireq, order, request):
 # API CALLS
 
 
-def get_coinify_invoice(coinify_invoiceid, order, request):
-    # put args for API request together
-    invoicedict = {"invoice_id": coinify_invoiceid}
-
-    # perform the api request
-    apireq = coinify_api_request(api_method="invoice_get", order=order, **invoicedict)
-
-    coinifyinvoice = handle_coinify_api_response(apireq, order, request)
-    return coinifyinvoice
-
-
-def create_coinify_invoice(order, request):
+def create_coinify_payment_intent(order, request):
     # put args for API request together
-    invoicedict = {
+    intentdict = {
         "amount": float(order.total),
         "currency": "DKK",
-        "plugin_name": "BornHack webshop",
-        "plugin_version": "1.0",
-        "description": "BornHack order id #%s" % order.id,
-        "callback_url": order.get_coinify_callback_url(request),
-        "return_url": order.get_coinify_thanks_url(request),
-        "cancel_url": order.get_cancel_url(request),
+        "pluginIdentifier": "BornHack webshop",
+        "orderId": order.id,
+        "customerId": "bbca76fa-1337-439a-ae29-a3c2c2c84c4b",
+        "customerEmail": "coinifycustomer@bornhack.example",
+        "memo": "BornHack order id #%s" % order.id,
+        "successUrl": order.get_coinify_thanks_url(request),
+        "failureUrl": order.get_cancel_url(request),
     }
 
     # perform the API request
     apireq = coinify_api_request(
-        api_method="invoice_create",
+        api_method="payment-intents",
         order=order,
-        **invoicedict,
+        payload=intentdict,
     )
 
-    coinifyinvoice = handle_coinify_api_response(apireq, order, request)
-    return coinifyinvoice
+    coinifyintent = handle_coinify_api_response(apireq, order, request)
+    return coinifyintent

src/shop/migrations/0087_coinifyapipaymentintent.py

@@ -0,0 +1,31 @@
+# Generated by Django 4.2.16 on 2025-02-15 15:42
+
+from django.db import migrations, models
+import django.db.models.deletion
+import django_prometheus.models
+import uuid
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('shop', '0086_alter_product_price'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='CoinifyAPIPaymentIntent',
+            fields=[
+                ('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')),
+                ('created', models.DateTimeField(auto_now_add=True)),
+                ('updated', models.DateTimeField(auto_now=True)),
+                ('coinify_id', models.UUIDField(default=uuid.uuid4, editable=False)),
+                ('paymentintentjson', models.JSONField()),
+                ('order', models.ForeignKey(on_delete=django.db.models.deletion.PROTECT, related_name='coinify_api_payment_intents', to='shop.order')),
+            ],
+            options={
+                'abstract': False,
+            },
+            bases=(django_prometheus.models.ExportModelOperationsMixin('coinify_api_payment_intent'), models.Model),
+        ),
+    ]

src/shop/models.py

@@ -1,11 +1,11 @@
 import logging
+import uuid
 from datetime import timedelta
 from decimal import Decimal
 from enum import Enum
 from itertools import chain
 from typing import Optional
 
-from django.conf import settings
 from django.contrib import messages
 from django.contrib.auth.models import User
 from django.contrib.postgres.fields import DateTimeRangeField
@@ -166,21 +166,6 @@ def total(self):
         else:
             return False
 
-    def get_coinify_callback_url(self, request):
-        """Check settings for an alternative COINIFY_CALLBACK_HOSTNAME otherwise use the one from the request"""
-        if (
-            hasattr(settings, "COINIFY_CALLBACK_HOSTNAME")
-            and settings.COINIFY_CALLBACK_HOSTNAME
-        ):
-            host = settings.COINIFY_CALLBACK_HOSTNAME
-        else:
-            host = request.get_host()
-        return (
-            "https://"
-            + host
-            + str(reverse_lazy("shop:coinify_callback", kwargs={"pk": self.pk}))
-        )
-
     def get_coinify_thanks_url(self, request):
         return (
             "https://"
@@ -265,6 +250,20 @@ def coinifyapiinvoice(self):
         # nope
         return False
 
+    @property
+    def coinifyapipaymentintent(self):
+        if not self.coinify_api_payment_intents.exists():
+            return False
+
+        for tempinvoice in self.coinify_api_payment_intents.all():
+            # we already have a coinifypaymentintent for this order
+            if "paymentWindowUrl" in tempinvoice.paymentintentjson:
+                # this invoice is still active, we are good to go
+                return tempinvoice
+
+        # nope
+        return False
+
     @property
     def filename(self):
         return "bornhack_proforma_invoice_order_%s.pdf" % self.pk
@@ -1153,6 +1152,22 @@ def expired(self):
         return parse_datetime(self.invoicejson["expire_time"]) < timezone.now()
 
 
+class CoinifyAPIPaymentIntent(
+    ExportModelOperationsMixin("coinify_api_payment_intent"),
+    CreatedUpdatedModel,
+):
+    coinify_id = models.UUIDField(default=uuid.uuid4, editable=False)
+    paymentintentjson = models.JSONField()
+    order = models.ForeignKey(
+        "shop.Order",
+        related_name="coinify_api_payment_intents",
+        on_delete=models.PROTECT,
+    )
+
+    def __str__(self):
+        return "coinifypaymentintent for order #%s" % self.order.id
+
+
 class CoinifyAPICallback(
     ExportModelOperationsMixin("coinify_api_callback"),
     CreatedUpdatedModel,

src/shop/urls.py

@@ -87,6 +87,11 @@
             ],
         ),
     ),
+    path(
+        "blockchain/callback/",
+        CoinifyCallbackView.as_view(),
+        name="coinify_intent_callback",
+    ),
     path("creditnotes/", CreditNoteListView.as_view(), name="creditnote_list"),
     path(
         "creditnotes/<int:pk>/pdf/",