Fix indexing for multiple-call extraction of accelerometer data #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmi2_extract_accel only produces correct results when all of the accelerometer samples contained in the FIFO buffer are read in one call. (I am running it in headerless mode) Obviously, a workaround is to just call bmi2_extract_accel with a large enough buffer to fetch all the samples at once. But the existence of fields like acc_byte_start_idx in the bmi2_fifo_frame indicate to me that the library is intended to support multiple partial extraction of sensor data from the FIFO. Equivalent changes may need to be applied to gyr, aux and for header mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bmi2_extract_accel only produces correct results when all of the accelerometer samples contained in the FIFO buffer are read in one call. (I am running it in headerless mode)
Obviously, a workaround is to just call bmi2_extract_accel with a large enough buffer to fetch all the samples at once. But the existence of fields like acc_byte_start_idx in the bmi2_fifo_frame indicate to me that the library is intended to support multiple partial extraction of sensor data from the FIFO.
Equivalent changes may need to be applied to gyr, aux and for header mode.