Skip to content

Commit 1d8b4af

Browse files
ggouaillardetbosilca
authored andcommitted
orted/pmix: protect against NULL node in orte_pmix_server_register_nspace()
1 parent d1aa0b1 commit 1d8b4af

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

orte/orted/pmix/pmix_server_register_fns.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* Copyright (c) 2013-2016 Intel, Inc. All rights reserved.
1717
* Copyright (c) 2014 Mellanox Technologies, Inc.
1818
* All rights reserved.
19-
* Copyright (c) 2014 Research Organization for Information Science
19+
* Copyright (c) 2014-2016 Research Organization for Information Science
2020
* and Technology (RIST). All rights reserved.
2121
* $COPYRIGHT$
2222
*
@@ -382,11 +382,13 @@ int orte_pmix_server_register_nspace(orte_job_t *jdata)
382382
opal_list_append(pmap, &kv->super);
383383

384384
/* node ID */
385-
kv = OBJ_NEW(opal_value_t);
386-
kv->key = strdup(OPAL_PMIX_NODEID);
387-
kv->type = OPAL_UINT32;
388-
kv->data.uint32 = node->index;
389-
opal_list_append(pmap, &kv->super);
385+
if (NULL != node) {
386+
kv = OBJ_NEW(opal_value_t);
387+
kv->key = strdup(OPAL_PMIX_NODEID);
388+
kv->type = OPAL_UINT32;
389+
kv->data.uint32 = node->index;
390+
opal_list_append(pmap, &kv->super);
391+
}
390392
}
391393

392394
/* mark the job as registered */

0 commit comments

Comments
 (0)