🎨 rename fastPath to isSimplePattern

Signed-off-by: Yves Bastide <[email protected]>

Author: ybastide

RobotsTxt/LongestMatchRobotsMatchStrategy.cs

@@ -71,11 +71,11 @@ internal static bool MatchesSlow(ReadOnlySpan<byte> path, ReadOnlySpan<byte> pat
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    internal static int MatchFast(ReadOnlySpan<byte> path, ReadOnlySpan<byte> pattern, bool fastPath)
+    internal static int MatchFast(ReadOnlySpan<byte> path, ReadOnlySpan<byte> pattern, bool isSimplePattern)
     {
         if (pattern.Length == 0) return 0;
         if (path.Length == 0) return -1;
-        if (fastPath)
+        if (isSimplePattern)
         {
             return path.StartsWith(pattern) ? pattern.Length : -1;
         }

RobotsTxt/RobotsMachine.cs

@@ -10,16 +10,16 @@ private class State;
 
     private class UserAgentState : State;
 
-    private class AllowState(ReadOnlyMemory<byte> pattern, bool fastPath) : State
+    private class AllowState(ReadOnlyMemory<byte> pattern, bool isSimplePattern) : State
     {
         public ReadOnlyMemory<byte> Pattern { get; } = pattern;
-        public bool FastPath { get; } = fastPath;
+        public bool IsSimplePattern { get; } = isSimplePattern;
     }
 
-    private class DisallowState(ReadOnlyMemory<byte> pattern, bool fastPath) : State
+    private class DisallowState(ReadOnlyMemory<byte> pattern, bool isSimplePattern) : State
     {
         public ReadOnlyMemory<byte> Pattern { get; } = pattern;
-        public bool FastPath { get; } = fastPath;
+        public bool IsSimplePattern { get; } = isSimplePattern;
     }
 
     private readonly List<byte[]> _userAgents;
@@ -216,10 +216,10 @@ private static (int, int) AssessAccessRules(byte[] path, List<State> states)
             switch (state)
             {
                 case AllowState allow:
-                    allowHierarchy = Check(path, allow.Pattern.Span, allow.FastPath, allowHierarchy);
+                    allowHierarchy = Check(path, allow.Pattern.Span, allow.IsSimplePattern, allowHierarchy);
                     break;
                 case DisallowState disallow:
-                    disallowHierarchy = Check(path, disallow.Pattern.Span, disallow.FastPath, disallowHierarchy);
+                    disallowHierarchy = Check(path, disallow.Pattern.Span, disallow.IsSimplePattern, disallowHierarchy);
                     break;
             }
         }
@@ -229,9 +229,9 @@ private static (int, int) AssessAccessRules(byte[] path, List<State> states)
     private static readonly byte[] IndexHtmBytes = "/index.htm"u8.ToArray();
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static int Check(byte[] path, ReadOnlySpan<byte> pattern, bool fastPath, int currentPriority)
+    private static int Check(byte[] path, ReadOnlySpan<byte> pattern, bool isSimplePattern, int currentPriority)
     {
-        var priority = LongestMatchRobotsMatchStrategy.MatchFast(path, pattern, fastPath);
+        var priority = LongestMatchRobotsMatchStrategy.MatchFast(path, pattern, isSimplePattern);
         if (priority < 0) return currentPriority;
         if (currentPriority < priority)
         {

TestRobotsTxt/TestLongestMatchRobotsMatchStrategy.cs

@@ -30,10 +30,10 @@ public void TestMatch(string path, string pattern, bool expected, int len)
                     Encoding.UTF8.GetBytes(pattern)
                 );
             Assert.Equal(expected, actual);
-            var fastPath = !pattern.AsSpan().ContainsAny("*$");
+            var isSimplePattern = !pattern.AsSpan().ContainsAny("*$");
             var actualLen =
                 LongestMatchRobotsMatchStrategy.MatchFast(Encoding.UTF8.GetBytes(path),
-                    Encoding.UTF8.GetBytes(pattern), fastPath
+                    Encoding.UTF8.GetBytes(pattern), isSimplePattern
                 );
             Assert.Equal(len, actualLen);
             Assert.Equal(expected, actualLen >= 0);