feat(tunnel): prevent tunnel id collision (#638)

Co-authored-by: Xavier Hamel <xavier.hamel@botpress.com>
Co-authored-by: Xavier Hamel <76625630+xavierhamel@users.noreply.github.com>

Author: franklevasseur

tunnel/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bpinternal/tunnel",
-  "version": "0.1.24",
+  "version": "0.1.25",
   "description": "Tunneling logic for client and server",
   "main": "./dist/index.cjs",
   "browser": "./dist/index.mjs",

tunnel/src/tunnel-server.ts

@@ -90,10 +90,17 @@ export class TunnelServer {
       ws.close(code, reason)
       return
     }
+
     const { tunnelId } = parseResult
+    if (this._tunnels[tunnelId]) {
+      ws.close(errors.CLOSE_CODES.TUNNEL_ID_CONFLICT, 'tunnel ID already in use')
+      return
+    }
+
     const tunnel = new TunnelHead(tunnelId, ws)
     tunnel.events.once('close', () => this._handleDisconnection(tunnelId))
     this.events.emit('connection', tunnel)
+
     this._tunnels[tunnelId] = tunnel
   }