Merge pull request #339 from ginglis13/fix-pluto-proxy-panic

ginglis13 · web-flow · commit 42717c75ca11 · 2025-01-15T14:02:29.000-08:00
fix: parse proxy URI with prepending URL scheme
diff --git a/sources/aws-smithy-experimental/src/hyper_1_0.rs b/sources/aws-smithy-experimental/src/hyper_1_0.rs
@@ -256,7 +256,8 @@ mod build_connector {
         }
         let mut proxy = Proxy::new(intercept, proxy_uri);
         // Parse https_proxy as URL to extract out auth information if any
-        let proxy_url = Url::parse(https_proxy).expect("Unable to parse HTTPS proxy as URL");
+        let proxy_url =
+            Url::parse(&proxy.uri().to_string()).expect("Unable to parse HTTPS proxy as URL");
 
         if !proxy_url.username().is_empty() || proxy_url.password().is_some() {
             proxy.set_authorization(Authorization::basic(

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,8 @@ mod build_connector {`
`256`	`256`	`}`
`257`	`257`	`let mut proxy = Proxy::new(intercept, proxy_uri);`
`258`	`258`	`// Parse https_proxy as URL to extract out auth information if any`
`259`		`- let proxy_url = Url::parse(https_proxy).expect("Unable to parse HTTPS proxy as URL");`
	`259`	`+ let proxy_url =`
	`260`	`+ Url::parse(&proxy.uri().to_string()).expect("Unable to parse HTTPS proxy as URL");`
`260`	`261`
`261`	`262`	`if !proxy_url.username().is_empty() \|\| proxy_url.password().is_some() {`
`262`	`263`	`proxy.set_authorization(Authorization::basic(`