Skip to content

Commit 7a9380d

Browse files
authored
Merge pull request #651 from jmt-lab/eusc-de-east-1
add eusc-de-east-1 and us-isob-west-1 regions to account maps
2 parents 3c9f860 + d667606 commit 7a9380d

File tree

3 files changed

+37
-1
lines changed

3 files changed

+37
-1
lines changed

sources/api/schnauzer/src/helpers/mod.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ lazy_static! {
6262
m.insert("eu-west-1", "328549459982");
6363
m.insert("eu-west-2", "328549459982");
6464
m.insert("eu-west-3", "328549459982");
65+
m.insert("eusc-de-east-1", "587143065468");
6566
m.insert("il-central-1", "288123944683");
6667
m.insert("me-central-1", "553577323255");
6768
m.insert("me-south-1", "509306038620");
@@ -74,6 +75,7 @@ lazy_static! {
7475
m.insert("us-iso-east-1", "999945528765");
7576
m.insert("us-iso-west-1", "928668704122");
7677
m.insert("us-isob-east-1", "782457047625");
78+
m.insert("us-isob-west-1", "125731337581");
7779
m.insert("us-isof-east-1", "891631471851");
7880
m.insert("us-isof-south-1", "482061074055");
7981
m.insert("us-northeast-1", "891377225511");
@@ -115,8 +117,10 @@ lazy_static! {
115117
m.insert("us-iso-east-1", "bottlerocket-updates-us-iso-east-1.s3");
116118
m.insert("us-iso-west-1", "bottlerocket-updates-us-iso-west-1.s3");
117119
m.insert("us-isob-east-1", "bottlerocket-updates-us-isob-east-1.s3");
120+
m.insert("us-isob-west-1", "bottlerocket-updates-us-isob-west-1.s3");
118121
m.insert("us-isof-east-1", "bottlerocket-updates-us-isof-east-1.s3");
119122
m.insert("us-isof-south-1", "bottlerocket-updates-us-isof-south-1.s3");
123+
m.insert("eusc-de-east-1", "bottlerocket-updates-eusc-de-east-1.s3");
120124
m
121125
};
122126
}
@@ -130,11 +134,13 @@ lazy_static! {
130134
m.insert("cn-north-1", "aws-cn");
131135
m.insert("cn-northwest-1", "aws-cn");
132136
m.insert("eu-isoe-west-1", "aws-iso-e");
137+
m.insert("eusc-de-east-1", "aws-eusc");
133138
m.insert("us-gov-east-1", "aws-us-gov");
134139
m.insert("us-gov-west-1", "aws-us-gov");
135140
m.insert("us-iso-west-1", "aws-iso");
136141
m.insert("us-iso-east-1", "aws-iso");
137142
m.insert("us-isob-east-1", "aws-iso-b");
143+
m.insert("us-isob-west-1", "aws-iso-b");
138144
m.insert("us-isof-east-1", "aws-iso-f");
139145
m.insert("us-isof-south-1", "aws-iso-f");
140146
m
@@ -1546,6 +1552,7 @@ fn ecr_registry<S: AsRef<str>>(region: S) -> String {
15461552
"aws-iso-b" => format!("{registry_id}.dkr.ecr.{region}.sc2s.sgov.gov"),
15471553
"aws-iso-e" => format!("{registry_id}.dkr.ecr.{region}.cloud.adc-e.uk"),
15481554
"aws-iso-f" => format!("{registry_id}.dkr.ecr.{region}.csp.hci.ic.gov"),
1555+
"aws-eusc" => format!("{registry_id}.dkr.ecr.{region}.amazonaws.eu"),
15491556
_ => {
15501557
// Only inject the FIPS service endpoint if the variant is in FIPS mode and the
15511558
// region supports FIPS.
@@ -1577,6 +1584,7 @@ fn tuf_repository<S: AsRef<str>>(region: S) -> String {
15771584
"aws-iso-b" => format!("https://{endpoint}.{region}.sc2s.sgov.gov/latest"),
15781585
"aws-iso-e" => format!("https://{endpoint}.{region}.cloud.adc-e.uk/latest"),
15791586
"aws-iso-f" => format!("https://{endpoint}.{region}.csp.hci.ic.gov/latest"),
1587+
"aws-eusc" => format!("https://{endpoint}.{region}.amazonaws.eu/latest"),
15801588
_ => format!("https://{endpoint}.{region}.amazonaws.com/latest"),
15811589
}
15821590
}
@@ -1770,6 +1778,10 @@ mod test_ecr_registry {
17701778
"us-isof-east-1",
17711779
"891631471851.dkr.ecr.us-isof-east-1.csp.hci.ic.gov/bottlerocket-admin:v0.5.1",
17721780
),
1781+
(
1782+
"eusc-de-east-1",
1783+
"587143065468.dkr.ecr.eusc-de-east-1.amazonaws.eu/bottlerocket-admin:v0.5.1",
1784+
),
17731785
];
17741786

17751787
const ADMIN_CONTAINER_TEMPLATE: &str =

sources/host-ctr/cmd/host-ctr/main.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import (
4242

4343
// ECR hostname pattern also used in the ecr-credential-provider:
4444
// https://github.com/kubernetes/cloud-provider-aws/blob/212135d0d7b448cd34e2e11e5e81f59e3e6c2d7a/cmd/ecr-credential-provider/main.go#L45
45-
var ecrRegex = regexp.MustCompile(`^(\d{12})\.dkr[\.\-]ecr(-fips)?\.([a-zA-Z0-9][a-zA-Z0-9-_]*)\.(amazonaws\.com(?:\.cn)?|on\.(?:aws|amazonwebservices\.com\.cn)|sc2s\.sgov\.gov|c2s\.ic\.gov|cloud\.adc-e\.uk|csp\.hci\.ic\.gov).*$`)
45+
var ecrRegex = regexp.MustCompile(`^(\d{12})\.dkr[\.\-]ecr(-fips)?\.([a-zA-Z0-9][a-zA-Z0-9-_]*)\.(amazonaws(\.com(?:\.cn)?|\.eu)|on\.(?:aws|amazonwebservices\.com\.cn)|sc2s\.sgov\.gov|c2s\.ic\.gov|cloud\.adc-e\.uk|csp\.hci\.ic\.gov).*$`)
4646

4747
// A set of currently supported ECR regions which are not yet present in the golang SDK
4848
var ecrRefPrefixMapping = map[string]string{
@@ -52,9 +52,11 @@ var ecrRefPrefixMapping = map[string]string{
5252
"ap-southeast-6": "ecr.aws/arn:aws:ecr:ap-southeast-6:",
5353
"us-northeast-1": "ecr.aws/arn:aws:ecr:us-northeast-1:",
5454
"eu-isoe-west-1": "ecr.aws/arn:aws-iso-e:ecr:eu-isoe-west-1:",
55+
"eusc-de-east-1": "ecr.aws/arn:aws-eusc:ecr:eusc-de-east-1:",
5556
"us-iso-east-1": "ecr.aws/arn:aws-iso:ecr:us-iso-east-1:",
5657
"us-iso-west-1": "ecr.aws/arn:aws-iso:ecr:us-iso-west-1:",
5758
"us-isob-east-1": "ecr.aws/arn:aws-iso-b:ecr:us-isob-east-1:",
59+
"us-isob-west-1": "ecr.aws/arn:aws-iso-b:ecr:us-isob-west-1:",
5860
"us-isof-south-1": "ecr.aws/arn:aws-iso-f:ecr:us-isof-south-1:",
5961
"us-isof-east-1": "ecr.aws/arn:aws-iso-f:ecr:us-isof-east-1:",
6062
}

sources/host-ctr/cmd/host-ctr/main_test.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,17 @@ func TestParseImageURIAsECR(t *testing.T) {
202202
Fips: false,
203203
},
204204
},
205+
{
206+
"Parse special region",
207+
"777777777777.dkr.ecr.eusc-de-east-1.amazonaws.eu/my_image:latest",
208+
false,
209+
&parsedECR{
210+
Account: "777777777777",
211+
Region: "eusc-de-east-1",
212+
RepoPath: "my_image:latest",
213+
Fips: false,
214+
},
215+
},
205216
{
206217
"Parse special region",
207218
"777777777777.dkr.ecr.us-iso-east-1.c2s.ic.gov/my_image:latest",
@@ -224,6 +235,17 @@ func TestParseImageURIAsECR(t *testing.T) {
224235
Fips: false,
225236
},
226237
},
238+
{
239+
"Parse special region",
240+
"777777777777.dkr.ecr.us-isob-west-1.sc2s.sgov.gov/my_image:latest",
241+
false,
242+
&parsedECR{
243+
Account: "777777777777",
244+
Region: "us-isob-west-1",
245+
RepoPath: "my_image:latest",
246+
Fips: false,
247+
},
248+
},
227249
{
228250
"Parse special region",
229251
"777777777777.dkr.ecr.us-isof-east-1.csp.hci.ic.gov/my_image:latest",

0 commit comments

Comments
 (0)