Merge pull request #83 from bottlerocket-os/eligible-logs

srgothi92 · web-flow · commit a05f6026c7f7 · 2021-06-16T14:32:26.000-04:00
Added more details to eligible logs
diff --git a/updater/aws.go b/updater/aws.go
@@ -168,6 +168,7 @@ func (u *updater) eligible(containerInstance string) (bool, error) {
 	for _, listResult := range desc.Tasks {
 		startedBy := aws.StringValue(listResult.StartedBy)
 		if !strings.HasPrefix(startedBy, "ecs-svc/") {
+			log.Printf("Container instance %q has a non-service task running: %s", containerInstance, aws.StringValue(listResult.TaskArn))
 			return false, nil
 		}
 	}
diff --git a/updater/main.go b/updater/main.go
@@ -109,7 +109,7 @@ func _main() error {
 			continue
 		}
 		if !eligible {
-			log.Printf("Instance %#q is not eligible for updates", i)
+			log.Printf("Instance %#q is not eligible for updates because it contains non-service task", i)
 			continue
 		}
 		log.Printf("Instance %q is eligible for update", i)

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,7 @@ func (u *updater) eligible(containerInstance string) (bool, error) {`
`168`	`168`	`for _, listResult := range desc.Tasks {`
`169`	`169`	`startedBy := aws.StringValue(listResult.StartedBy)`
`170`	`170`	`if !strings.HasPrefix(startedBy, "ecs-svc/") {`
	`171`	`+ log.Printf("Container instance %q has a non-service task running: %s", containerInstance, aws.StringValue(listResult.TaskArn))`
`171`	`172`	`return false, nil`
`172`	`173`	`}`
`173`	`174`	`}`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ func _main() error {`
`109`	`109`	`continue`
`110`	`110`	`}`
`111`	`111`	`if !eligible {`
`112`		`- log.Printf("Instance %#q is not eligible for updates", i)`
	`112`	`+ log.Printf("Instance %#q is not eligible for updates because it contains non-service task", i)`
`113`	`113`	`continue`
`114`	`114`	`}`
`115`	`115`	`log.Printf("Instance %q is eligible for update", i)`